Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Introduce a checksum file cache service

This service is responsible for caching the checksums computed from

local file system. Because it's also used for dependency verification

writing and checking, this cache uses the existing infrastructure which

makes sure that if a file is updated locally, we expire the entry in

the cache.

This is done because there are lots of places in the code where we

used the legacy `HashUtil` class, which has no caching whatsoever.

It's, however, quite common to have a build which generates sha1

checksums multiple times for the same file. For example, during

publication.

    • -6
    • +9
    ./CachedDependencyResolutionIntegrationTest.groovy
  1. … 102 more files in changeset.
Introduce a checksum file cache service

This service is responsible for caching the checksums computed from

local file system. Because it's also used for dependency verification

writing and checking, this cache uses the existing infrastructure which

makes sure that if a file is updated locally, we expire the entry in

the cache.

This is done because there are lots of places in the code where we

used the legacy `HashUtil` class, which has no caching whatsoever.

It's, however, quite common to have a build which generates sha1

checksums multiple times for the same file. For example, during

publication.

    • -6
    • +9
    ./CachedDependencyResolutionIntegrationTest.groovy
  1. … 102 more files in changeset.
Introduce a checksum file cache service

This service is responsible for caching the checksums computed from

local file system. Because it's also used for dependency verification

writing and checking, this cache uses the existing infrastructure which

makes sure that if a file is updated locally, we expire the entry in

the cache.

This is done because there are lots of places in the code where we

used the legacy `HashUtil` class, which has no caching whatsoever.

It's, however, quite common to have a build which generates sha1

checksums multiple times for the same file. For example, during

publication.

    • -6
    • +9
    ./CachedDependencyResolutionIntegrationTest.groovy
  1. … 102 more files in changeset.
Introduce a checksum file cache service

This service is responsible for caching the checksums computed from

local file system. Because it's also used for dependency verification

writing and checking, this cache uses the existing infrastructure which

makes sure that if a file is updated locally, we expire the entry in

the cache.

This is done because there are lots of places in the code where we

used the legacy `HashUtil` class, which has no caching whatsoever.

It's, however, quite common to have a build which generates sha1

checksums multiple times for the same file. For example, during

publication.

    • -6
    • +9
    ./CachedDependencyResolutionIntegrationTest.groovy
  1. … 103 more files in changeset.
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -4
    • +4
    ./CachedChangingModulesIntegrationTest.groovy
    • -7
    • +7
    ./CachedDependencyResolutionIntegrationTest.groovy
    • -9
    • +9
    ./CachedMissingModulesIntegrationTest.groovy
    • -2
    • +2
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
    • -9
    • +9
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
    • -7
    • +7
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 867 more files in changeset.
Annotate integ tests failing with instant execution in various projects

removing most of @IgnoreWithInstantExecution annotations

after fixing the @FailsWithInstantExecution rule

and more ci feedback

also make @IgnoreWithInstantExecution require a reason from a fixed set

and add it to the remaining ignores

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -7
    • +7
    ./CachedDependencyResolutionIntegrationTest.groovy
    • -3
    • +2
    ./CachedMissingModulesIntegrationTest.groovy
    • -4
    • +3
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
  1. … 124 more files in changeset.
Annotate integ tests failing with instant execution in :dependencyManagement

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +4
    ./CachedChangingModulesIntegrationTest.groovy
    • -0
    • +7
    ./CachedDependencyResolutionIntegrationTest.groovy
    • -0
    • +10
    ./CachedMissingModulesIntegrationTest.groovy
    • -1
    • +2
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
    • -0
    • +10
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
    • -0
    • +7
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 88 more files in changeset.
Annotate integ tests failing with instant execution in :dependencyManagement

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +4
    ./CachedChangingModulesIntegrationTest.groovy
    • -0
    • +7
    ./CachedDependencyResolutionIntegrationTest.groovy
    • -0
    • +10
    ./CachedMissingModulesIntegrationTest.groovy
    • -1
    • +2
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
    • -0
    • +10
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
    • -0
    • +7
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 88 more files in changeset.
Annotate integ tests failing with instant execution in :dependencyManagement

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +4
    ./CachedChangingModulesIntegrationTest.groovy
    • -0
    • +7
    ./CachedDependencyResolutionIntegrationTest.groovy
    • -0
    • +10
    ./CachedMissingModulesIntegrationTest.groovy
    • -1
    • +2
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
    • -0
    • +10
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
    • -0
    • +7
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 88 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -36
    • +4
    ./CachedMissingModulesIntegrationTest.groovy
    • -1
    • +1
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
  1. … 94 more files in changeset.
wip - fix more tests

    • -36
    • +4
    ./CachedMissingModulesIntegrationTest.groovy
    • -1
    • +1
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
  1. … 45 more files in changeset.
wip - fix more tests

    • -36
    • +4
    ./CachedMissingModulesIntegrationTest.groovy
    • -1
    • +1
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
  1. … 13 more files in changeset.
wip - fix more tests

    • -36
    • +4
    ./CachedMissingModulesIntegrationTest.groovy
    • -1
    • +1
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
  1. … 44 more files in changeset.
wip - fix more tests

    • -36
    • +4
    ./CachedMissingModulesIntegrationTest.groovy
    • -1
    • +1
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
  1. … 45 more files in changeset.
Revert "Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'""

This reverts commit 0625bc7420e55e87730673231af6ad45dd04f47a.

    • -1
    • +1
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
    • -5
    • +5
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 89 more files in changeset.
Revert "Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'""

This reverts commit 0625bc7420e55e87730673231af6ad45dd04f47a.

    • -1
    • +1
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
    • -5
    • +5
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 89 more files in changeset.
Revert "Merge remote-tracking branch 'origin/sg/merges/pr-9419'"

This reverts commit 2f79026f5e127a8175e25844522237615b19ed52 because of a performance regression,

reversing changes made to 7f1e66079ce629ecde3e09e549e9796ab85761dc.

    • -1
    • +1
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
    • -5
    • +5
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 89 more files in changeset.
Allow http for 127.0.0.1

Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

    • -1
    • +1
    ./DefaultArtifactCacheLockingManagerIntegrationTest.groovy
    • -5
    • +5
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 15 more files in changeset.
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -3
    • +3
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 162 more files in changeset.
Use 'implementation' dependencies everywhere

    • -3
    • +3
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

    • -3
    • +3
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 283 more files in changeset.
Use 'implementation' dependencies everywhere

    • -3
    • +3
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

    • -3
    • +3
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

    • -3
    • +3
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 285 more files in changeset.
Use 'implementation' dependencies everywhere

    • -3
    • +3
    ./RecoverFromBrokenResolutionIntegrationTest.groovy
  1. … 285 more files in changeset.
spelling: though

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

    • -1
    • +1
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
Avoid locking the target project of project dependencies during task execution.

During work graph calculation, add an action that runs immediately after the producing task of an artifact completed that caclculates the dependency resolution metadata for that artifact. This happens before the consuming tasks are started, and so is available without locking when those tasks execute. Previously this calculation was done by consuming tasks, and they would need to lock the target project to do this.

This strategy works only for those tasks that declare that they will need these files (e.g. are declared as inputs in some form). For tasks that do not declare these inputs (possibly because there is no easy way to do so yet), the action is not added and the locking will still occur when the consuming task executes.

The implementation bolts a new concept onto the task nodes, as an increment towards making these actions real nodes in the graph that can be scheduled in the normal way.

    • -2
    • +55
    ./ParallelDependencyResolutionIntegrationTest.groovy
  1. … 27 more files in changeset.
Rewrite test to use HTTP resolve test fixtures

so that we don't rely on a side effect (deleting repo) to check behavior.

    • -8
    • +8
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
Rewrite test to use HTTP resolve test fixtures

so that we don't rely on a side effect (deleting repo) to check behavior.

    • -8
    • +8
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy
Remove `@Ignore` from test

    • -2
    • +0
    ./CachingDependencyMetadataInMemoryIntegrationTest.groovy