Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Moved PluginId to an interface & docs

PluginId was pulled into an interface so that we can control the

creation of those instances.

    • -2
    • +1
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 10 more files in changeset.
Moved PluginId to an interface & docs

PluginId was pulled into an interface so that we can control the

creation of those instances.

    • -2
    • +1
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 10 more files in changeset.
Encapsulate instantiation of DefaultPluginRequests

So `DefaultPluginRequests` doesn't have to be used by

gradle-script-kotlin.

See gradle/gradle-script-kotlin#186

    • -1
    • +1
    ./internal/PluginRequestCollectorTest.groovy
  1. … 3 more files in changeset.
Removing the interface and renaming impl

Removed PluginId interface and made DefaultPluginId be a class that we

share and part of the public API.

    • -2
    • +2
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 36 more files in changeset.
Removing the interface and renaming impl

Removed PluginId interface and made DefaultPluginId be a class that we

share and part of the public API.

    • -2
    • +2
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 36 more files in changeset.
Refactored names of classes, and finished up api

- Moved PluginRequest to InternalPluginRequest

- Created PluginRequest that InternalPluginRequest extends

- Made the code compile for RuleBasedPluginRepository

    • -2
    • +2
    ./internal/PluginRequestCollectorTest.groovy
  1. … 49 more files in changeset.
Refactored names of classes, and finished up api

- Moved PluginRequest to InternalPluginRequest

- Created PluginRequest that InternalPluginRequest extends

- Made the code compile for RuleBasedPluginRepository

    • -2
    • +2
    ./internal/PluginRequestCollectorTest.groovy
  1. … 49 more files in changeset.
Working on the changes per Stefan's request.

Moving PluginId to be a public Interface, and then created an

implementation called DefaultPluginId

Added the first phase of interfaces (inside the class, will move out

later) so that I can start working on the API under the hood.

    • -2
    • +2
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 35 more files in changeset.
Working on the changes per Stefan's request.

Moving PluginId to be a public Interface, and then created an

implementation called DefaultPluginId

Added the first phase of interfaces (inside the class, will move out

later) so that I can start working on the API under the hood.

    • -2
    • +2
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 35 more files in changeset.
Revert "Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release"

This reverts commit 506f8ce9d6dc1a81e8ff10575c512778ca2f382a.

    • -2
    • +2
    ./internal/PluginRequestCollectorTest.groovy
    • -3
    • +4
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 198 more files in changeset.
Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release

    • -2
    • +2
    ./internal/PluginRequestCollectorTest.groovy
    • -4
    • +3
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 198 more files in changeset.
Add `apply false` option to `plugins` block

This solves two use cases at once:

- only using some classes from a plugin without applying it

- applying a plugin to sub-projects without applying it to the root project

    • -2
    • +2
    ./internal/PluginRequestCollectorTest.groovy
    • -3
    • +4
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 17 more files in changeset.
Revert plugins.subprojects syntax, as we are considering another solution

    • -0
    • +79
    ./internal/PluginRequestCollectorTest.groovy
    • -0
    • +48
    ./internal/PluginRequestsSerializerTest.groovy
    • -68
    • +0
    ./internal/ProjectPluginRequestCollectorTest.groovy
  1. … 35 more files in changeset.
Allow applying plugins to subprojects using new DSL

This change adds new `subprojects` and `allprojects` methods to the `plugins`

DSL, which allow users to apply plugins to multiple subprojects at once.

The plugins are resolved in the context of the parent project and put on

the parent's classpath. This ensures that the parent can cross-configure its

children. A side-effect is that unrelated subprojects will see those plugin

classes too, even though they are not applied to them.

The `plugins` block is no longer backed by an AST transformation, but is

now compiled, exactly like the `buildscript` and `pluginRepositories` blocks.

This will give users greater flexibility to conditionally apply plugins in the

future. Currently no access is granted to any methods outside of the `plugins`

API though.

    • -79
    • +0
    ./internal/PluginRequestCollectorTest.groovy
    • -48
    • +0
    ./internal/PluginRequestsSerializerTest.groovy
    • -0
    • +68
    ./internal/ProjectPluginRequestCollectorTest.groovy
  1. … 36 more files in changeset.
Renamed package o.g.messaging.serialize to o.g.internal.serialize.

    • -1
    • +1
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 171 more files in changeset.
Extract plugin request from the new plugins DSL at compile time instead of runtime

+review REVIEW-5395

    • -79
    • +0
    ./internal/PluginDependenciesServiceTest.groovy
    • -0
    • +79
    ./internal/PluginRequestCollectorTest.groovy
  1. … 14 more files in changeset.
Add PluginRequests types and a serializer for it

+review REVIEW-5395

    • -0
    • +48
    ./internal/PluginRequestsSerializerTest.groovy
  1. … 6 more files in changeset.
Move duplicate plugin declaration detection out of DefaultScriptPluginFactory.

+review REVIEW-5154

    • -0
    • +79
    ./internal/PluginDependenciesServiceTest.groovy
  1. … 5 more files in changeset.
REVIEW-4921 - add PluginId type.

Also addresses REVIEW-4918.

  1. … 15 more files in changeset.
REVIEW-4952 - move test.

    • -0
    • +52
    ./internal/PluginIdsTest.groovy
  1. … 1 more file in changeset.