Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Force AbstractTestDirectoryProvider to use Class (#12431)

Closes https://github.com/gradle/gradle-private/issues/2988

This PR adds `className` to `AbstractTestDirectoryProvider` so there'll be no more `unknown-test-class`.

    • -1
    • +1
    ./DefaultBuildOperationLoggerFactoryTest.groovy
    • -1
    • +1
    ./DefaultBuildOperationLoggerTest.groovy
  1. … 406 more files in changeset.
Fix tests

    • -1
    • +1
    ./DefaultBuildOperationLoggerFactoryTest.groovy
    • -1
    • +1
    ./DefaultBuildOperationLoggerTest.groovy
  1. … 371 more files in changeset.
Fix unit tests

    • -1
    • +8
    ./LoggingBuildOperationProgressBroadcasterTest.groovy
  1. … 1 more file in changeset.
Fix error in handling debug logging created before run build build op has started

    • -4
    • +1
    ./LoggingBuildOperationProgressBroadcasterTest.groovy
  1. … 1 more file in changeset.
Fallback to attach output from external threads to root build operation

    • -3
    • +9
    ./LoggingBuildOperationProgressBroadcasterTest.groovy
  1. … 2 more files in changeset.
Remove the 'parent build operation' property from `ProgressStartEvent` as this can be inferred from the other properties. Reduce the amount of mapping required to perform console output grouping and to simplify the output event stream before it is seen by any consumers.

    • -1
    • +1
    ./LoggingBuildOperationProgressBroadcasterTest.groovy
  1. … 11 more files in changeset.
Merge the 'short description' and 'status' properties on progress start events, to avoid the cost of tracking and serializing these separately.

    • -1
    • +1
    ./LoggingBuildOperationProgressBroadcasterTest.groovy
  1. … 22 more files in changeset.
Avoid deadlock between output event renderer and listener manager (#4661)

Previously, the output event listener that forward build op notifications was downstream of the output event renderer, which has its own lock. It was possible to deadlock between this lock and the global listener manager lock.

Now, the build op notification forwarder is a peer of the renderer, so is not notified under its lock.

    • -6
    • +6
    ./LoggingBuildOperationProgressBroadcasterTest.groovy
  1. … 12 more files in changeset.
Emit build operation progress events for logging output (#4537)

* Tweak BuildOperationListener#progress api

* Use build operation id to reference progress

* Add workaround for tracing log output via build operation progress for composite builds

* Replace some Object typing of operation identifiers with OperationIdentifier.

* Associate all progress logging with the current build operation.

* Update logic to accommodate for all progress events now having build operation IDs.

* Don't allow ProgressStartEvent.buildOperationCategory to be null.

** Default it to uncategorized.

    • -0
    • +92
    ./LoggingBuildOperationProgressBroadcasterTest.groovy
  1. … 50 more files in changeset.
Close `BuildOperationLogger` in unit test

    • -0
    • +7
    ./DefaultBuildOperationLoggerTest.groovy
Fix `BuildOperationLogger` so that it opens file on `start()`

Previously, `DefaultBuildOperationLoggerFactory#newOperationLogger` would

open the backing output file. This file is then closed on BuildOperationLogger.done().

This change moves the opening of the output file to `BuildOperationLogger.start()`

making start/done symmetrical, and making it easier to cleanup in a finally block.

This fix addresses some leaky file handles in native integration tests.

    • -8
    • +10
    ./DefaultBuildOperationLoggerTest.groovy
  1. … 5 more files in changeset.
Moved internal logging classes from 'core' to 'logging' project.

    • -1
    • +1
    ./DefaultBuildOperationLoggerTest.groovy
  1. … 418 more files in changeset.
Clean up review comments

+review REVIEW-5406

    • -7
    • +13
    ./DefaultBuildOperationLoggerTest.groovy
  1. … 5 more files in changeset.
Add BuildOperationLogger and factory

A task will start() and overall build operation, execute the

underlying operations and then call done() to wrap up the overall

action.

For the native tools, we currently buffer the output in

DefaultCommandLineToolInvocationWorker and only try to write the

output once the operation is complete/failed.

The BuildOperationLogger writes the output for the operations to

a log file and writes up to N-operations to Gradle's standard out.

+review REVIEW-5406

    • -0
    • +55
    ./DefaultBuildOperationLoggerFactoryTest.groovy
    • -0
    • +147
    ./DefaultBuildOperationLoggerTest.groovy
  1. … 30 more files in changeset.