fingerprint

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Visitor should be the last argument

so a Closure can be used in a nice way.

    • -1
    • +1
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -2
    • +2
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 6 more files in changeset.
Wrap the patternSet

Instead of using a strategy.

    • -1
    • +1
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
    • -1
    • +1
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 36 more files in changeset.
Move the tests around

    • -2
    • +2
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -3
    • +3
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 62 more files in changeset.
Move the tests around

    • -2
    • +2
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -3
    • +3
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 62 more files in changeset.
Move comparing fingerprints to execution

It made no sense to have the compare strategy on

FileCollectionFingerprint anyway.

    • -1
    • +2
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -1
    • +2
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 57 more files in changeset.
Move comparing fingerprints to execution

It made no sense to have the compare strategy on

FileCollectionFingerprint anyway.

    • -1
    • +2
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -1
    • +2
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 57 more files in changeset.
Do not use PatternSet in snapshots package

Use a pluggable type instead.

    • -18
    • +14
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
    • -4
    • +1
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
    • -9
    • +1
    ./impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 41 more files in changeset.
Do not use PatternSet in snapshots package

Use a pluggable type instead.

    • -18
    • +14
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
    • -4
    • +1
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
    • -9
    • +1
    ./impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 41 more files in changeset.
Use only FileSystemSnapshotter from FileCollectionSnapshotter

    • -1
    • +1
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
    • -1
    • +1
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
    • -1
    • +1
    ./impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 13 more files in changeset.
Move file collection snapshotting to core

    • -1
    • +3
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
    • -2
    • +3
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
    • -0
    • +269
    ./impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 23 more files in changeset.
Move file collection snapshotting to core

    • -1
    • +3
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
    • -2
    • +3
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
    • -0
    • +269
    ./impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 22 more files in changeset.
Move file collection snapshotting to core

    • -1
    • +3
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
    • -0
    • +269
    ./impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 18 more files in changeset.
Move fingerprinters to the core project

    • -0
    • +304
    ./impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 29 more files in changeset.
Revert "Revert "Merge pull request #9344 from gradle/oehme/zip-hashing""

This reverts commit 4ce18d53224f02f0a764849e938a8fc85f85413c.

    • -10
    • +10
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
  1. … 17 more files in changeset.
Revert "Merge pull request #9344 from gradle/oehme/zip-hashing"

This reverts commit 9c6dd6f2615ac11e88fe5dff67a595a3902ff535, reversing

changes made to b049f7a5c1d4aa35a384103ac5061a2d4e4de317.

    • -10
    • +10
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
  1. … 17 more files in changeset.
Revert "Merge pull request #9344 from gradle/oehme/zip-hashing"

This reverts commit 9c6dd6f2615ac11e88fe5dff67a595a3902ff535, reversing

changes made to b049f7a5c1d4aa35a384103ac5061a2d4e4de317.

    • -10
    • +10
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
  1. … 17 more files in changeset.
Handle empty nested jars

Add unit tests for this and the non-empty case.

    • -10
    • +10
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
  1. … 2 more files in changeset.
Handle empty nested jars

Add unit tests for this and the non-empty case.

    • -10
    • +10
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
  1. … 2 more files in changeset.
Handle empty nested jars

Add unit tests for this and the non-empty case.

    • -10
    • +10
    ./classpath/impl/DefaultClasspathFingerprinterTest.groovy
  1. … 2 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Address review feedback

    • -17
    • +33
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 7 more files in changeset.
Provide normalized path in FileChange

    • -3
    • +3
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 15 more files in changeset.
Provide normalized path in FileChange

    • -3
    • +3
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 15 more files in changeset.
Provide normalized path in FileChange

    • -23
    • +17
    ./classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 15 more files in changeset.