ClasspathFingerprintCompareStrategyTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove includedAdded (#9860)

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -101
    • +39
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 20 more files in changeset.
Remove includedAdded (#9860)

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -101
    • +39
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 20 more files in changeset.
Address more review feedback

    • -5
    • +4
    ./ClasspathFingerprintCompareStrategyTest.groovy
TODO

    • -8
    • +8
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 45 more files in changeset.
Split FileType into SnapshotFileType and FingerprintFileType

    • -8
    • +8
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 44 more files in changeset.
Split FileType into SnapshotFileType and FingerprintFileType

    • -8
    • +8
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 44 more files in changeset.
TODO

    • -8
    • +8
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 45 more files in changeset.
Split FileType into SnapshotFileType and FingerprintFileType

    • -8
    • +8
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 45 more files in changeset.
Address review feedback

    • -20
    • +41
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 1 more file in changeset.
Remove includedAdded

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -119
    • +37
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 20 more files in changeset.
Remove includedAdded

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -119
    • +37
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 20 more files in changeset.
Remove includedAdded

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -119
    • +37
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 20 more files in changeset.
Remove includedAdded

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -119
    • +37
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 20 more files in changeset.
Address review feedback

    • -1
    • +5
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 30 more files in changeset.
Address review feedback

    • -1
    • +5
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Visitor should be the last argument

so a Closure can be used in a nice way.

    • -1
    • +1
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 7 more files in changeset.
Move the tests around

    • -2
    • +2
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 63 more files in changeset.
Move the tests around

    • -2
    • +2
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 63 more files in changeset.
Move comparing fingerprints to execution

It made no sense to have the compare strategy on

FileCollectionFingerprint anyway.

    • -1
    • +2
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 58 more files in changeset.
Move comparing fingerprints to execution

It made no sense to have the compare strategy on

FileCollectionFingerprint anyway.

    • -1
    • +2
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 58 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Added verb to `includeAdded` properties (i.e. `shouldIncludeAdded`) to make the subject obvious

I.e. whether we should include the `added` content vs is the include property added to something

    • -32
    • +32
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 13 more files in changeset.
Address review feedback

    • -17
    • +33
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 7 more files in changeset.
Provide normalized path in FileChange

    • -3
    • +3
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 15 more files in changeset.
Provide normalized path in FileChange

    • -3
    • +3
    ./ClasspathFingerprintCompareStrategyTest.groovy
  1. … 15 more files in changeset.