internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use Nullable instead of Optional annotation to mark nullable map params

We shouldn't use something from org.gradle.api.tasks in the MapNotationConverter anyway.

    • -6
    • +7
    ./typeconversion/MapNotationConverterTest.groovy
  1. … 9 more files in changeset.
ProjectLayout APIs for resolving files and creating immutable FileTrees

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -17
    • +1
    ./fingerprint/impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 6 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

    • -5
    • +2
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 41 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

    • -5
    • +2
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 41 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

    • -5
    • +2
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 41 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

    • -5
    • +2
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 41 more files in changeset.
Fixes for previous commit.

    • -2
    • +3
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 16 more files in changeset.
Fixes for previous commit.

    • -2
    • +3
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 16 more files in changeset.
Fixes for previous commit.

    • -2
    • +3
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 16 more files in changeset.
Introduce a factory service to create instances of `TaskDependency`, to allow the implementations to be contextualized and to use types that aren't part of the (internal) core API.

Use this factory in `DefaultConfigurableFileCollection`.

    • -2
    • +3
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 39 more files in changeset.
Introduce a factory service to create instances of `TaskDependency`, to allow the implementations to be contextualized and to use types that aren't part of the (internal) core API.

Use this factory in `DefaultConfigurableFileCollection`.

    • -2
    • +3
    ./cleanup/DefaultBuildOutputCleanupRegistryTest.groovy
  1. … 39 more files in changeset.
Do not keep reference to Stat in SnapshottingFilter

    • -1
    • +1
    ./fingerprint/impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 14 more files in changeset.
Rename FileSystemSnapshotVisitor.{visit -> visitFile} (#9858)

So it is more obvious that directory snapshots are not passed into this

method.

    • -1
    • +1
    ./fingerprint/impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 24 more files in changeset.
Remove includedAdded (#9860)

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -101
    • +39
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -21
    • +1
    ./fingerprint/impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 19 more files in changeset.
Remove includedAdded (#9860)

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -101
    • +39
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -21
    • +1
    ./fingerprint/impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 19 more files in changeset.
Address more review feedback

    • -5
    • +4
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
TODO

    • -8
    • +8
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 45 more files in changeset.
Split FileType into SnapshotFileType and FingerprintFileType

    • -8
    • +8
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 44 more files in changeset.
Split FileType into SnapshotFileType and FingerprintFileType

    • -8
    • +8
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 44 more files in changeset.
TODO

    • -8
    • +8
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 45 more files in changeset.
Split FileType into SnapshotFileType and FingerprintFileType

    • -8
    • +8
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 45 more files in changeset.
Address review feedback

    • -20
    • +41
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
  1. … 1 more file in changeset.
Rename FileSystemSnapshotVisitor.{visit -> visitFile}

So it is more obvious that directory snapshots are not passed into this

method.

    • -1
    • +1
    ./fingerprint/impl/DefaultFileCollectionSnapshotterTest.groovy
  1. … 23 more files in changeset.
Remove includedAdded

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -119
    • +37
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -21
    • +1
    ./fingerprint/impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 19 more files in changeset.
Remove includedAdded

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -119
    • +37
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -21
    • +1
    ./fingerprint/impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 19 more files in changeset.
Remove includedAdded

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -119
    • +37
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -21
    • +1
    ./fingerprint/impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 19 more files in changeset.
Remove includedAdded

Since we filter the before execution output snapshot, we don't need

`includeAdded` any more.

    • -119
    • +37
    ./fingerprint/classpath/impl/ClasspathFingerprintCompareStrategyTest.groovy
    • -21
    • +1
    ./fingerprint/impl/AbsolutePathFileCollectionFingerprinterTest.groovy
  1. … 19 more files in changeset.
Move FileAccessTimeJournal to :pineapple

    • -1
    • +1
    ./classpath/DefaultCachedClasspathTransformerTest.groovy
    • -0
    • +1
    ./resource/local/GroupedAndNamedUniqueFileStoreTest.groovy
  1. … 19 more files in changeset.
Revert "Merge pull request #9604 from gradle/oehme/fix-zip-hashing"

This reverts commit 8cea5a026e65c3bbe7312d91f6f6bef898108617, reversing

changes made to ea2bd4230925fdf31926f34053d56d1085176861.

    • -15
    • +15
    ./fingerprint/classpath/impl/DefaultClasspathFingerprinterTest.groovy
  1. … 17 more files in changeset.
Release project lock when instructed if all work items complete

With this change, a call to

`AsyncWorkTracker.waitForCompletion(RELEASE_PROJECT_LOCKS)` will _always_

release the project lock, even if all work items are complete. This means

the lock release is consistent whether or not the work items are

pending when the task action completes.

    • -6
    • +21
    ./work/DefaultAsyncWorkTrackerTest.groovy
  1. … 1 more file in changeset.