DefaultIsolatedAntBuilderTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -4
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 162 more files in changeset.
Use 'implementation' dependencies everywhere

    • -4
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

    • -4
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 283 more files in changeset.
Use 'implementation' dependencies everywhere

    • -4
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

    • -4
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

    • -4
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 285 more files in changeset.
Use 'implementation' dependencies everywhere

    • -4
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 285 more files in changeset.
Revert unnecessary changes

Since we reverted to using groovy-all.jar, there is no need for these changes anymore.

    • -2
    • +5
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 11 more files in changeset.
Fix DefaultIsolatedAntBuilder

    • -1
    • +1
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 1 more file in changeset.
Bind lifecycle of level and OutputEventListener in ConfigureLogging rule

This is a followup to 8fd0c8bd1f72a1ce2513efce354c34ecbc5d7e04 to

attempt at fixing flakiness issue due to MemoryManager debug messages

emitted to a test listener only interested in >info messages.

The ConfigureLogging rule constructor now accepts a LogLevel to prevent

a race condition where logging level is set later, e.g. by a

@Before/setup method or directly in a test, possibly calling the

OutputEventListener with unwanted events.

    • -13
    • +12
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 1 more file in changeset.
Add more test coverage for logging in worker processes

    • -4
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 9 more files in changeset.
Moved logging test fixtures from 'core' to 'logging' project.

    • -2
    • +2
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 49 more files in changeset.
Moved the public logging API classes from `core` to new `logging` project.

    • -2
    • +2
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 23 more files in changeset.
Introduce installation beacon and refactor representation of Gradle installation

- Installation discovery by finding JAR in lib directory

- Minor improvements

+review REVIEW-5867

    • -1
    • +2
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 47 more files in changeset.
Changed DefaultIsolatedAntBuilder so that it cleans up synchronously rather than at the whim of the garbage collector.

    • -1
    • +7
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 2 more files in changeset.
Slightly update the logic of the test * even if run independently, the test passes, it has chances to fail when run in a suite * the reason it can fail is that the cache is sensitive to memory pressure, so cache entries can be removed, and the test accesses private data (the classloader) * so we adjust the test so that the classloaders are picked in the same session, before the cache entry can be collected

+review REVIEW-5606

    • -4
    • +5
    ./DefaultIsolatedAntBuilderTest.groovy
Rework broken memory leak prevention system * migrate DefaultIsolatedAntBuilder to Java * implement memory sensitive caching of classloaders * implement cleaning strategy based on which classloader leak into what other classloader * there were classes from Gradle leaking into the isolated builder too

+review REVIEW-5606

    • -0
    • +1
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 19 more files in changeset.
Use a custom slf4j binding instead of logback.

+review REVIEW-5417

    • -9
    • +9
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 31 more files in changeset.
REVIEW-5197 - Avoid creating a new isolated copy of Groovy/Gradle core for each distinct isolated ant builder

    • -3
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 1 more file in changeset.
Remove ability to use AntBuilder from arbitrary Groovy versions.

We don't need this capability, and this simplifies the implementation of the isolated ant builder and saves on some perm gen in our tests.

+review

    • -60
    • +29
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 5 more files in changeset.
Moved ClasspathUtil and ClassLoaderFactory and impl to baseServices.

    • -2
    • +2
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 36 more files in changeset.
- Changed LoggingServiceRegistry.newEmbeddableLogging() so that it will configure logback and removed SimpleLogbackLoggingConfigurer. - Added unit test coverage for LoggingServiceRegistry.

    • -2
    • +2
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 10 more files in changeset.
Converted LoggingTestHelper into a JUnit rule.

    • -28
    • +8
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 5 more files in changeset.
- Introduced (internal) ClassPath abstraction, and changed ClassPathRegistry to return these, rather than sets of various kinds.

    • -2
    • +2
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 15 more files in changeset.
Removed unused imports.

    • -2
    • +0
    ./DefaultIsolatedAntBuilderTest.groovy
- Changed IsolatedAntBuilder so that logging APIs are injected into the isolated classloader. - Changed IsolatedAntBuilder to load ant and groovy in a separate classloader to the task implementation, and cache each ant+groovy classloader, to avoid loading groovy in multiple classloaders (one for groovyc, one for codenarc, etc). - Changed code quality plugins to exclude logging dependencies that are provided by the runtime.

    • -4
    • +47
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 3 more files in changeset.
Changed code quality tasks to use IsolatedAntBuilder to run tasks, to pick up some ClassLoader caching and to avoid creating a new ClassLoader for each execution (in particular, CodeNarc was creating a copy of Groovy for each execution).

    • -0
    • +10
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 6 more files in changeset.
GRADLE-1791 - Changed dependencies.gradleApi() to expose all plugins + the tooling API

    • -5
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 12 more files in changeset.
GRADLE-1699 - Use ModuleRegistry to build more classpaths used internally.

    • -1
    • +4
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 20 more files in changeset.
GRADLE-1699 - Changed dependencies.gradleApi() so that it provides the 'plugins' project as well as 'core' and 'core-impl'. - Added some int test coverage. - Extracted the stuff in DependendencyClassPathProvider into DefaultModuleRegistry, and fixed it so that it properly finds the classes and static and generated resources when running under IDEA and Eclipse.

    • -2
    • +2
    ./DefaultIsolatedAntBuilderTest.groovy
  1. … 14 more files in changeset.