CopyActionExecuterTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

  1. … 41 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

  1. … 41 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

  1. … 41 more files in changeset.
Replace usages of `FileResolver.resolveFile()` with `FileCollectionFactory.resolving()` or `FileOperations.immutable()`, so that `FileResolver` can be responsible only for converting scalar values to File-ish values.

  1. … 41 more files in changeset.
Allow the services required by a given class to be queried prior to creating any instances of that class. Use this to allow `ArtifactTransformDependencies` to be injected into artifact transforms using any of the service injection patterns (that is, via a constructor or a getter).

  1. … 127 more files in changeset.
Replace most direct usages of `DirectInstantiator` with indirect usages via `InstantiatorFactory` or test fixtures instead. This means more consistent behaviour in unit tests because the objects under test will behave more similarly to how they do at runtime. This also allows the decision of how the instantiation should behave to live in as few places as possible, so this can be more easily evolved and contextualized.

  1. … 60 more files in changeset.
Use constant WorkResult objects (#2781)

Instead of creating new ones all the time. This is take two, as #2776 failed due to SimpleWorkResult being used in third-party plugins.

  1. … 27 more files in changeset.
Revert "Use static WorkResult objects (#2776)"

This reverts commit c4d529671a4d26a46a4e0cbfa41db96ec90d0671.

  1. … 24 more files in changeset.
Use static WorkResult objects (#2776)

There's no need to create new ones all the time.

  1. … 24 more files in changeset.
Use directory walker for reproducible archives

Instead of sorting the files after reading them from disk we

use `ReproducibleDirectoryWalker` to directly read them from disk in

a reproducible way independent of the file system.

This has the advantage that we do not add some special handling for

zipTree and tarTree. It probably has some performance impact when

having walking the file system but the impact should actually be

less than sorting afterwards since we sort smaller lists and we do

not need to keep all the file names in an archive in memory.

  1. … 28 more files in changeset.
Make DirectInstantiator a singleton.

  1. … 89 more files in changeset.
Removed some direct usages of FileSystems.default.

  1. … 20 more files in changeset.
Introduce a specific type for the action that gets called when processing a stream of things to copy.

This paves the way for DirectoryCopyDetails, LinkCopyDetails etc.

  1. … 14 more files in changeset.
REVIEW-2733 - improve test case name.

REVIEW-2710 - remove convenience constructor.

  1. … 6 more files in changeset.
REVIEW-2728 - introduce a specific type for the action that represents a stream of file copy details to process.

This doesn't change the design, just makes things more explicit than using Action to model this function.

  1. … 17 more files in changeset.
Remove the duplicate logging.

  1. … 7 more files in changeset.
Unit test for CopyActionExecuter.

Rename the CopySpecContentVisitor type to CopyAction.

    • -0
    • +24
    ./CopyActionExecuterTest.groovy
  1. … 40 more files in changeset.