internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Moving to new pluginManagement dsl

Deleting classes that aren't used anymore. Writing some tests for

parsing the PluginManagement DSL.

Still needs to validate that the change will work as expected, but this

way I can get early feedback.

  1. … 33 more files in changeset.
Revert "Revert changes for custom plugin portal"

This reverts commit 2288791711e1f2e8edbc5af11c9348d48038f79e.

    • -3
    • +5
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 66 more files in changeset.
Revert changes for custom plugin portal

Revert 634e8884b8c8af88de7b45400d9448dcfb7687cf - add plugin resolution improvements to release notes

Revert 7164418390ebfa366eac77a8064d94ab386b7857 - Make pluginRepositories available in init scripts

reverts commit a1f3919be2d8b18e70c9777ba768b95272a08d1c.

reverts commit e996ec71a78dfd88d43f0e9bf589ca8b29c3160c.

reverts commit 02ae8d7131ed123238eb3a6dd200dfc8e8b360f7.

reverts commit 72f57e195af6e677316252f59965c17e889bb6bf.

reverts commit 9dcc63dad116b55cb860c89e3d749d58c787fbbe.

Revert e0b7a1c9febf72f8ca8a00a9e7f68089b3cda9ce - Tests and bug fixes for custom plugin portal

reverts commit e8805c1616912322e5441016e38329e11af3ca63.

reverts commit 20b815f768dea7f3bca48664233d13174d2e0f60.

Revert 0ae9da185d0df9b5831dce48eca21118d1fac5d7 - Move PluginId to interface

Revert 52c8306d872778404cbbd117bc2214da9f76e0c1 - Public interface changes for custom plugin portal

reverts commit 27ec8f7e535778f4fbb93df09937b027ac1ca488.

Revert 1b3f52920d8bf82be470d1aa972af21af5902f32 for custom plugin portal

Revert 71d6282cecba8ac5becad3f13f29f122212c0ff2 for custom plugin portal

reverts commit 500f9a90ea1775f4b5fe02fa9122750a10e90a5c.

Revert fa2963120a9d84bc156cb7418339ffccc2f88629 for custom plugin portal

Revert 7141b00cd487e265b08aaef364477870ccb38655 for custom plugin portal

    • -5
    • +3
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 67 more files in changeset.
Fix checkstyle errors

PR: 883

    • -2
    • +4
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Fix checkstyle errors

PR: 883

    • -2
    • +4
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Use `Serializer.equals` when comparing parameters for cache reuse (#1019)

* Add test cases for gradle/gradle#933. The focus is been put on `DefaultCacheAccess.newCache`.

* Fix gradle/gradle#933. By implementing `equals`/`hashCode` for `Serializer` and using then for cache equality.

  1. … 36 more files in changeset.
Fixing use pf PluginId when it should have been DefaultPluginId

    • -1
    • +1
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Fixing use pf PluginId when it should have been DefaultPluginId

    • -1
    • +1
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Moved PluginId to an interface & docs

PluginId was pulled into an interface so that we can control the

creation of those instances.

    • -0
    • +127
    ./DefaultPluginId.java
  1. … 10 more files in changeset.
Moved PluginId to an interface & docs

PluginId was pulled into an interface so that we can control the

creation of those instances.

  1. … 10 more files in changeset.
Add missing `@Override` annotations to `DefaultPluginRequest`

Removing code that should have be removed earlier

  1. … 2 more files in changeset.
Removing code that should have be removed earlier

  1. … 2 more files in changeset.
Encapsulate instantiation of DefaultPluginRequests

So `DefaultPluginRequests` doesn't have to be used by

gradle-script-kotlin.

See gradle/gradle-script-kotlin#186

    • -4
    • +2
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 2 more files in changeset.
Removing the interface and renaming impl

Removed PluginId interface and made DefaultPluginId be a class that we

share and part of the public API.

    • -2
    • +2
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 32 more files in changeset.
Removing the interface and renaming impl

Removed PluginId interface and made DefaultPluginId be a class that we

share and part of the public API.

    • -2
    • +2
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 32 more files in changeset.
Refactored names of classes, and finished up api

- Moved PluginRequest to InternalPluginRequest

- Created PluginRequest that InternalPluginRequest extends

- Made the code compile for RuleBasedPluginRepository

  1. … 42 more files in changeset.
Refactored names of classes, and finished up api

- Moved PluginRequest to InternalPluginRequest

- Created PluginRequest that InternalPluginRequest extends

- Made the code compile for RuleBasedPluginRepository

    • -0
    • +37
    ./InternalPluginRequest.java
  1. … 42 more files in changeset.
Working on the changes per Stefan's request.

Moving PluginId to be a public Interface, and then created an

implementation called DefaultPluginId

Added the first phase of interfaces (inside the class, will move out

later) so that I can start working on the API under the hood.

    • -2
    • +2
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 31 more files in changeset.
Working on the changes per Stefan's request.

Moving PluginId to be a public Interface, and then created an

implementation called DefaultPluginId

Added the first phase of interfaces (inside the class, will move out

later) so that I can start working on the API under the hood.

    • -2
    • +2
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 31 more files in changeset.
Update javadoc to link to the right class

Revert "Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release"

This reverts commit 506f8ce9d6dc1a81e8ff10575c512778ca2f382a.

    • -32
    • +34
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 195 more files in changeset.
Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release

    • -34
    • +32
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 195 more files in changeset.
Add `apply false` option to `plugins` block

This solves two use cases at once:

- only using some classes from a plugin without applying it

- applying a plugin to sub-projects without applying it to the root project

    • -32
    • +34
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 14 more files in changeset.
Revert plugins.subprojects syntax, as we are considering another solution

    • -0
    • +164
    ./PluginUseScriptBlockMetadataExtractor.java
    • -104
    • +0
    ./ProjectPluginRequestCollector.java
  1. … 29 more files in changeset.
Allow applying plugins to subprojects using new DSL

This change adds new `subprojects` and `allprojects` methods to the `plugins`

DSL, which allow users to apply plugins to multiple subprojects at once.

The plugins are resolved in the context of the parent project and put on

the parent's classpath. This ensures that the parent can cross-configure its

children. A side-effect is that unrelated subprojects will see those plugin

classes too, even though they are not applied to them.

The `plugins` block is no longer backed by an AST transformation, but is

now compiled, exactly like the `buildscript` and `pluginRepositories` blocks.

This will give users greater flexibility to conditionally apply plugins in the

future. Currently no access is granted to any methods outside of the `plugins`

API though.

    • -0
    • +37
    ./EmptyPluginRequestCollector.java
    • -164
    • +0
    ./PluginUseScriptBlockMetadataExtractor.java
    • -0
    • +104
    ./ProjectPluginRequestCollector.java
    • -0
    • +38
    ./TargetedPluginRequest.java
  1. … 30 more files in changeset.
Renamed src/main/groovy to src/main/java in core

    • -0
    • +106
    ./DefaultPluginRequest.java
    • -0
    • +44
    ./DefaultPluginRequests.java
    • -0
    • +33
    ./InjectedPluginClasspath.java
    • -0
    • +32
    ./InvalidPluginRequestException.java
    • -0
    • +34
    ./PluginRequest.java
    • -0
    • +26
    ./PluginRequestApplicator.java
    • -0
    • +101
    ./PluginRequestCollector.java
    • -0
    • +24
    ./PluginRequests.java
    • -0
    • +53
    ./PluginRequestsSerializer.java
    • -0
    • +164
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 2536 more files in changeset.