internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Limit PluginRequests instantiations & short-circuit when empty

  1. … 4 more files in changeset.
Remove types and support for org.gradle.plugin.use.PluginDependenciesSpec

  1. … 5 more files in changeset.
Remove now unused PluginRequestApplicator method

  1. … 1 more file in changeset.
Fix wrong method name in PluginRequestCollector

    • -2
    • +2
    ./PluginUseScriptBlockMetadataExtractor.java
Introduce org.plugin.dsl.*PluginDependencySpec type hierarchy

First step to rework the PluginDependencySpec type hierarchy.

New types are properly named. Old types are kept.

This step keeps the old type hierarchy working in order to keep the

Kotlin DSL working until it is updated to use the new type hierarchy.

    • -9
    • +9
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Javadocs

Split PluginRequest implementation

  1. … 15 more files in changeset.
Split PluginDependencySpec implementation

PluginRequest.script is-a URI

  1. … 6 more files in changeset.
Preserve compatibility with `kotlin-dsl`

    • -6
    • +6
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 12 more files in changeset.
Replace usages of org.gradle.api.Nullable

With javax.annotation.Nullable.

  1. … 460 more files in changeset.
Allow script plugins to be applied via the plugins DSL

Remote URLs are also supported:

```

plugins {

script "path/to/other.gradle"

script "https://example.com/another.gradle"

}

```

Local file paths are expressed as relative from the requesting script.

Constrain plugins {} block api to distinguish binary and script

plugin requests by both strongly modeled types and ad-hoc groovy parsing

of the plugins block. This pave the way for proper support of the

plugins {} block with the Gradle Kotlin DSL.

Implement ScriptPlugin PluginResolver by generating a synthetic

"imperative" Plugin class that loads and applies the script plugin when

applied.

This synthetic generated loader class and the script plugins are loaded

into the buildSrc classloader scope.

Only Project targets are supported.

`apply false` is not supported.

    • -8
    • +28
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 62 more files in changeset.
Remove guava from worker process path

  1. … 15 more files in changeset.
Rename to xxxInternal convention

  1. … 40 more files in changeset.
Polish pluginManagement DSL

    • -32
    • +0
    ./InvalidPluginRequestException.java
    • -0
    • +1
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 95 more files in changeset.
Fixing tests

  1. … 4 more files in changeset.
Renamed a class, and pulled some methods around on interfaces

Also made the test require that if() { pluginManagement { } } work. The

test doesn't pass, but I should fix that soon.

  1. … 6 more files in changeset.
Reverting changes descope some changes

    • -113
    • +0
    ./DefaultConfigurablePluginRequest.java
  1. … 11 more files in changeset.
Cleaning up some things

- Removing some interfaces / classes that are kruft

- Moving the PluginRequests to be immutable

- Removing some DSL magic

    • -20
    • +21
    ./DefaultConfigurablePluginRequest.java
    • -25
    • +0
    ./InternalConfigurablePluginRequest.java
  1. … 8 more files in changeset.
Adding javadoc, fixing issues with quickCheck

    • -0
    • +112
    ./DefaultConfigurablePluginRequest.java
    • -0
    • +25
    ./InternalConfigurablePluginRequest.java
  1. … 22 more files in changeset.
Adding test for pluginManagement {}

Needs to test the rules part, but the first bit is to make sure that

anything you do in pluginRepositories also works.

This has some changes about how data gets around. There's a service

that's been registered that's responsible to make things work (and is

shared). The API makes a new object that delegates to the service. This

allows us to make it early and have everyone use the same ones.

    • -0
    • +50
    ./ConfiguredOptions.java
  1. … 18 more files in changeset.
Moving to new pluginManagement dsl

Deleting classes that aren't used anymore. Writing some tests for

parsing the PluginManagement DSL.

Still needs to validate that the change will work as expected, but this

way I can get early feedback.

  1. … 33 more files in changeset.
Revert "Revert changes for custom plugin portal"

This reverts commit 2288791711e1f2e8edbc5af11c9348d48038f79e.

    • -3
    • +5
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 66 more files in changeset.
Revert changes for custom plugin portal

Revert 634e8884b8c8af88de7b45400d9448dcfb7687cf - add plugin resolution improvements to release notes

Revert 7164418390ebfa366eac77a8064d94ab386b7857 - Make pluginRepositories available in init scripts

reverts commit a1f3919be2d8b18e70c9777ba768b95272a08d1c.

reverts commit e996ec71a78dfd88d43f0e9bf589ca8b29c3160c.

reverts commit 02ae8d7131ed123238eb3a6dd200dfc8e8b360f7.

reverts commit 72f57e195af6e677316252f59965c17e889bb6bf.

reverts commit 9dcc63dad116b55cb860c89e3d749d58c787fbbe.

Revert e0b7a1c9febf72f8ca8a00a9e7f68089b3cda9ce - Tests and bug fixes for custom plugin portal

reverts commit e8805c1616912322e5441016e38329e11af3ca63.

reverts commit 20b815f768dea7f3bca48664233d13174d2e0f60.

Revert 0ae9da185d0df9b5831dce48eca21118d1fac5d7 - Move PluginId to interface

Revert 52c8306d872778404cbbd117bc2214da9f76e0c1 - Public interface changes for custom plugin portal

reverts commit 27ec8f7e535778f4fbb93df09937b027ac1ca488.

Revert 1b3f52920d8bf82be470d1aa972af21af5902f32 for custom plugin portal

Revert 71d6282cecba8ac5becad3f13f29f122212c0ff2 for custom plugin portal

reverts commit 500f9a90ea1775f4b5fe02fa9122750a10e90a5c.

Revert fa2963120a9d84bc156cb7418339ffccc2f88629 for custom plugin portal

Revert 7141b00cd487e265b08aaef364477870ccb38655 for custom plugin portal

    • -5
    • +3
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 67 more files in changeset.
Fix checkstyle errors

PR: 883

    • -2
    • +4
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Fix checkstyle errors

PR: 883

    • -2
    • +4
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Use `Serializer.equals` when comparing parameters for cache reuse (#1019)

* Add test cases for gradle/gradle#933. The focus is been put on `DefaultCacheAccess.newCache`.

* Fix gradle/gradle#933. By implementing `equals`/`hashCode` for `Serializer` and using then for cache equality.

  1. … 36 more files in changeset.
Fixing use pf PluginId when it should have been DefaultPluginId

    • -1
    • +1
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Fixing use pf PluginId when it should have been DefaultPluginId

    • -1
    • +1
    ./PluginUseScriptBlockMetadataExtractor.java
  1. … 5 more files in changeset.
Moved PluginId to an interface & docs

PluginId was pulled into an interface so that we can control the

creation of those instances.

    • -0
    • +127
    ./DefaultPluginId.java
  1. … 10 more files in changeset.