internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix for previous commit.

    • -8
    • +11
    ./DefaultScriptCompilationHandler.java
Fix for previous commit.

    • -8
    • +11
    ./DefaultScriptCompilationHandler.java
Fix for previous commit.

    • -1
    • +1
    ./DefaultScriptCompilationHandler.java
Fix for previous commit.

    • -1
    • +1
    ./DefaultScriptCompilationHandler.java
Fix for previous commit.

    • -2
    • +1
    ./DefaultScriptCompilationHandler.java
Fix for previous commit.

    • -2
    • +1
    ./DefaultScriptCompilationHandler.java
Fix `ClassNotFoundExeception` when loading objects whose class is defined in a build script from the instant execution cache, after recreating the cache from a daemon process that has previously successfully used the cache.

For example, running `gradle taskA`, `gradle taskA`, `gradle taskB`, `gradle taskB` would fail if `taskB` uses types from a build script.

This was happening because the script ClassLoaders are cached and reused, but the association between ClassLoader and scope was lost, and this association is what instant execution uses to know how to load the class.

This change fixes one case of this problem, but the same problem can still happen if the set of build scripts being referenced changes.

    • -0
    • +1
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -12
    • +27
    ./DefaultScriptCompilationHandler.java
    • -0
    • +5
    ./FileCacheBackedScriptClassCompiler.java
  1. … 22 more files in changeset.
Fix `ClassNotFoundExeception` when loading objects whose class is defined in a build script from the instant execution cache, after recreating the cache from a daemon process that has previously successfully used the cache.

For example, running `gradle taskA`, `gradle taskA`, `gradle taskB`, `gradle taskB` would fail if `taskB` uses types from a build script.

This was happening because the script ClassLoaders are cached and reused, but the association between ClassLoader and scope was lost, and this association is what instant execution uses to know how to load the class.

This change fixes one case of this problem, but the same problem can still happen if the set of build scripts being referenced changes.

    • -0
    • +1
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -5
    • +18
    ./DefaultScriptCompilationHandler.java
    • -0
    • +5
    ./FileCacheBackedScriptClassCompiler.java
  1. … 18 more files in changeset.
Fix `ClassNotFoundExeception` when loading objects whose class is defined in a build script from the instant execution cache, after recreating the cache from a daemon process that has previously successfully used the cache.

For example, running `gradle taskA`, `gradle taskA`, `gradle taskB`, `gradle taskB` would fail if `taskB` uses types from a build script.

This was happening because the script ClassLoaders are cached and reused, but the association between ClassLoader and scope was lost, and this association is what instant execution uses to know how to load the class.

This change fixes one case of this problem, but the same problem can still happen if the set of build scripts being referenced changes.

    • -0
    • +1
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -12
    • +27
    ./DefaultScriptCompilationHandler.java
    • -0
    • +5
    ./FileCacheBackedScriptClassCompiler.java
  1. … 22 more files in changeset.
Fix `ClassNotFoundExeception` when loading objects whose class is defined in a build script from the instant execution cache, after recreating the cache from a daemon process that has previously successfully used the cache.

For example, running `gradle taskA`, `gradle taskA`, `gradle taskB`, `gradle taskB` would fail if `taskB` uses types from a build script.

This was happening because the script ClassLoaders are cached and reused, but the association between ClassLoader and scope was lost, and this association is what instant execution uses to know how to load the class.

This change fixes one case of this problem, but the same problem can still happen if the set of build scripts being referenced changes.

    • -0
    • +1
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -5
    • +18
    ./DefaultScriptCompilationHandler.java
    • -0
    • +5
    ./FileCacheBackedScriptClassCompiler.java
  1. … 18 more files in changeset.
Remove duplicate vendor from javaVmVersion String

    • -1
    • +1
    ./RegistryAwareClassLoaderHierarchyHasher.java
Do not follow symlinks when removing work outputs

    • -3
    • +3
    ./DefaultScriptCompilationHandler.java
  1. … 18 more files in changeset.
Do not follow symlinks when removing work outputs

    • -3
    • +3
    ./DefaultScriptCompilationHandler.java
  1. … 17 more files in changeset.
Do not follow symlinks when removing work outputs

    • -3
    • +3
    ./DefaultScriptCompilationHandler.java
  1. … 17 more files in changeset.
Record the ClassLoader associated with each class that is serialized to the instant execution cache, and use this to make class lookup on deserialize faster and to deal correctly with multiple classes with the same name.

Move some ClassLoader lifecycling from Groovy DSL script compilation to `ClassLoaderScope`, so that the scope takes care of creating and caching the script ClassLoader.

    • -3
    • +2
    ./BuildOperationBackedScriptCompilationHandler.java
    • -3
    • +2
    ./BuildScopeInMemoryCachingScriptClassCompiler.java
    • -3
    • +1
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -21
    • +8
    ./DefaultScriptCompilationHandler.java
    • -6
    • +3
    ./FileCacheBackedScriptClassCompiler.java
  1. … 24 more files in changeset.
Record the ClassLoader associated with each class that is serialized to the instant execution cache, and use this to make class lookup on deserialize faster and to deal correctly with multiple classes with the same name.

Move some ClassLoader lifecycling from Groovy DSL script compilation to `ClassLoaderScope`, so that the scope takes care of creating and caching the script ClassLoader.

    • -3
    • +2
    ./BuildOperationBackedScriptCompilationHandler.java
    • -3
    • +2
    ./BuildScopeInMemoryCachingScriptClassCompiler.java
    • -3
    • +1
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -21
    • +8
    ./DefaultScriptCompilationHandler.java
    • -6
    • +3
    ./FileCacheBackedScriptClassCompiler.java
  1. … 17 more files in changeset.
Record the ClassLoader associated with each class that is serialized to the instant execution cache, and use this to make class lookup on deserialize faster and to deal correctly with multiple classes with the same name.

Move some ClassLoader lifecycling from Groovy DSL script compilation to `ClassLoaderScope`, so that the scope takes care of creating and caching the script ClassLoader.

    • -3
    • +2
    ./BuildOperationBackedScriptCompilationHandler.java
    • -3
    • +2
    ./BuildScopeInMemoryCachingScriptClassCompiler.java
    • -3
    • +1
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -21
    • +8
    ./DefaultScriptCompilationHandler.java
    • -6
    • +3
    ./FileCacheBackedScriptClassCompiler.java
  1. … 17 more files in changeset.
Record the ClassLoader associated with each class that is serialized to the instant execution cache, and use this to make class lookup on deserialize faster and to deal correctly with multiple classes with the same name.

Move some ClassLoader lifecycling from Groovy DSL script compilation to `ClassLoaderScope`, so that the scope takes care of creating and caching the script ClassLoader.

    • -3
    • +2
    ./BuildOperationBackedScriptCompilationHandler.java
    • -3
    • +2
    ./BuildScopeInMemoryCachingScriptClassCompiler.java
    • -3
    • +1
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -21
    • +8
    ./DefaultScriptCompilationHandler.java
    • -6
    • +3
    ./FileCacheBackedScriptClassCompiler.java
  1. … 24 more files in changeset.
Support plugins {} in settings scripts

    • -1
    • +1
    ./InitialPassStatementTransformer.java
  1. … 10 more files in changeset.
Support plugins {} in settings scripts

    • -1
    • +1
    ./InitialPassStatementTransformer.java
  1. … 9 more files in changeset.
Support plugins {} in settings scripts

    • -1
    • +1
    ./InitialPassStatementTransformer.java
  1. … 9 more files in changeset.
Move Deleter interface out of impl package

    • -1
    • +1
    ./DefaultScriptCompilationHandler.java
  1. … 41 more files in changeset.
Move Deleter interface out of impl package

    • -1
    • +1
    ./DefaultScriptCompilationHandler.java
  1. … 38 more files in changeset.
Use Deleter when removing the output for Groovy script compilation

    • -7
    • +19
    ./DefaultScriptCompilationHandler.java
  1. … 3 more files in changeset.
Use Deleter when removing the output for Groovy script compilation

    • -7
    • +19
    ./DefaultScriptCompilationHandler.java
  1. … 3 more files in changeset.
Revert "Reinstate "Let instant execution reuse classloaders when loading""

    • -3
    • +2
    ./BuildOperationBackedScriptCompilationHandler.java
    • -4
    • +3
    ./BuildScopeInMemoryCachingScriptClassCompiler.java
    • -5
    • +3
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -14
    • +7
    ./DefaultScriptCompilationHandler.java
    • -4
    • +2
    ./FileCacheBackedScriptClassCompiler.java
  1. … 30 more files in changeset.
Revert "Revert "Let instant execution reuse classloaders when loading""

    • -2
    • +3
    ./BuildOperationBackedScriptCompilationHandler.java
    • -3
    • +4
    ./BuildScopeInMemoryCachingScriptClassCompiler.java
    • -3
    • +5
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -7
    • +14
    ./DefaultScriptCompilationHandler.java
    • -2
    • +4
    ./FileCacheBackedScriptClassCompiler.java
  1. … 30 more files in changeset.
Revert "Let instant execution reuse classloaders when loading"

    • -3
    • +2
    ./BuildOperationBackedScriptCompilationHandler.java
    • -4
    • +3
    ./BuildScopeInMemoryCachingScriptClassCompiler.java
    • -5
    • +3
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -14
    • +7
    ./DefaultScriptCompilationHandler.java
    • -4
    • +2
    ./FileCacheBackedScriptClassCompiler.java
  1. … 30 more files in changeset.
Re-allows multiple `plugins` blocks in the Groovy DSL

    • -2
    • +0
    ./InitialPassStatementTransformer.java
  1. … 1 more file in changeset.
Simplify ScriptCompiler.compile() contract

Not requiring the ClassLoader anymore but only the ClassLoaderScope

as all implementations now use the export loader from the given scope.

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./BuildOperationBackedScriptCompilationHandler.java
    • -3
    • +3
    ./BuildScopeInMemoryCachingScriptClassCompiler.java
    • -3
    • +2
    ./CrossBuildInMemoryCachingScriptClassCache.java
    • -6
    • +4
    ./DefaultScriptCompilationHandler.java
    • -2
    • +2
    ./FileCacheBackedScriptClassCompiler.java
  1. … 8 more files in changeset.