controller

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename FileSystemAccess.{update -> write}

    • -4
    • +4
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 15 more files in changeset.
Rename FileSystemAccess.{update -> write}

    • -4
    • +4
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 15 more files in changeset.
Rename FileSystemAccess.{update -> write}

    • -4
    • +4
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 15 more files in changeset.
Rename FileSystemAccess.{update -> write}

    • -4
    • +4
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 15 more files in changeset.
Rename VirtualFileSystem -> FileSystemAccess

    • -8
    • +8
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 53 more files in changeset.
Rename VirtualFileSystem -> FileSystemAccess

    • -8
    • +8
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 53 more files in changeset.
Rename VirtualFileSystem -> FileSystemAccess

    • -8
    • +8
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 53 more files in changeset.
Rename VirtualFileSystem -> FileSystemAccess

    • -8
    • +8
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 53 more files in changeset.
Rename FileMetadata{Snapshot -> }

Snapshot doesn't add anything to the name.

    • -1
    • +1
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 50 more files in changeset.
Introduce access type on FileSystemLocationSnapshot

but don't fill it, yet.

    • -1
    • +2
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 23 more files in changeset.
Introduce access type on FileSystemLocationSnapshot

but don't fill it, yet.

    • -1
    • +2
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 23 more files in changeset.
Introduce access type on FileSystemLocationSnapshot

but don't fill it, yet.

    • -1
    • +2
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 23 more files in changeset.
Move BuildCacheCommandFactory to :build-cache

And its implementation to :core (though it should end up in some build-cache-related subproject eventually).

    • -0
    • +179
    ./impl/DefaultBuildCacheCommandFactory.java
  1. … 16 more files in changeset.
Move BuildCacheControllerFactory to build-cache project

+review REVIEW-6562

    • -323
    • +0
    ./BuildCacheControllerFactory.java
  1. … 4 more files in changeset.
Move 'org.gradle.caching' to build-cache

+review REVIEW-6562

    • -292
    • +0
    ./DefaultBuildCacheController.java
    • -34
    • +0
    ./operations/LoadOperationDetails.java
    • -39
    • +0
    ./operations/LoadOperationHitResult.java
    • -38
    • +0
    ./operations/LoadOperationMissResult.java
    • -35
    • +0
    ./operations/PackOperationDetails.java
    • -40
    • +0
    ./operations/PackOperationResult.java
    • -41
    • +0
    ./operations/StoreOperationDetails.java
    • -36
    • +0
    ./operations/StoreOperationResult.java
    • -41
    • +0
    ./operations/UnpackOperationDetails.java
    • -33
    • +0
    ./operations/UnpackOperationResult.java
    • -126
    • +0
    ./service/BaseBuildCacheServiceHandle.java
  1. … 136 more files in changeset.
Move PathKeyFileStore to `:resources`

+review REVIEW-6562

  1. … 16 more files in changeset.
Add task path to task output build cache key (#2668)

    • -3
    • +3
    ./service/BaseBuildCacheServiceHandle.java
  1. … 18 more files in changeset.
Use TAR implementation from commons-compress (#2696)

It implements the same algorithm as Ant's TAR, but allocates less memory, especially when unpacking. Buffering is only needed when packaging.

  1. … 10 more files in changeset.
Build cache: faster copy operations (#2665)

- Prevent unnecessary re-allocation of file buffers

- Use buffered streams when packing/unpacking cached results

  1. … 2 more files in changeset.
Fix exception

Improve progress feedback for remote build cache operations.

    • -2
    • +7
    ./service/BaseBuildCacheServiceHandle.java
    • -3
    • +54
    ./service/OpFiringBuildCacheServiceHandle.java
Polish TAR archiving of task outputs

  1. … 8 more files in changeset.
Polish progress display name for build cache operations

We now use `Loading from build cache` and `Storing in build cache`.

    • -2
    • +2
    ./service/OpFiringBuildCacheServiceHandle.java
Use sentence case for progress logging of build cache ops

PR #2498

    • -2
    • +2
    ./service/OpFiringBuildCacheServiceHandle.java
Add progress message for build cache operations

    • -2
    • +4
    ./service/OpFiringBuildCacheServiceHandle.java
Set content length when uploading HTTP build cache entry

  1. … 5 more files in changeset.
Improve error feedback for build cache errors (#2473)

We shouldn't fail the build when we can't package a task's outputs. We should also not fail the build when unpacking some already downloaded outputs.

If there was a failure during unpacking, we can expect the task's output files to be in a messed up state. If this happens, we explicitly clean all of the task's outputs, update the pre-execution output file snapshots, and force the task to execute in non-incremental mode.

This commit also removes the retry logic we had previously when "recoverable" errors were encountered while downloading or uploading cached results. Instead, all errors (except for the aforementioned failed unpacking cleanup errors) are recoverable, and we simply switch off the cache for the build after the first such error.

    • -11
    • +6
    ./service/BaseBuildCacheServiceHandle.java
    • -1
    • +1
    ./service/DefaultLocalBuildCacheServiceHandle.java
    • -1
    • +1
    ./service/LocalBuildCacheServiceHandle.java
    • -1
    • +1
    ./service/NullLocalBuildCacheServiceHandle.java
  1. … 22 more files in changeset.
Copy remote cache artifacts into local cache 2

Fixes some issues and improves test coverage

  1. … 9 more files in changeset.
Store artifacts from the remote cache in the local cache

When the default local directory build cache is used, we use an optimized

way to store the downloaded artifact in the cache. Using a custom local

cache, or with the local cache disabled, a temporary file will be used

to store the downloaded artifact.

Packing is also separated from uploading to the remote cache. Again,

when the default directory cache is used to store the cached artifact in

the local cache before uploading it to the remote cache. With a custom

local cache, or when a local cache is not enabled, task outputs will be

stored in a temporary file before uploading.

Build operations are emitted separately for packing, unpacking,

uploading and downloading the cache artifact.

    • -11
    • +13
    ./BuildCacheControllerFactory.java
    • -34
    • +0
    ./BuildCacheServicesConfiguration.java
    • -52
    • +194
    ./DefaultBuildCacheController.java
    • -257
    • +0
    ./DefaultBuildCacheServiceHandle.java
    • -45
    • +0
    ./FileCopyBuildCacheEntryWriter.java
    • -48
    • +0
    ./operations/DisableOperationDetails.java
    • -27
    • +0
    ./operations/DisableOperationResult.java
    • -15
    • +7
    ./operations/LoadOperationDetails.java
    • -10
    • +3
    ./operations/LoadOperationHitResult.java
  1. … 42 more files in changeset.
Replace usages of org.gradle.api.Nullable

With javax.annotation.Nullable.

    • -1
    • +1
    ./service/BuildCacheServiceHandle.java
    • -1
    • +2
    ./service/NullBuildCacheServiceHandle.java
  1. … 456 more files in changeset.