Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate specifying the type of the local cache

  1. … 10 more files in changeset.
Deprecate specifying the type of the local cache

  1. … 10 more files in changeset.
Remove legacy local cache option

    • -18
    • +9
    ./DefaultBuildCacheConfiguration.java
  1. … 9 more files in changeset.
Move org.gradle.caching.configuration.internal to :core

    • -0
    • +28
    ./BuildCacheConfigurationInternal.java
    • -0
    • +25
    ./BuildCacheServiceRegistration.java
    • -0
    • +160
    ./DefaultBuildCacheConfiguration.java
    • -0
    • +64
    ./DefaultBuildCacheServiceRegistration.java
  1. … 13 more files in changeset.
Move org.gradle.caching.configuration.internal to :core

    • -0
    • +28
    ./BuildCacheConfigurationInternal.java
    • -0
    • +25
    ./BuildCacheServiceRegistration.java
    • -0
    • +160
    ./DefaultBuildCacheConfiguration.java
    • -0
    • +64
    ./DefaultBuildCacheServiceRegistration.java
  1. … 13 more files in changeset.
Move 'org.gradle.caching' to build-cache

+review REVIEW-6562

    • -28
    • +0
    ./BuildCacheConfigurationInternal.java
    • -25
    • +0
    ./BuildCacheServiceRegistration.java
    • -156
    • +0
    ./DefaultBuildCacheConfiguration.java
    • -64
    • +0
    ./DefaultBuildCacheServiceRegistration.java
  1. … 147 more files in changeset.
Reduce logging level for registering a build cache factory

This isn't very useful most of the time and produces lots of

redundant messages with composite builds

Fail when configuring unregistered build cache

    • -10
    • +16
    ./DefaultBuildCacheConfiguration.java
  1. … 3 more files in changeset.
Remove deprecated task caching system properties

+review REVIEW-6503

    • -3
    • +3
    ./BuildCacheConfigurationInternal.java
    • -35
    • +1
    ./DefaultBuildCacheConfiguration.java
  1. … 12 more files in changeset.
Allow any build cache as the local one

    • -12
    • +41
    ./DefaultBuildCacheConfiguration.java
  1. … 9 more files in changeset.
Rename LocalBuildCache to DirectoryBuildCache

+review REVIEW-6464

  1. … 16 more files in changeset.
Add deprecation warnings for build cache system properties

+review REVIEW-6463

  1. … 3 more files in changeset.
Allow reconfiguring remote build cache

+review REVIEW-6456

  1. … 1 more file in changeset.
Simplify DispatchingBuildCache

It does not pretend to be a regular build cache service any more - i

.e there is no ServiceFactory nor a BuildCache configuration for it.

BuildCacheServiceProvider is now responsible to create the

BuildCacheService for the build.

+review REVIEW-6450

    • -2
    • +0
    ./BuildCacheConfigurationInternal.java
    • -12
    • +0
    ./DefaultBuildCacheConfiguration.java
  1. … 11 more files in changeset.
Fix generics for registering build cache services

+review REVIEW-6452

  1. … 1 more file in changeset.
Introduce --build-cache command-line options

- Introduce --build-cache and --no-build-cache to enable build caches

- Replace isTaskOutputCacheEnabled with isBuildCacheEnabled

- Methods remain, but are deprecated

- Introduce org.gradle.buildcache to replace org.gradle.cache.tasks

- Update production code and tests to use new names

- Consolidate references to org.gradle.cache.tasks.push and pull

+review REVIEW-6451

  1. … 20 more files in changeset.
Simplify CompositeBuildCache and CompositeBuildCacheService to use local/remote

Instead of a List of build caches and a particular one selected for "push", we just

use a flag to push to local or remote.

+review REVIEW-6450

    • -0
    • +1
    ./BuildCacheConfigurationInternal.java
    • -23
    • +20
    ./DefaultBuildCacheConfiguration.java
  1. … 6 more files in changeset.
Disable push on AbstractBuildCache by default

+review REVIEW-6450

  1. … 7 more files in changeset.
Refactor composite build cache

Now creation is similar to the other build caches. The logic about

globally configured push/pull went into DefaultBuildCacheConfiguration.

+review REVIEW-6450

    • -0
    • +3
    ./BuildCacheConfigurationInternal.java
    • -3
    • +53
    ./DefaultBuildCacheConfiguration.java
  1. … 11 more files in changeset.
Address review comments

- Simplify the use of generics by ditching them

- Use a single BuildCacheServiceRegistration to encapsulate the BuildCache and BuildCacheServiceFactory pairing

- Rename LocalDirectoryBuildCacheService to be consistent with the other types

- Inline the registration of the HttpBuildCache

- Add documentation about registering a custom build cache

+review REVIEW-6448

    • -15
    • +11
    ./DefaultBuildCacheConfiguration.java
    • -0
    • +64
    ./DefaultBuildCacheServiceRegistration.java
  1. … 10 more files in changeset.
Use BuildCacheServiceFactory to instantiate BuildCacheService

This restores the BuildCacheServiceFactory and allows authors of build cache

implementations to create their instance as they need to.

This keeps some of the features of the previous change (direct creation of

BuildCacheService) by changing the register() to similar (requiring types

vs instances).

+review REVIEW-6448

    • -3
    • +3
    ./BuildCacheConfigurationInternal.java
    • -13
    • +13
    ./DefaultBuildCacheConfiguration.java
  1. … 13 more files in changeset.
Initial implementation of composite build cache

We add a composite build cache which can be used to pull

from multiple caches and push to one cache. Currently, it

will be used to pull from local and remote caches and

push to one of the two.

+review REVIEW-6450

  1. … 9 more files in changeset.
Remove BuildCacheServiceFactory and inject into the BuildCacheService

Instead of allowing a user to specify a user-created BuildCacheServiceFactory and then

allowing them to create their own BuildCacheService implementation, add a register method

to BuildCacheConfiguration that takes the configuration type and build cache service

implementation type.

We control the creation of all the necessary pieces and injection of dependencies.

The main side effect of this is that the build cache implementation's constructor must be

done in a particular way and annotated with @Inject.

+review REVIEW-6448

    • -2
    • +3
    ./BuildCacheConfigurationInternal.java
    • -0
    • +25
    ./BuildCacheServiceRegistration.java
    • -24
    • +22
    ./DefaultBuildCacheConfiguration.java
  1. … 15 more files in changeset.
Last remote build cache configuration wins

+review REVIEW-6445

  1. … 3 more files in changeset.
Change generic signature for remote(Class, Action) to be IDE friendly

+review REVIEW-6445

  1. … 1 more file in changeset.
Honor generics

+review REVIEW-6445

    • -1
    • +1
    ./BuildCacheConfigurationInternal.java
  1. … 2 more files in changeset.
Add test coverage for error cases

+review REVIEW-6445

    • -5
    • +12
    ./DefaultBuildCacheConfiguration.java
  1. … 2 more files in changeset.
Add some TODOs for error handling in the build cache DSL

Move around some responsibilities for finding a BuildCacheServiceFactory

DefaultBuildCacheServiceProvider was doing a lot

+review REVIEW-6445

    • -4
    • +2
    ./BuildCacheConfigurationInternal.java
    • -3
    • +21
    ./DefaultBuildCacheConfiguration.java
  1. … 3 more files in changeset.
Move around some new caching classes

This is backwards compatible because these are all new classes or internal.

+review REVIEW-6445

    • -1
    • +1
    ./BuildCacheConfigurationInternal.java
    • -145
    • +0
    ./DefaultBuildCacheServiceProvider.java
    • -47
    • +0
    ./DefaultLocalBuildCacheServiceFactory.java
  1. … 12 more files in changeset.