Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Setters for legacy properties backed by Property clear conventions

The version property of a archive task by convention is set to

project.version.

In previous releases, archiveTask.version = null would clear the

value of version and we would strip this from the archive file name.

In Gradle 5.6, setting a Property's value to null reverts back to

the convention's value.

To mimic the old behavior, using the legacy setter now overwrites

both the value and the convention. So when setting the property

explicitly to null, the underlying Property now has a null value.

    • -13
    • +19
    ./tasks/bundling/AbstractArchiveTask.java
  1. … 1 more file in changeset.
Rename method to not be a getter, to avoid being accidentally invoked

  1. … 3 more files in changeset.
Attach the buildSrc export scope to settings

This is the minimal change required to make Kotlin DSL IDE integration

work. When getting a script's classpath fails, we fall back to this

classpath.

  1. … 8 more files in changeset.
Introduce a factory service to create instances of `TaskDependency`, to allow the implementations to be contextualized and to use types that aren't part of the (internal) core API.

Use this factory in `DefaultConfigurableFileCollection`.

    • -6
    • +10
    ./internal/file/CachingTaskInputFileCollection.java
    • -1
    • +8
    ./internal/file/DefaultFileLookup.java
    • -5
    • +5
    ./internal/file/DefaultProjectLayout.java
  1. … 22 more files in changeset.
Introduce a factory service to create instances of `TaskDependency`, to allow the implementations to be contextualized and to use types that aren't part of the (internal) core API.

Use this factory in `DefaultConfigurableFileCollection`.

    • -6
    • +10
    ./internal/file/CachingTaskInputFileCollection.java
    • -1
    • +8
    ./internal/file/DefaultFileLookup.java
    • -5
    • +5
    ./internal/file/DefaultProjectLayout.java
  1. … 22 more files in changeset.
Introduce a factory service to create instances of `TaskDependency`, to allow the implementations to be contextualized and to use types that aren't part of the (internal) core API.

Use this factory in `DefaultConfigurableFileCollection`.

    • -6
    • +10
    ./internal/file/CachingTaskInputFileCollection.java
    • -1
    • +8
    ./internal/file/DefaultFileLookup.java
    • -5
    • +5
    ./internal/file/DefaultProjectLayout.java
  1. … 22 more files in changeset.
Replace some direct instantiation of `FileResolver` instances with a service.

    • -202
    • +0
    ./internal/file/DefaultFileCollectionFactory.java
  1. … 23 more files in changeset.
Replace some direct instantiation of `FileResolver` instances with a service.

    • -202
    • +0
    ./internal/file/DefaultFileCollectionFactory.java
  1. … 23 more files in changeset.
Replace some direct instantiation of `FileResolver` instances with a service.

    • -202
    • +0
    ./internal/file/DefaultFileCollectionFactory.java
  1. … 23 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

    • -1
    • +1
    ./internal/file/DefaultProjectLayout.java
  1. … 12 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

    • -1
    • +1
    ./internal/file/DefaultProjectLayout.java
  1. … 12 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

    • -1
    • +1
    ./internal/file/DefaultProjectLayout.java
  1. … 12 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

    • -1
    • +1
    ./internal/file/DefaultProjectLayout.java
  1. … 12 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

    • -1
    • +1
    ./internal/file/DefaultProjectLayout.java
  1. … 12 more files in changeset.
Build buildSrc after applying the settings file

This allows the build cache settings to implicitly apply to buildSrc,

whereas before the configuration had to be duplicated there.

  1. … 26 more files in changeset.
Handle task replacement in bridged collections

    • -0
    • +1
    ./internal/tasks/DefaultTaskContainerFactory.java
  1. … 2 more files in changeset.
Make TaskContainer.whenObjectRemoved() an error

    • -5
    • +2
    ./internal/tasks/DefaultTaskContainer.java
    • -2
    • +1
    ./internal/tasks/DefaultTaskContainerFactory.java
  1. … 1 more file in changeset.
Make deprecations in TaskContainer throw errors

    • -28
    • +16
    ./internal/tasks/DefaultTaskContainer.java
  1. … 14 more files in changeset.
Make deprecations in TaskContainer throw errors

    • -28
    • +16
    ./internal/tasks/DefaultTaskContainer.java
  1. … 14 more files in changeset.
Fix NativeBasePluginTest to not use outdated API

    • -1
    • +0
    ./internal/file/DefaultSourceDirectorySet.java
  1. … 1 more file in changeset.
Turn invalid usages of ObjectFactory.property() into errors

    • -6
    • +10
    ./internal/model/DefaultObjectFactory.java
  1. … 1 more file in changeset.
Remove nagging from DefaultSourceDirectorySet

    • -3
    • +0
    ./internal/file/DefaultSourceDirectorySet.java
    • -9
    • +1
    ./internal/model/DefaultObjectFactory.java
Remove old and unused feature preview flags

This removes the preview flags completely that have already bean

deactivated for several Gradle versions and caused a deprecation

warning that they are being removed in Gradle 6.0.

  1. … 1 more file in changeset.
Remove old and unused feature preview flags

This removes the preview flags completely that have already bean

deactivated for several Gradle versions and caused a deprecation

warning that they are being removed in Gradle 6.0.

  1. … 1 more file in changeset.
Use Deleter in cleaning stale outputs, take 2

This covers the remaining use cases:

- stale class cleanup for compilers

- stale overlapping output cleanup

  1. … 30 more files in changeset.
First shot at having two TaskActions

    • -0
    • +74
    ./internal/project/taskfactory/BridgingIncrementalTaskInputsTaskAction.java
  1. … 3 more files in changeset.
Move Deleter interface out of impl package

    • -1
    • +1
    ./internal/file/DefaultFileOperations.java
  1. … 36 more files in changeset.
Move Deleter interface out of impl package

    • -1
    • +1
    ./internal/file/DefaultFileOperations.java
  1. … 33 more files in changeset.
Change `ProjectBuilder` to mark the thread that creates the project as the owner of the project. This allows the test thread to do things such as dependency resolution.

Also change `ProjectState` to expose the `ResourceLock` associated with the project, so that consumers don't need to look this up somewhere else and make assumptions about where the lock comes from.

    • -1
    • +7
    ./internal/project/DefaultProjectStateRegistry.java
    • -0
    • +10
    ./internal/project/ProjectState.java
  1. … 9 more files in changeset.
Change `ProjectBuilder` to mark the thread that creates the project as the owner of the project. This allows the test thread to do things such as dependency resolution.

Also change `ProjectState` to expose the `ResourceLock` associated with the project, so that consumers don't need to look this up somewhere else and make assumptions about where the lock comes from.

    • -1
    • +7
    ./internal/project/DefaultProjectStateRegistry.java
    • -0
    • +10
    ./internal/project/ProjectState.java
  1. … 10 more files in changeset.