Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Renamed src/main/groovy to src/main/java in core

  1. … 2545 more files in changeset.
Simplify ModelRegistrations

Make the purpose of actions added during registration a bit cleaner,

too.

+review REVIEW-5738

  1. … 7 more files in changeset.
Merge branch 'release'

  1. … 7 more files in changeset.
Removed unused method.

Remove model reuse and node replacement logic

  1. … 28 more files in changeset.
Reuse `DslObject` to calculate bridged object's public type, and removed some util classes.

  1. … 2 more files in changeset.
Use a custom node initializer strategy for empty subtypes of `ModelMap`

This change allows us to define subtypes of `ModelMap` and create instances

using a standard `@Model` rule. Previously it was necessary to register each

instance using some `ModelRegistry` magic via the `ModelMapRegistrations`

helper.

This change has simplified the registration of the top-level:

- `ComponentSpecContainer`

- `BinaryContainer`

- `TestSuiteContainer`

Further work will be done to use this for `FunctionalSourceSet`,

which will allow us to remove a bunch of alternative code used for model

registration.

    • -49
    • +0
    ./PolymorphicModelMapProjection.java
  1. … 12 more files in changeset.
Rename ModelRegistry.create() to register() +review REVIEW-5678

  1. … 67 more files in changeset.
Register node initializers via rules

+review REVIEW-5629

  1. … 51 more files in changeset.
Code cleanup

+review REVIEW-5629

Better way to extract schema from object instances

The point here is that we want to unwrap `DynamicObjectAware` and

`ManagedInstace` types as well.

+review REVIEW-5596

  1. … 9 more files in changeset.
Unwrap original managed type from managed instance

+review REVIEW-5596

  1. … 9 more files in changeset.
Use NodeInitializer to back ChildNodeCreatorStrategy (and rename).

+review REVIEW-5561

  1. … 11 more files in changeset.
Prevents decorated subtypes from being used as model node types.

+review REVIEW-5526

  1. … 3 more files in changeset.
Fixes for model reuse.

- Don't close over the container in the creator for bridged collection elements

- Don't close over tool chain and other non reusable dependencies in the native component model

+review

  1. … 34 more files in changeset.
Support ModelMap as a managed type.

+review

  1. … 39 more files in changeset.
Expose ComponentSpec.source() as a node backed model map, instead of a domain object collection wrapped model map.

+review REVIEW-5498

  1. … 39 more files in changeset.
Some simplification, by reusing ModelCreators.unmanaged() instead of().

Tweaks to type signature

  1. … 2 more files in changeset.
Fixed @ComponentType so that it can be used to declare TestSuiteSpec subtypes, and use this in the CUnit and Google test plugins.

Extracted out a shared ComponentSpec type registry that is shared by all ComponentSpec containers.

  1. … 11 more files in changeset.
Simplify collection bridging, and ModelMap implementations in general.

- Ancillary nodes are no longer needed to back model maps

- Remove custom projections for bridged vs backed model map views

Some supporting ModelMap infrastructure has moved from platform-base to core. We've now broken all the linkage between ModelMap et al. and the containers, but still link against the instantiator types. With a little more work we could move the instantiator base types to, say, base-services, and move all ModelMap infrastructure out to model-core.

    • -54
    • +0
    ./DomainObjectContainerModelProjection.java
    • -45
    • +0
    ./DynamicTypesDomainObjectContainerModelProjection.java
    • -3
    • +10
    ./PolymorphicModelMapProjection.java
    • -65
    • +0
    ./StaticTypeDomainObjectContainerModelProjection.java
  1. … 44 more files in changeset.
Simply use ModelPath instead of a ModelReference with a type that is ignored in model creator builder.

+review REVIEW-5496

  1. … 4 more files in changeset.
Changed ModelCreators.of() to accept a ModelPath instead of ModelReference, as only the path from the reference was used. The 'type' is determined by the projections attached to the node.

  1. … 11 more files in changeset.
Removed unused type param.

    • -3
    • +2
    ./DomainObjectContainerModelProjection.java
    • -3
    • +3
    ./DynamicTypesDomainObjectContainerModelProjection.java
    • -4
    • +4
    ./StaticTypeDomainObjectContainerModelProjection.java
Reuse ModelMapModelView in SpecializedModelMapProjection, so that the specialized view is no longer a wrapper over the generic view. Instead, both views delegate directly to the map implementation.

    • -11
    • +4
    ./DomainObjectContainerModelProjection.java
  1. … 7 more files in changeset.
Moved class from core to modelCore.

  1. … 1 more file in changeset.
Removed initializer that was always a no-op

    • -33
    • +2
    ./PolymorphicModelMapProjection.java
  1. … 2 more files in changeset.
Introduce ModelMap extends CollectionBuilder and allow to use them interchangeably in rules

+review REVIEW-5491

    • -144
    • +0
    ./CollectionBuilderModelProjection.java
    • -2
    • +2
    ./DomainObjectContainerModelProjection.java
    • -0
    • +153
    ./ModelMapModelProjection.java
    • -79
    • +0
    ./PolymorphicCollectionBuilderProjection.java
    • -0
    • +76
    ./PolymorphicModelMapProjection.java
  1. … 113 more files in changeset.
Simplify equals/hashCode by respecting not nullness.

+review REVIEW-5479

    • -8
    • +3
    ./CollectionBuilderModelProjection.java
    • -2
    • +6
    ./PolymorphicCollectionBuilderProjection.java
consider initializer in PolymorphicCollectionBuilderProjection equals method

+review REVIEW-5479

    • -1
    • +6
    ./PolymorphicCollectionBuilderProjection.java
  1. … 1 more file in changeset.