execution

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Renamed src/main/groovy to src/main/java in core

    • -37
    • +0
    ./BuildConfigurationActionExecuter.java
    • -59
    • +0
    ./DefaultBuildConfigurationActionExecuter.java
    • -81
    • +0
    ./DefaultCancellableOperationManager.java
    • -66
    • +0
    ./DefaultTasksBuildExecutionAction.java
    • -49
    • +0
    ./ExcludedTaskFilteringBuildConfigurationAction.java
    • -33
    • +0
    ./PassThruCancellableOperationManager.java
  1. … 2531 more files in changeset.
Fixed static fields that should be final.

This commit fixes a number of static fields that were not declared final, although never updated.

    • -3
    • +3
    ./taskgraph/DefaultTaskGraphExecuter.java
  1. … 22 more files in changeset.
Moved progress logging and styled text logging interfaces to live in their own packages.

    • -2
    • +2
    ./commandline/TaskConfigurationException.java
    • -1
    • +1
    ./taskgraph/DefaultTaskExecutionPlan.java
  1. … 153 more files in changeset.
Moved internal logging classes from 'core' to 'logging' project.

    • -2
    • +2
    ./commandline/TaskConfigurationException.java
    • -1
    • +1
    ./taskgraph/DefaultTaskExecutionPlan.java
  1. … 416 more files in changeset.
Don't trigger the cancellation token if stream is closed while cleaning up monitor thread

This is an attempt to fix a sporadic breakage in `DefaultCancellableOperationManagerTest`,

which appears to be caused by a race condition where the stream is closed before the monitor

thread has been cancelled.

+review

    • -1
    • +12
    ./DefaultCancellableOperationManager.java
Replaced `Specs.and()`, `or()` and `not()` with `intersect()`, `union()` and `negate()`.

The new methods perform some simplification of the specs, such as removing double negation or short circuiting 'and(nothing, something)''. The specs created by these methods are used to select files in file sets, and can be invoked many, many times during a build.

New methods were required as the signatures of the old methods did not allow much simplification. The old methods have been deprecated and will be removed in Gradle 3.0.

    • -1
    • +1
    ./ExcludedTaskFilteringBuildConfigurationAction.java
  1. … 17 more files in changeset.
Simplified implementation of task selection from names provided on command line.

Implementation can delegate to existing methods on `TaskContainerInternal` and does not need to use the `ModelRegistry` directly.

Also avoid discovering tasks multiple times when selecting tasks using camel case matching on a single project (eg `gradle core:intT`).

  1. … 2 more files in changeset.
Don't expose node method

+review REVIEW-5738

  1. … 3 more files in changeset.
Changed bridging of tasks between rules and legacy land so that tasks are not made immutable when they are accessed by name from legacy land.

Instead, tasks are transitioned so that their initializer rules are executed, but mutation and later rules are not executed. These rules are executed when the tasks are added to the task execution graph.

    • -13
    • +5
    ./taskgraph/DefaultTaskExecutionPlan.java
  1. … 8 more files in changeset.
Use HashSet instead of TreeSet

+review REVIEW-5716

    • -3
    • +2
    ./taskgraph/DefaultTaskExecutionPlan.java
Merge pull request #525 from ashoykh/master

Avoid recursing over the same items in enforceWithDependencies

    • -3
    • +10
    ./taskgraph/DefaultTaskExecutionPlan.java
make logging statements conditional because of prettyTime call

    • -2
    • +6
    ./taskgraph/AbstractTaskPlanExecutor.java
Use Collections.singletonList() instead of Arrays.asList() for single item.

    • -2
    • +2
    ./DefaultTasksBuildExecutionAction.java
fix log statement formatting to use {} when applicable

+review REVIEW-5646

    • -2
    • +2
    ./taskgraph/DefaultTaskExecutionPlan.java
  1. … 16 more files in changeset.
Avoid recursing over the same items in enforceWithDependencies

Issue https://issues.gradle.org/browse/GRADLE-3283

    • -3
    • +10
    ./taskgraph/DefaultTaskExecutionPlan.java
Some simplification for how BuildActionRunner implementations influence task selection.

    • -1
    • +1
    ./BuildConfigurationActionExecuter.java
    • -2
    • +2
    ./DefaultBuildConfigurationActionExecuter.java
  1. … 6 more files in changeset.
simplify logic for replacing TaskSelector actions

+review REVIEW-5553

    • -2
    • +1
    ./BuildConfigurationActionExecuter.java
    • -13
    • +10
    ./DefaultBuildConfigurationActionExecuter.java
  1. … 9 more files in changeset.
Changed the contract of ListenerManager to tighten up behaviour when events are generated concurrently.

- Events are delivered listeners of a given type by a single thread at a time.

- Events are delivered in the same order to all listeners of a given type.

Implementation is currently a little rough.

    • -15
    • +5
    ./taskgraph/DefaultTaskGraphExecuter.java
  1. … 6 more files in changeset.
bust up BuildExecuter

- split up BuildConfigurationAction handling into seperate interface

- add functionality to transform given set of BuildConfigurationAction before processing them

+review REVIEW-5553

    • -0
    • +38
    ./BuildConfigurationActionExecuter.java
    • -0
    • +62
    ./DefaultBuildConfigurationActionExecuter.java
  1. … 16 more files in changeset.
Update configuration of test tasks to be launched by TestLauncher TAPI

- allow usage of custom BuildConfigurationAction to calculate tasks to be executed

- adapt TestExecutionRequestActionRunner to register custom BuildConfigurationAction

- unignore testcase regarding Configure-On-Demand in TestLauncherCrossVersionSpec

+review REVIEW-5563

  1. … 8 more files in changeset.
error handling for test task no longer available

  1. … 4 more files in changeset.
Changed BuildOperationExecutor so that it is thread safe.

    • -4
    • +5
    ./taskgraph/DefaultTaskGraphExecuter.java
  1. … 3 more files in changeset.
- Removed task start and finish timestamps from TaskStateInternal, send this via the events on InternalTaskExecutionListener instead. - Removed AbstractTask.executeWithoutThrowingTaskFailure() - Made InternalTaskExecutionListener event generation more robust in the fact of public task listener failures.

    • -9
    • +28
    ./taskgraph/DefaultTaskGraphExecuter.java
  1. … 11 more files in changeset.
Changed TaskPlanExecutor to accept a worker that will run the tasks, rather than a listener. This allows the task event stuff to move to a single place, and also molds TaskPlanExecutor so that it and BuildOperationProcessor start to look the same.

    • -36
    • +8
    ./taskgraph/AbstractTaskPlanExecutor.java
    • -17
    • +27
    ./taskgraph/DefaultTaskGraphExecuter.java
    • -8
    • +5
    ./taskgraph/DefaultTaskPlanExecutor.java
    • -9
    • +9
    ./taskgraph/ParallelTaskPlanExecutor.java
    • -6
    • +3
    ./taskgraph/TaskPlanExecutorFactory.java
  1. … 6 more files in changeset.
Added BuildOperationExecutor.currentOperationId and removed hardcoded parent operation id from AbstractTaskPlanExecutor.

    • -2
    • +7
    ./taskgraph/AbstractTaskPlanExecutor.java
    • -3
    • +6
    ./taskgraph/DefaultTaskGraphExecuter.java
    • -0
    • +5
    ./taskgraph/DefaultTaskPlanExecutor.java
    • -1
    • +3
    ./taskgraph/ParallelTaskPlanExecutor.java
    • -3
    • +6
    ./taskgraph/TaskPlanExecutorFactory.java
  1. … 12 more files in changeset.
Simplify waiting for file system changes or cancellation.

+review REVIEW-5511

    • -90
    • +0
    ./BasicCancellableOperationManager.java
    • -17
    • +6
    ./DefaultCancellableOperationManager.java
    • -0
    • +33
    ./PassThruCancellableOperationManager.java
  1. … 7 more files in changeset.
Add support for non-interactive cancellation in continuous mode - don't read System.in - don't print "(ctrl+d to exit)"

+review REVIEW-5509

    • -0
    • +90
    ./BasicCancellableOperationManager.java
    • -52
    • +4
    ./DefaultCancellableOperationManager.java
  1. … 8 more files in changeset.
fix continuous mode cancellation problems revealed by recent tests

+review REVIEW-5509

    • -0
    • +3
    ./DefaultCancellableOperationManager.java
  1. … 3 more files in changeset.
Extract some cancellation primitives out into reusable blocks.

    • -0
    • +49
    ./CancellableOperationManager.java
    • -0
    • +126
    ./DefaultCancellableOperationManager.java
  1. … 6 more files in changeset.
Rename to BuildOperationType

    • -2
    • +2
    ./taskgraph/AbstractTaskPlanExecutor.java
  1. … 7 more files in changeset.