Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Renamed src/main/groovy to src/main/java in core

    • -37
    • +0
    ./ConfigureActionsProjectEvaluator.java
    • -45
    • +0
    ./DefaultProjectConfigurationActionContainer.java
    • -35
    • +0
    ./PluginsProjectConfigureActions.java
    • -40
    • +0
    ./ProjectConfigurationActionContainer.java
  1. … 2537 more files in changeset.
Initial implementation of Tooling API performance tests

This commit introduces a new kind of performance tests, aimed at measuring the performance of the Tooling API.

By extending `AbstractToolingApiCrossVersionPerformanceTest` a test can check the performance of the tooling

API for various scenarios. In that case, you can specify:

- a list of target versions

- an action to execute in a `GradleConnection` context

The list of target versions is used to tell which version of the Tooling API to use, but also to tell which

version of Gradle we're connecting to.

For now, we're only checking the total duration of the operation, and we are reusing the `CrossVersionResultsStore` to

store the results. We do *not* check the memory consumption yet (not our initial focus).

  1. … 43 more files in changeset.
fix log statement formatting to use {} when applicable

+review REVIEW-5646

  1. … 16 more files in changeset.
Extracted a ScriptTarget type out of DefaultScriptPluginFactory, to encapsulate the target specific behaviour. Also removed some parameters from ScriptPluginFactory.create() that are implied by other parameters.

  1. … 18 more files in changeset.
Removing unused import

Load all project configuration actions once, instead of for each project.

  1. … 1 more file in changeset.
Prepare for not always loading build script classes.

+review REVIEW-5391

    • -1
    • +1
    ./ConfigureActionsProjectEvaluator.java
  1. … 16 more files in changeset.
Bind rule inputs on demand instead of binding everything up front by validating the whole model registry.

+review REVIEW-5343

    • -27
    • +0
    ./ModelRegistryValidatingConfigurationAction.java
  1. … 6 more files in changeset.
Move model registry validation (as it is) to the point where we realize the task container.

This follows the precedent of CoD in that configuration problems in projects that aren't required won't surface.

This is also not the final state of meta model validation, but restores some parity after recent selective task closing changes.

+review REVIEW-5335

  1. … 24 more files in changeset.
Realize the task container on demand.

+review REVIEW-5335

    • -33
    • +0
    ./TaskModelRealizingConfigurationAction.java
  1. … 21 more files in changeset.
Liberate some model registry test support from DefaultModelRegistryTest.

Includes some new/renamed API on ModelRegistry.

+review REVIEW-5350

    • -1
    • +1
    ./TaskModelRealizingConfigurationAction.java
  1. … 21 more files in changeset.
Revert selective task closing work.

Too much breakage.

+review REVIEW-5350

    • -0
    • +33
    ./TaskModelRealizingConfigurationAction.java
  1. … 67 more files in changeset.
Wire the model registry into the “task selector”, effectively enabling configure-on-demand for rule based task declarations.

Rather than eagerly “realize” the whole task container and its contents, we now only realize the container itself.

This means that we know of all the tasks that will exist without actually creating them.

If a task (declared by rules) is not needed for a build (i.e. not selected, not depended on) it will not be created.

However, our rule based plugins at this time contain coarse rules that don't allow this feature to be leveraged.

Benefits will only be seen right now for contrived domains.

    • -33
    • +0
    ./TaskModelRealizingConfigurationAction.java
  1. … 63 more files in changeset.
Change model registry storage from being a table of opaque objects, to a graph of properties.

This doesn't quite satisfy the story goal of being able to target rules to nested properties, because we don't know about the nested properties until we create the objects. If we are using by-type bindings then we don't know that we need to create the parent object. To solve this we need to start populating the graph when something is registered (i.e. insert it in a kind of pending state, with its links also in a pending state) and then only populate the data when the node is “initialised”.

We are also only respecting one level of depth at the moment. That is, we treat (as far as the model graph is concerned) the properties of managed elements as unmanaged. Later stories will make this fully “transitive”.

+review

    • -1
    • +1
    ./TaskModelRealizingConfigurationAction.java
  1. … 123 more files in changeset.
Don't use ProjectConfigurationAction.

+review REVIEW-5176

    • -1
    • +2
    ./ModelRegistryValidatingConfigurationAction.java
    • -1
    • +2
    ./TaskModelRealizingConfigurationAction.java
Go back to adding model rules for tasks as soon as they are added to the task container

+review REVIEW-5176

    • -47
    • +0
    ./TaskModelPopulatingConfigurationAction.java
  1. … 11 more files in changeset.
Use the task's actual type when populating the model

+review REVIEW-5176

    • -8
    • +12
    ./TaskModelPopulatingConfigurationAction.java
  1. … 2 more files in changeset.
Revert "Revert "Expansion/improvement of compile time transforming for model rules in the DSL.""

This reverts commit 1a9872da557fc63a2af73abc4447cb28d96a4d4d.

Problems with original implementation have been fixed.

    • -1
    • +1
    ./ConfigureActionsProjectEvaluator.java
  1. … 18 more files in changeset.
Introduce project finalizer action to LifecycleProjectEvaluator

+review REVIEW-5176

  1. … 2 more files in changeset.
Extract ModelRegistryValidatingConfigurationAction from TaskModelRealizingConfigurationAction

+review REVIEW-5176

    • -0
    • +26
    ./ModelRegistryValidatingConfigurationAction.java
    • -4
    • +1
    ./TaskModelRealizingConfigurationAction.java
  1. … 2 more files in changeset.
Revert "Expansion/improvement of compile time transforming for model rules in the DSL."

This reverts commit b6a2261e3ea52f22e34ca07b3e8493febe21d669.

Need to deal with the unit tests that are using the model DSL, which is no longer feasible because it relies on transforms.

    • -1
    • +1
    ./ConfigureActionsProjectEvaluator.java
  1. … 18 more files in changeset.
Expansion/improvement of compile time transforming for model rules in the DSL.

+review REVIEW-5177

    • -1
    • +1
    ./ConfigureActionsProjectEvaluator.java
  1. … 18 more files in changeset.
Configuration performed to “bridged” model element made in afterEvaluate() is visible to creation rule

+review REVIEW-5176

    • -0
    • +43
    ./TaskModelPopulatingConfigurationAction.java
  1. … 15 more files in changeset.
Revert "Configuration performed to “bridged” model element made in afterEvaluate() is visible to creation rule"

This reverts commit e8f4af3c5c53ee660100ac6158ae232396f0621b.

    • -0
    • +35
    ./TaskModelRealizingConfigurationAction.java
  1. … 10 more files in changeset.
Configuration performed to “bridged” model element made in afterEvaluate() is visible to creation rule

+review REVIEW-5176

    • -35
    • +0
    ./TaskModelRealizingConfigurationAction.java
  1. … 10 more files in changeset.
Don't call the method that validates/closes the model registry close.

The registry is part of the project service registry, which automatically calls close() on any objects that implement such a method on shutdown.

    • -1
    • +1
    ./TaskModelRealizingConfigurationAction.java
  1. … 2 more files in changeset.
Initial implementation of reporting on model rules that fail to bind.

It's not entirely accurate yet and the error output is insufficient.

    • -2
    • +5
    ./TaskModelRealizingConfigurationAction.java
  1. … 37 more files in changeset.
Remove some use of String as a model path.

    • -1
    • +2
    ./TaskModelRealizingConfigurationAction.java
  1. … 20 more files in changeset.
Simplify ClassLoaderScope.

- Allow attaching of arbitrary classloaders (supports graphs instead of just trees)

- Remove “base” concept

  1. … 47 more files in changeset.
Removed some deprecated methods from Project and Test.

    • -41
    • +0
    ./ProjectDependencies2TaskResolver.java
  1. … 26 more files in changeset.