Clone Tools
  • last updated a few seconds ago
Constraints: committers
Constraints: files
Constraints: dates
Renamed src/main/groovy to src/main/java in core

  1. … 2531 more files in changeset.
Reduced visibility of some properties of `Delete`

Refine javadoc around fixing GRADLE-1506

+review REVIEW-5914

  1. … 3 more files in changeset.
JAR metadata charset now defaults to UTF-8, fixes GRADLE-1506

One can use the `metadataCharset` property to set a different charset

and Charset.defaultCharset().name() as a value to fallback to previous


+review REVIEW-5914

  1. … 5 more files in changeset.
GRADLE-1267 add a filteringCharset property to the copy spec

The copy task (and all the other tasks based on a CopySpec) allow filtering the source files to transform them. But the charset used to read and write the files was always the platform default charset, which causes problem if, for example, the source files are encoded with UTF8 but the platform default charset is another one.

This commit allows specifying a charset to use when filtering the files using `filteringCharset = 'UTF8'` (for example).

Note that the name `filteringCharset` was chosen for this new property as specified in `design-docs/handling-encodings.md`.

  1. … 15 more files in changeset.
Remove the return type from setFollowingSymlinks()

+review REVIEW-5852

  1. … 2 more files in changeset.
Add delete(Action<? super DeleteSpec>) to Project

+review REVIEW-5852

- Adds a DeleteSpec

- Deprecates and removes references to DeleteAction

- Moves DeleteActionImpl to Deleter

- Updates tests

  1. … 16 more files in changeset.
Move follow symlinks to a field.

+review REVIEW-5852

- This change also moves the deletion of the test symlink in Jdk7Symlink

to a finally block instead of at VM shutdown.

  1. … 5 more files in changeset.
Optimize PatternSet.intersect()

- omit extra layer when the instance is empty

+review REVIEW-5869

Add isEmpty method to PatternSet

+review REVIEW-5869

  1. … 1 more file in changeset.
Revert "avoid duplicate dir scans in uptodate logic"

unblocking colleages. this change broke the PlayReloadIntegrationTests.

Needs further investigations

This reverts commit f3b55a8862d1fdd5365529d82922747e2c3f5ba1.

  1. … 4 more files in changeset.
avoid duplicate dir scans in uptodate logic

- dedup directory filetreee results in DefaultFileCollectionResolveContext#resolveAsFileCollections()

- this results in one less scan of test classes directory when exeucting test task

TODO: diagnose possible duplications of SingletonFileTree

  1. … 4 more files in changeset.
Merging PR #574 again, again, for the last time.

+review REVIEW-5852

- This reverts commit e074f7824dd5d357f01d1875bdce9977d713f59b.

- This has got work.

- Third time's the charm.

  1. … 20 more files in changeset.
Revert "Merge PR #574 again, again."

+review REVIEW-5852

- This reverts commit 110e7b876aa2dbe3feb0c3bb2c01e50e191c5b55.

- Apparently this has something to do with a strange groovy problem.

  1. … 19 more files in changeset.
Merge PR #574 again.

+review REVIEW-5852

- Also, this time the constructor is public.

- Without this change there is an IllegalAccess error when we

use an instantiator to create a JdkySymliink from outside the


  1. … 19 more files in changeset.
Revert the merge of #574 Delete will not follow symlinks.

+review REVIEW-5852

- This broke some integration tests. I will figure out why

and put everything back.

  1. … 19 more files in changeset.
Moved @Incubating to public members and fixed up the release notes

  1. … 1 more file in changeset.
Some doumentation updates for Delete

  1. … 2 more files in changeset.
Added integration test, makde a jdk7 symlink

The FileSystemService will now use the jdk7 impl by default when

native-platform isn't avalible.

  1. … 5 more files in changeset.
Delete will no longer follow symlinks and delete the contents of link


As more languages come onboard with Gradle, symlinks become more common.

If we follow symlinks and try to delete the contents it could fail (for

system paths) or in the worst case, it will delete system contents (if

the build runs as root)

This change is a backwards incompatable change. Per the discussion on


it was decided to be important enough to introduce. The behavior change

is that `project.delete()` will not follow symlinks, if a user needs

symlinks to be followed they will have to use `ant.delete()` instead.

The `Delete` task has a property added called followSymlinks that will

toggle the following of symlinks. This way the user can opt into

changing the behavior for those tasks.

  1. … 12 more files in changeset.
Use a factory to create `ExecHandlerBuilder`, `JavaExecHandlerBuilder`, `ExecAction` and `JavaExecAction` instances.

+review REVIEW-5806

  1. … 15 more files in changeset.
Added `@Incubating` to new `PatternSet` constructors so they can be removed in 2.12.

Mark packages having only @Incubating types as @Incubating

  1. … 39 more files in changeset.
Revert breaking change to public API

  1. … 1 more file in changeset.
Renamed HeapProportionalSizer and methods for clarity +review REVIEW-5627

  1. … 3 more files in changeset.
Polishing changes to use PatternSpecFactory +review REVIEW-5627

    • -25
    • +0
  1. … 13 more files in changeset.
Fixed compile problems on Java 1.6.

    • -1
    • +5
  1. … 1 more file in changeset.
Extracted a super interface out of `FileResolver` and changed a bunch of things to use the new interface.

`FileResolver` drags in a lot of baggage, and a more focused interface allows things to declare which parts they actually need. Also helps bust up some cycles between `FileResolver` and the things it needs.

    • -3
    • +3
  1. … 33 more files in changeset.
Replaced `Specs.and()`, `or()` and `not()` with `intersect()`, `union()` and `negate()`.

The new methods perform some simplification of the specs, such as removing double negation or short circuiting 'and(nothing, something)''. The specs created by these methods are used to select files in file sets, and can be invoked many, many times during a build.

New methods were required as the signatures of the old methods did not allow much simplification. The old methods have been deprecated and will be removed in Gradle 3.0.

    • -5
    • +8
  1. … 16 more files in changeset.
Manage creation of most PatternSet instances

- use managed CachingPatternSpecFactory instance for

these PatternSet instances

+review REVIEW-5627

    • -0
    • +25
    • -0
    • +33
  1. … 34 more files in changeset.