Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Disallow `buildSrc` as the name of an included build

Except for the actual buildSrc build

    • -0
    • +107
    ./DisallowBuildSrcAsNameIntegTest.groovy
    • -73
    • +0
    ./DisallowIncludingBuildSrcAsProjectIntegTest.groovy
  1. … 4 more files in changeset.
Restore < Gradle 6 buildSrc location when using custom root project dir

Previously, we used ${settings.rootDir}/buildSrc, but this was evaluated

before the settings file. So, if the user changed the root dir location

we were unaffected. Now that settings is evaluated first, we looked in a

different place. Strike one more for silent mutability.

    • -0
    • +40
    ./BuildSrcLocationIntegrationTest.groovy
  1. … 1 more file in changeset.
Make paths/names of included builds immutable (#10998)

Changes the “build path” for included builds to be determined at inclusion time based on the directory name, or a user supplied override. Previously, we tried to use the root project name defined in the included build. This caused a lot of complexity due to it not being known until part way through building the included build.

This change also disallows use of `buildSrc` as a project name, as it collides with the `buildSrc` nested build.

    • -0
    • +73
    ./DisallowIncludingBuildSrcAsProjectIntegTest.groovy
  1. … 72 more files in changeset.
Disallow builds defining a project at :buildSrc

This is already prohibited by the composite build machinery if there is

also a real buildSrc project. This change makes the failure earlier and

more obvious.

    • -0
    • +73
    ./DisallowIncludingBuildSrcAsProjectIntegTest.groovy
  1. … 8 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 12 more files in changeset.
Build buildSrc after applying the settings file (#10305)

Fixes #9094 and #5333

    • -194
    • +0
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
    • -0
    • +88
    ./BuildSrcVisibilityIntegrationTest.groovy
  1. … 53 more files in changeset.
Update subprojects/core/src/integTest/groovy/org/gradle/initialization/buildsrc/BuildSrcVisibilityIntegrationTest.groovy

Co-Authored-By: Sterling Greene <big-guy@users.noreply.github.com>

    • -1
    • +1
    ./BuildSrcVisibilityIntegrationTest.groovy
Update subprojects/core/src/integTest/groovy/org/gradle/initialization/buildsrc/BuildSrcVisibilityIntegrationTest.groovy

Co-Authored-By: Sterling Greene <big-guy@users.noreply.github.com>

    • -1
    • +0
    ./BuildSrcVisibilityIntegrationTest.groovy
Update subprojects/core/src/integTest/groovy/org/gradle/initialization/buildsrc/BuildSrcVisibilityIntegrationTest.groovy

Co-Authored-By: Sterling Greene <big-guy@users.noreply.github.com>

    • -1
    • +0
    ./BuildSrcVisibilityIntegrationTest.groovy
Update subprojects/core/src/integTest/groovy/org/gradle/initialization/buildsrc/BuildSrcVisibilityIntegrationTest.groovy

Co-Authored-By: Sterling Greene <big-guy@users.noreply.github.com>

    • -1
    • +1
    ./BuildSrcVisibilityIntegrationTest.groovy
Merge remote-tracking branch 'origin/release'

* origin/release:

Fix resolving `DirectoryTee` elements of a `FileCollection`.

Avoid sharing the same id for the deprecated classloader as the real classloader

Recognize contributor

enhanced test source folder detection for eclipse task. (#10320)

Turn 'multiple publications with same coordinates' error into warning

Override getResources in DefaultDeprecatedClassLoader

Update default scan plugin version to 2.4.1

    • -3
    • +21
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 4 more files in changeset.
Merge remote-tracking branch 'origin/master-test' into release-test

    • -3
    • +3
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 3 more files in changeset.
Merge remote-tracking branch 'origin/master-test' into release-test

    • -3
    • +3
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 3 more files in changeset.
Avoid sharing the same id for the deprecated classloader as the real classloader

    • -3
    • +21
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 2 more files in changeset.
Maybe works

    • -3
    • +21
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 1 more file in changeset.
wip

    • -3
    • +21
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 1 more file in changeset.
Align implementations of artifact identifier display names

DefaultModuleComponentArtifactIdentifier now behaves similar as

ComponentFileArtifactIdentifier (showing the full actual file name).

This means that the artifact name used during reporting now

contains the version at the usual position in the file name.

This way it shows the actual file name for artifacts originating

from pom-only maven repositories (except snapshots, which show the

SNAPSHOT placeholder) and ivy repositories with default pattern.

The motivation for this alignment is to get the same representation for

the same file, independent of whether it was sourced from traditional

or Gradle module metadata.

    • -1
    • +1
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 32 more files in changeset.
Align implementations of artifact identifier display names

DefaultModuleComponentArtifactIdentifier now behaves similar as

ComponentFileArtifactIdentifier (showing the full actual file name).

This means that the artifact name used during reporting now

contains the version at the usual position in the file name.

This way it shows the actual file name for artifacts originating

from pom-only maven repositories (except snapshots, which show the

SNAPSHOT placeholder) and ivy repositories with default pattern.

The motivation for this alignment is to get the same representation for

the same file, independent of whether it was sourced from traditional

or Gradle module metadata.

    • -1
    • +1
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 32 more files in changeset.
Build buildSrc after applying the settings file

This allows the build cache settings to implicitly apply to buildSrc,

whereas before the configuration had to be duplicated there.

    • -176
    • +0
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
    • -0
    • +90
    ./BuildSrcVisibilityIntegrationTest.groovy
  1. … 29 more files in changeset.
Do not use deprecated configurations in tests

    • -3
    • +3
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 5 more files in changeset.
Do not use deprecated configurations in tests

    • -3
    • +3
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 5 more files in changeset.
Do not use deprecated configurations in tests

    • -3
    • +3
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 6 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -1
    • +0
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 95 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -1
    • +0
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -1
    • +0
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -1
    • +0
    ./BuildSrcIdentityIntegrationTest.groovy
  1. … 15 more files in changeset.
Fix typo in test

    • -1
    • +1
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
Tweak deprecation message (add plural s)

    • -3
    • +3
    ./BuildSrcDeprecatedInSettingsIntegrationTest.groovy
  1. … 8 more files in changeset.