Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Restore ability to have dots in `ModelPath` components

This fixes a regression, where tasks could have dots in names.

+review REVIEW-5921

    • -2
    • +0
    ./RuleTaskCreationIntegrationTest.groovy
  1. … 3 more files in changeset.
Temporarily disable test

+review REVIEW-5921

    • -0
    • +2
    ./RuleTaskCreationIntegrationTest.groovy
Simplified implementation of task selection from names provided on command line.

Implementation can delegate to existing methods on `TaskContainerInternal` and does not need to use the `ModelRegistry` directly.

Also avoid discovering tasks multiple times when selecting tasks using camel case matching on a single project (eg `gradle core:intT`).

    • -1
    • +1
    ./RuleTaskCreationIntegrationTest.groovy
  1. … 2 more files in changeset.
Some minor changes to test coverage for task definition from rules.

    • -6
    • +4
    ./RuleTaskBridgingIntegrationTest.groovy
    • -1
    • +1
    ./RuleTaskExecutionIntegrationTest.groovy
Changed bridging of tasks between rules and legacy land so that tasks are not made immutable when they are accessed by name from legacy land.

Instead, tasks are transitioned so that their initializer rules are executed, but mutation and later rules are not executed. These rules are executed when the tasks are added to the task execution graph.

    • -1
    • +153
    ./RuleTaskBridgingIntegrationTest.groovy
  1. … 9 more files in changeset.
Moved some tests between test cases.

    • -1
    • +112
    ./RuleTaskBridgingIntegrationTest.groovy
    • -107
    • +0
    ./RuleTaskCreationIntegrationTest.groovy
Renamed some test classes.

    • -368
    • +0
    ./RuleBasedTaskBridgingIntegrationTest.groovy
    • -225
    • +0
    ./RuleBasedTaskExecutionIntegrationTest.groovy
    • -0
    • +368
    ./RuleTaskBridgingIntegrationTest.groovy
    • -0
    • +721
    ./RuleTaskCreationIntegrationTest.groovy
    • -0
    • +225
    ./RuleTaskExecutionIntegrationTest.groovy
    • -721
    • +0
    ./TaskCreationIntegrationTest.groovy
Moved int test case that covers rule task definition to core project to live with the other test cases for this.

Reworked the tests to share some fixtures.

    • -19
    • +14
    ./RuleBasedTaskExecutionIntegrationTest.groovy
    • -0
    • +721
    ./TaskCreationIntegrationTest.groovy
  1. … 1 more file in changeset.
Some int test tidy-ups.

    • -18
    • +13
    ./RuleBasedTaskBridgingIntegrationTest.groovy
  1. … 1 more file in changeset.
Add test verifying that we aren't realizing more tasks than we need to.

+review REVIEW-5580

    • -0
    • +30
    ./RuleBasedTaskBridgingIntegrationTest.groovy
Simplify task collection bridging by allowing state transitions directly via the model node.

Allows realizable task collections to work solely with a node.

+review REVIEW-5580

    • -1
    • +3
    ./RuleBasedTaskBridgingIntegrationTest.groovy
  1. … 8 more files in changeset.
Adds more task bridging test cases and specs

+review REVIEW-5580

    • -0
    • +116
    ./RuleBasedTaskBridgingIntegrationTest.groovy
  1. … 2 more files in changeset.
Makes project evaluation dependency explicit

+review REVIEW-5580

    • -1
    • +3
    ./RuleBasedTaskBridgingIntegrationTest.groovy
Removed redundant test

+review REVIEW-5580

    • -32
    • +1
    ./RuleBasedTaskBridgingIntegrationTest.groovy
Consolidates two task bridging specs

+review REVIEW-5580

    • -87
    • +0
    ./RuleBasedTaskActionsIntegrationTest.groovy
    • -0
    • +254
    ./RuleBasedTaskBridgingIntegrationTest.groovy
    • -189
    • +0
    ./RuleBasedTaskReferenceIntegrationTest.groovy
Adds a test case for depending on rule tasks which cannot be created.

+review REVIEW-5580

    • -0
    • +28
    ./RuleBasedTaskReferenceIntegrationTest.groovy
Adds coverage for depending on tasks by type after project evaluation

+review REVIEW-5580

    • -0
    • +28
    ./RuleBasedTaskReferenceIntegrationTest.groovy
Moves publishing test to publishing module

+review REVIEW-5580

    • -44
    • +1
    ./RuleBasedTaskReferenceIntegrationTest.groovy
  1. … 1 more file in changeset.
Ignoring test while investigating

    • -0
    • +3
    ./RuleBasedTaskReferenceIntegrationTest.groovy
Adds coverage for depending on tasks in already evaluated projects

+review REVIEW-5580

    • -1
    • +32
    ./RuleBasedTaskReferenceIntegrationTest.groovy
Adds coverage for task suptypes and cross-project dependencies

+review REVIEW-5580

    • -4
    • +2
    ./RuleBasedTaskReferenceIntegrationTest.groovy
  1. … 1 more file in changeset.
Verifies that only tasks of the specified type are realised.

+review REVIEW-5580

    • -28
    • +0
    ./RuleBasedTaskReferenceIntegrationTest.groovy
  1. … 2 more files in changeset.
Uses a RealizableTaskCollection to realise tasks referenced via '.withType()'

+review REVIEW-5580

    • -1
    • +2
    ./RuleBasedTaskReferenceIntegrationTest.groovy
  1. … 6 more files in changeset.
Revert "First cut at 'withType' task bridging"

This reverts commit 5f39c1acc23d4942ae16cf6f24607bdf1396ab9b.

    • -5
    • +8
    ./RuleBasedTaskReferenceIntegrationTest.groovy
  1. … 4 more files in changeset.
Applies 'withType' task bridging after deferred configuration - Implements more test cases.

+review REVIEW-5580

    • -8
    • +89
    ./RuleBasedTaskReferenceIntegrationTest.groovy
  1. … 3 more files in changeset.
First cut at 'withType' task bridging

+review REVIEW-5580

    • -8
    • +5
    ./RuleBasedTaskReferenceIntegrationTest.groovy
  1. … 4 more files in changeset.
Adds another story and test coverage

+review REVIEW-5580

    • -0
    • +27
    ./RuleBasedTaskActionsIntegrationTest.groovy
  1. … 1 more file in changeset.
Adds more coverage and splits out action tests

+review REVIEW-5580

    • -0
    • +60
    ./RuleBasedTaskActionsIntegrationTest.groovy
    • -47
    • +2
    ./RuleBasedTaskReferenceIntegrationTest.groovy
    • -0
    • +48
    ./WithRuleBasedTasks.groovy
Updates rule-source task realisation spec - Fixed up the initial test cases. - This is likely more involved than 1st thought so moved to it's own spec.

+review REVIEW-5580

    • -59
    • +64
    ./RuleBasedTaskReferenceIntegrationTest.groovy
  1. … 2 more files in changeset.
Updates test to use a task not specified on the command line.

+review REVIEW-5580

    • -3
    • +9
    ./RuleBasedTaskReferenceIntegrationTest.groovy