internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wait between iterations of memory leak test

IBM JVMs sometimes falsely report being out of

heap space. Let's see if a small grace period

helps.

    • -0
    • +1
    ./initialization/loadercache/ClassLoaderLeakAvoidanceIntegrationTest.groovy
Fix convention mapping class loader leak

The reflection cache keeps a set of property names for each class.

This set was provided by calling keySet() on a map which contains

class values. The keyset would thus keep a strong reference back

to its map and all of its values, leading to a classloader leak.

We now do a defensive copy of they keyset to avoid surprises for

callers of this method.

    • -0
    • +56
    ./initialization/loadercache/ClassLoaderLeakAvoidanceIntegrationTest.groovy
  1. … 1 more file in changeset.
Fix convention mapping class loader leak

The reflection cache keeps a set of property names for each class.

This set was provided by calling keySet() on a map which contains

class values. The keyset would thus keep a strong reference back

to its map and all of its values, leading to a classloader leak.

We now do a defensive copy of they keyset to avoid surprises for

callers of this method.

    • -0
    • +56
    ./initialization/loadercache/ClassLoaderLeakAvoidanceIntegrationTest.groovy
  1. … 1 more file in changeset.
Do not restart unnamed property counter

When unnamed properties are assigned a name like etc., we now keep track

of the last number assigned, and if more unnamed properties are registered,

we don't restart counting from , resulting in property name collisions.

    • -0
    • +79
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 9 more files in changeset.
Allow enabling build cache in all integration tests

Signed-off-by: Lóránt Pintér <lorant@gradle.com>

    • -48
    • +48
    ./changedetection/rules/OverlappingOutputsIntegrationTest.groovy
    • -14
    • +14
    ./tasks/TaskCacheabilityReasonIntegrationTest.groovy
  1. … 26 more files in changeset.
Start nested iterable naming from zero

Signed-off-by: Stefan Wolf <wolf@gradle.com>

    • -3
    • +3
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 3 more files in changeset.
Make unknown nested inputs available to build scan plugin (#3958)

The build scan plugin should be aware when a task is not cached or not

up-to-date if nested inputs have been loaded by a classloader not

managed by Gradle.

    • -3
    • +42
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 4 more files in changeset.
Use `.class` instead of `.$$implementation` for nested property implementation (#3965)

Instead of introducing a new generated property for nested beans we

should re-use the `.class` property which is already present.

    • -4
    • +2
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 8 more files in changeset.
Allow rich Java compiler arguments (#3858)

This allows adding richer compiler arguments to JavaCompile.

    • -16
    • +57
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 30 more files in changeset.
Allow `ListProperty<T>` and `SetProperty<T>` properties to be set using any `Iterable<T>` or `Provider<Iterable<T>`, including through the Groovy DSL.

`ListProperty` and `SetProperty` no longer extend `Property`, as this type requires the same type to be used to set and query the property value.

Also added an (internal for now) lockable `SetProperty` implementation.

    • -0
    • +131
    ./provider/ListPropertyIntegrationTest.groovy
    • -125
    • +0
    ./provider/ListPropertyTaskIntegrationTest.groovy
  1. … 24 more files in changeset.
Remove some wrong timing loggings (#3860)

* Remove some wrong timing loggings

The time which was captured for up-to-date checks is wrong, since it

did not include actual snapshotting any more.

The time captured how long it took to load/unpack from the cache now

would have included the time it took to snapshot the inputs, too.

These timings are much better captured by the corresponding build

operations, so we remove the log entries for now.

Signed-off-by: Stefan Wolf <wolf@gradle.com>

    • -2
    • +2
    ./changedetection/state/UpToDateIntegTest.groovy
  1. … 7 more files in changeset.
Added a `SetProperty<T>` type as a convenience for dealing with properties of `Set<T>`.

    • -7
    • +7
    ./provider/ListPropertyTaskIntegrationTest.groovy
  1. … 18 more files in changeset.
Don't use now deprecated getProperties() method

Signed-off-by: Lóránt Pintér <lorant@gradle.com>

    • -47
    • +67
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 6 more files in changeset.
Support rich task inputs (#3720)

@Nested inputs are now discovered based on the runtime type instead of the static type.

    • -1
    • +189
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 150 more files in changeset.
Attempt to fix https://github.com/gradle/gradle-private/issues/975

This PR adds a guard for PipedInputStream to make sure it's safe to

read after being closed.

    • -4
    • +8
    ./tasks/userinput/AbstractUserInputHandlerIntegrationTest.groovy
    • -82
    • +24
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
  1. … 3 more files in changeset.
Wait until currently executing jobs have been completed

    • -3
    • +0
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
  1. … 1 more file in changeset.
Leverage gradlePluginPortal() in tests

where the m2 URL was hardcoded

    • -1
    • +1
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 3 more files in changeset.
Ignore tests as they are still flaky

    • -2
    • +3
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
Wait until daemon becomes idle before closing standard input pipe (#3270)

    • -5
    • +5
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
Ignore flaky test for now

    • -0
    • +1
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
Ignore flaky test for now

    • -0
    • +2
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
Attempt at fixing flakiness

Also removes test case that was already covered in some other form.

    • -7
    • +2
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
Close standard input pipe only after build has finished (#3222)

    • -9
    • +14
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
  1. … 2 more files in changeset.
Use Spock import

    • -1
    • +1
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
Ignore flaky tests to unblock pipeline

    • -0
    • +3
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
Clean up ListProperty more

- Clarify JavaDoc for add(Provider)/addAll(Provider)

- Add helper method in DefaultListPropertyTest to assert expected state

- Add integration test for list property

    • -0
    • +125
    ./provider/ListPropertyTaskIntegrationTest.groovy
  1. … 3 more files in changeset.
Separate non-daemon and daemon tests to isolate flakiness

Also kills the daemon after use.

    • -8
    • +4
    ./tasks/userinput/AbstractUserInputHandlerIntegrationTest.groovy
    • -20
    • +71
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
  1. … 1 more file in changeset.
Replaced some usages of `PropertyState` with `Property`.

    • -1
    • +1
    ./model/DefaultObjectFactoryIntegrationTest.groovy
  1. … 6 more files in changeset.
Deprecated `PropertyState` interface, which is replaced by `Property`. Deprecated the `Project.property()`, `Script.property()` and `ProviderFactory.property()` methods, which are replaced by `ObjectFactory.property()`.

    • -2
    • +2
    ./model/DefaultObjectFactoryIntegrationTest.groovy
  1. … 19 more files in changeset.
Build scan plugin can be auto-applied with with artifact coordinates (#3131)

    • -15
    • +0
    ./tasks/userinput/AbstractUserInputHandlerIntegrationTest.groovy
  1. … 5 more files in changeset.