internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Change class generation to accept interface types. The interface may define mutable properties and an implementation is mixed in for each mutable property. The interface may also define `default` methods, `@Inject` properties and may extend `ExtensionAware`. Immutable properties with lazy types (eg `Property`) are not supported yet.

This commit does not include any validation or documentation. These will be added in later commits.

    • -4
    • +35
    ./model/ObjectFactoryIntegrationTest.groovy
  1. … 9 more files in changeset.
Remove PropertySpecFactory

    • -2
    • +2
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 33 more files in changeset.
Adapt visitLocalStateProperty

    • -2
    • +2
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 12 more files in changeset.
Adapt visitDestroyableProperty

    • -2
    • +2
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 8 more files in changeset.
Adapt visitOutputFileProperty

    • -5
    • +5
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 34 more files in changeset.
Adapt visitInputProperty

    • -2
    • +2
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 15 more files in changeset.
The visitor should handle all the creation

Especially the annotation handler should not need the file resolver.

    • -3
    • +3
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 44 more files in changeset.
Don't use propertySpecFactory for input files

    • -7
    • +7
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 51 more files in changeset.
Improve error reporting when attempting to instantiate an interface or a non-static inner class.

    • -0
    • +43
    ./model/ObjectFactoryIntegrationTest.groovy
  1. … 9 more files in changeset.
Allow abstract service injection getter methods on decorated types.

    • -0
    • +31
    ./model/ObjectFactoryIntegrationTest.groovy
  1. … 6 more files in changeset.
Add some validation of extension constructors, and tweak some error messages.

    • -1
    • +1
    ./model/ObjectFactoryIntegrationTest.groovy
  1. … 15 more files in changeset.
Ensure extensions attached to decorated objects have access to the same services as the decorated object.

    • -272
    • +0
    ./model/DefaultObjectFactoryIntegrationTest.groovy
    • -0
    • +322
    ./model/ObjectFactoryIntegrationTest.groovy
  1. … 13 more files in changeset.
Allow `@Inject` getter of an object to be called from the object's constructor. Previously this worked for tasks but would fail with a NPE for other decorated types.

    • -2
    • +0
    ./model/CustomPluginObjectFactoryIntegrationTest.groovy
    • -1
    • +32
    ./model/DefaultObjectFactoryIntegrationTest.groovy
  1. … 10 more files in changeset.
Add some test coverage of service injection into various types of domain objects.

    • -0
    • +25
    ./model/DefaultObjectFactoryIntegrationTest.groovy
  1. … 4 more files in changeset.
Report relative path for overlapping outputs (#7816)

when caching has been disabled.

    • -1
    • +1
    ./tasks/TaskCacheabilityReasonIntegrationTest.groovy
  1. … 4 more files in changeset.
Increase UserInputHandlingIntegrationTest timeout

Previously we have encountered a lot of timeout in UserInputHandlingIntegrationTest,

now we simply increase the timeout to see how it works.

    • -3
    • +4
    ./tasks/userinput/UserInputHandlingIntegrationTest.groovy
Add empty settings.gradle to UserInputHandlingIntegrationTest

Looking at the history of UserInputHandlingIntegrationTest, some of them costs over 10 seconds to start,

which seems to be caused by lacking proper settings.gradle file. Now we add an empty one.

    • -0
    • +2
    ./tasks/userinput/UserInputHandlingIntegrationTest.groovy
Do not discard task execution failure when a `afterTask` handler fails. Instead, report both failures in the build outcome.

Also wrap `beforeTask` and `afterTask` failures in a contextual "task failed" exception.

    • -4
    • +4
    ./tasks/execution/ExecuteTaskBuildOperationTypeIntegrationTest.groovy
  1. … 11 more files in changeset.
Cleanup unused classloaders

Until now our classloader cache would only ever remove a classlaoder

if it was replaced by another one with the same ID. This works fine

if the daemon is used to build only one project. However, it becomes

a serious memory leak if the daemon builds many different projects.

This is a common scenario in Gradle integration tests, both in our

own code base and for users testing their plugins with TestKit.

In those cases the same daemon is used to build many different projects

and the JVM can eventually run out of metaspace.

This change adjusts the classloader cache so that it only retains

classloaders which were used either in the current build or the

previous build. All older unused classloaders are discarded to free

up memory.

    • -168
    • +1
    ./initialization/loadercache/ClassLoadersCachingIntegrationTest.groovy
  1. … 7 more files in changeset.
Move some console functional test coverage to `logging` to live with the other console test coverage. Also add more coverage for the reporting of the build result at the end of the build (actionable tasks, and so on).

    • -75
    • +0
    ./buildevents/AbstractBuildResultLoggerFunctionalTest.groovy
    • -25
    • +0
    ./buildevents/PlainConsoleBuildResultLoggerFunctionalTest.groovy
    • -25
    • +0
    ./buildevents/RichConsoleBuildResultLoggerFunctionalTest.groovy
    • -25
    • +0
    ./buildevents/VerboseConsoleBuildResultLoggerFunctionalTest.groovy
  1. … 8 more files in changeset.
Consistently show file changes for single root file in Gradle Enterprise (#7422)

* Snapshot SingletonFileTree as RegularFileSnapshot

- extract SingletonFileTree as interface

- rename SingletonFileTree to DefaultSingletonFileTree

- rename MapFileTree to GeneratedSingletonFileTree

- GeneratedSingletonFileTree only accepts one file (as its only used for one file so far)

- add coverage for archives

    • -0
    • +28
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 22 more files in changeset.
Calculate caching state outside of TaskOutputs

    • -1
    • +1
    ./tasks/TaskCacheabilityReasonIntegrationTest.groovy
  1. … 10 more files in changeset.
Stop ignoring tests and fix removed deprecated build scan property

    • -4
    • +2
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 7 more files in changeset.
Move ExecuteTaskBuildOperationType (#7374)

* Move ExecuteTaskBuildOperationType to org.gradle.api.internal.tasks.execution

* Remove redundant import

    • -1
    • +1
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
    • -0
    • +138
    ./tasks/execution/ExecuteTaskBuildOperationTypeIntegrationTest.groovy
  1. … 24 more files in changeset.
Do not use star-imports

    • -1
    • +6
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 1 more file in changeset.
Merge pull request #6921 from gradle/marc/issues/6296-ignore-annotation-processors-on-compile-classpath

Ignore annotation processors on compile classpath and forbid using -processorpath

    • -1
    • +1
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 2 more files in changeset.
Fix / ignore tests until build scan plugin 2.0 is out and used in AutoAppliedBuildScanPlugin

    • -22
    • +17
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 1 more file in changeset.
Track CompileOptions.annotationProcessorPath for up-to-date checking

    • -1
    • +5
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 3 more files in changeset.
Deprecate JavaCompile.effectiveAnnotationProcessorPath

    • -5
    • +1
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 3 more files in changeset.
Relax ordering of plugin application operation asserts

    • -19
    • +13
    ./plugins/ApplyPluginBuildOperationIntegrationTest.groovy
  1. … 1 more file in changeset.