internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Allow `@Inject` getter of an object to be called from the object's constructor. Previously this worked for tasks but would fail with a NPE for other decorated types.

    • -2
    • +0
    ./model/CustomPluginObjectFactoryIntegrationTest.groovy
    • -1
    • +32
    ./model/DefaultObjectFactoryIntegrationTest.groovy
  1. … 10 more files in changeset.
Add some test coverage of service injection into various types of domain objects.

    • -0
    • +25
    ./model/DefaultObjectFactoryIntegrationTest.groovy
  1. … 4 more files in changeset.
Report relative path for overlapping outputs (#7816)

when caching has been disabled.

    • -1
    • +1
    ./tasks/TaskCacheabilityReasonIntegrationTest.groovy
  1. … 4 more files in changeset.
Increase UserInputHandlingIntegrationTest timeout

Previously we have encountered a lot of timeout in UserInputHandlingIntegrationTest,

now we simply increase the timeout to see how it works.

    • -3
    • +4
    ./tasks/userinput/UserInputHandlingIntegrationTest.groovy
Add empty settings.gradle to UserInputHandlingIntegrationTest

Looking at the history of UserInputHandlingIntegrationTest, some of them costs over 10 seconds to start,

which seems to be caused by lacking proper settings.gradle file. Now we add an empty one.

    • -0
    • +2
    ./tasks/userinput/UserInputHandlingIntegrationTest.groovy
Do not discard task execution failure when a `afterTask` handler fails. Instead, report both failures in the build outcome.

Also wrap `beforeTask` and `afterTask` failures in a contextual "task failed" exception.

    • -4
    • +4
    ./tasks/execution/ExecuteTaskBuildOperationTypeIntegrationTest.groovy
  1. … 11 more files in changeset.
Cleanup unused classloaders

Until now our classloader cache would only ever remove a classlaoder

if it was replaced by another one with the same ID. This works fine

if the daemon is used to build only one project. However, it becomes

a serious memory leak if the daemon builds many different projects.

This is a common scenario in Gradle integration tests, both in our

own code base and for users testing their plugins with TestKit.

In those cases the same daemon is used to build many different projects

and the JVM can eventually run out of metaspace.

This change adjusts the classloader cache so that it only retains

classloaders which were used either in the current build or the

previous build. All older unused classloaders are discarded to free

up memory.

    • -168
    • +1
    ./initialization/loadercache/ClassLoadersCachingIntegrationTest.groovy
  1. … 7 more files in changeset.
Move some console functional test coverage to `logging` to live with the other console test coverage. Also add more coverage for the reporting of the build result at the end of the build (actionable tasks, and so on).

    • -75
    • +0
    ./buildevents/AbstractBuildResultLoggerFunctionalTest.groovy
    • -25
    • +0
    ./buildevents/PlainConsoleBuildResultLoggerFunctionalTest.groovy
    • -25
    • +0
    ./buildevents/RichConsoleBuildResultLoggerFunctionalTest.groovy
    • -25
    • +0
    ./buildevents/VerboseConsoleBuildResultLoggerFunctionalTest.groovy
  1. … 8 more files in changeset.
Consistently show file changes for single root file in Gradle Enterprise (#7422)

* Snapshot SingletonFileTree as RegularFileSnapshot

- extract SingletonFileTree as interface

- rename SingletonFileTree to DefaultSingletonFileTree

- rename MapFileTree to GeneratedSingletonFileTree

- GeneratedSingletonFileTree only accepts one file (as its only used for one file so far)

- add coverage for archives

    • -0
    • +28
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 22 more files in changeset.
Calculate caching state outside of TaskOutputs

    • -1
    • +1
    ./tasks/TaskCacheabilityReasonIntegrationTest.groovy
  1. … 10 more files in changeset.
Stop ignoring tests and fix removed deprecated build scan property

    • -4
    • +2
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 7 more files in changeset.
Move ExecuteTaskBuildOperationType (#7374)

* Move ExecuteTaskBuildOperationType to org.gradle.api.internal.tasks.execution

* Remove redundant import

    • -1
    • +1
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
    • -0
    • +138
    ./tasks/execution/ExecuteTaskBuildOperationTypeIntegrationTest.groovy
  1. … 24 more files in changeset.
Do not use star-imports

    • -1
    • +6
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 1 more file in changeset.
Merge pull request #6921 from gradle/marc/issues/6296-ignore-annotation-processors-on-compile-classpath

Ignore annotation processors on compile classpath and forbid using -processorpath

    • -1
    • +1
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 2 more files in changeset.
Fix / ignore tests until build scan plugin 2.0 is out and used in AutoAppliedBuildScanPlugin

    • -22
    • +17
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 1 more file in changeset.
Track CompileOptions.annotationProcessorPath for up-to-date checking

    • -1
    • +5
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 3 more files in changeset.
Deprecate JavaCompile.effectiveAnnotationProcessorPath

    • -5
    • +1
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 3 more files in changeset.
Relax ordering of plugin application operation asserts

    • -19
    • +13
    ./plugins/ApplyPluginBuildOperationIntegrationTest.groovy
  1. … 1 more file in changeset.
Fix integration tests that relied on placeholder behavior

    • -0
    • +4
    ./plugins/ApplyPluginBuildOperationIntegrationTest.groovy
  1. … 7 more files in changeset.
Ignore `@Nested` properties when attaching output file `Property` instances to their producing task.

This is a work around to avoid the performance cost of `@Nested` property getters that throw exceptions when called immediately after the task is created. These issues will be addressed later and better support for output file `Property` properties attached to nested beans added.

    • -1
    • +1
    ./project/taskfactory/TaskPropertyNamingIntegrationTest.groovy
  1. … 12 more files in changeset.
Use separate reason for disabling caching

Also disable caching if any FileTree is used as output. We don't support DirectoryFileTrees as `@OutputDirectory` outputs either, so no reason to support them in plural outputs either.

    • -8
    • +16
    ./tasks/TaskCacheabilityReasonIntegrationTest.groovy
  1. … 5 more files in changeset.
Remove deprecated Class.newInstance() (#6496)

`Class.newInstance()` was deprecated in Java 9.

    • -1
    • +1
    ./tasks/SnapshotTaskInputsOperationIntegrationTest.groovy
  1. … 34 more files in changeset.
Enable caching for most plural outputs

When @OutputFiles or @OutputDirectories is used with an Iterable (instead of a Map), we previously disabled caching without much explanation. The original reason for this was that we expected a difference in cardinality of outputs between the task producing the output and the one consuming it. However, if we represent each entry in the collection as an indexed property, then unmatched cardinality will produce a different cache key anyway. Thus there's no need for this limitation.

    • -3
    • +5
    ./tasks/TaskCacheabilityReasonIntegrationTest.groovy
  1. … 6 more files in changeset.
Move test to live with other related tests.

    • -193
    • +0
    ./provider/ListPropertyIntegrationTest.groovy
  1. … 1 more file in changeset.
Replace internal `SourceDirectorySetFactory` with a method on public `ObjectFactory` service, to allow plugins to create instances of this type without resorting to using internal types.

    • -0
    • +11
    ./model/DefaultObjectFactoryIntegrationTest.groovy
  1. … 44 more files in changeset.
Reduce poll interval even further

There still seems to be some flakyness left.

    • -2
    • +2
    ./changedetection/CorruptedTaskHistoryIntegrationTest.groovy
Minor tweak to layout of prompt used to ask user to select an option from a list.

    • -3
    • +3
    ./tasks/userinput/UserInputHandlingIntegrationTest.groovy
  1. … 3 more files in changeset.
Allow the user to be prompted with a yes/no question that has a default response.

    • -0
    • +66
    ./tasks/userinput/UserInputHandlingIntegrationTest.groovy
  1. … 4 more files in changeset.
Change test class so that it doesn't run each test case using both daemon and no-daemon execution. Instead, the test runs with whichever execution the current test suite is using, and all of the execution modes will be covered at least once in various stages of CI.

    • -6
    • +0
    ./tasks/userinput/AbstractUserInputHandlerIntegrationTest.groovy
    • -20
    • +14
    ./tasks/userinput/UserInputHandlingIntegrationTest.groovy
Change the user prompt infrastructure to give the user some feedback when they enter a value that isn't valid for the question. Add some test coverage for user prompting.

    • -2
    • +2
    ./tasks/userinput/AbstractUserInputHandlerIntegrationTest.groovy
    • -124
    • +0
    ./tasks/userinput/DefaultBuildScanUserInputHandlerIntegrationTest.groovy
    • -0
    • +354
    ./tasks/userinput/UserInputHandlingIntegrationTest.groovy
  1. … 22 more files in changeset.