SettingsScriptExecutionIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Build buildSrc after applying the settings file (#10305)

Fixes #9094 and #5333

    • -3
    • +8
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 54 more files in changeset.
Update core tests

    • -3
    • +8
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 11 more files in changeset.
Revert "Reinstate "Let instant execution reuse classloaders when loading""

    • -3
    • +2
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 36 more files in changeset.
Revert "Revert "Let instant execution reuse classloaders when loading""

    • -2
    • +3
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 36 more files in changeset.
Revert "Let instant execution reuse classloaders when loading"

    • -3
    • +2
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 36 more files in changeset.
Merge branch 'master' into eskatos/ie/spike-reuse-classloaders

    • -1
    • +1
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 1 more file in changeset.
Merge branch 'master' into eskatos/ie/spike-reuse-classloaders

    • -1
    • +1
    ./SettingsScriptExecutionIntegrationTest.groovy
Remove assertion on the relationship between a Settings script class `ClassLoader` and its `buildscript.classLoader`

Given the relationship is not part of the settings script contract AND

the other assertions still hold, this should be safe.

The relationship between the `buildscript.classLoader` and the script

class classloader is not so simple to assert anymore given the new

`groovy-dsl:...` `ClassLoaderScope` and the way

`DefaultDeprecatedClassLoader` works.

    • -3
    • +3
    ./SettingsScriptExecutionIntegrationTest.groovy
Remove assertion on the relationship between a Settings script class `ClassLoader` and its `buildscript.classLoader`

Given the relationship is not part of the settings script contract AND

the other assertions still hold, this should be safe.

The relationship between the `buildscript.classLoader` and the script

class classloader is not so simple to assert anymore given the new

`groovy-dsl:...` `ClassLoaderScope` and the way

`DefaultDeprecatedClassLoader` works.

    • -3
    • +3
    ./SettingsScriptExecutionIntegrationTest.groovy
Remove assertion on the relationship between a Settings script class `ClassLoader` and its `buildscript.classLoader`

Given the relationship is not part of the settings script contract AND

the other assertions still hold, this should be safe.

The relationship between the `buildscript.classLoader` and the script

class classloader is not so simple to assert anymore given the new

`groovy-dsl:...` `ClassLoaderScope` and the way

`DefaultDeprecatedClassLoader` works.

    • -3
    • +3
    ./SettingsScriptExecutionIntegrationTest.groovy
Tweak deprecation message (add plural s)

    • -1
    • +1
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 8 more files in changeset.
WIP: Comment out failing assertions

    • -2
    • +3
    ./SettingsScriptExecutionIntegrationTest.groovy
WIP: Comment out failing assertions

    • -2
    • +3
    ./SettingsScriptExecutionIntegrationTest.groovy
WIP: Comment out failing assertions

    • -2
    • +3
    ./SettingsScriptExecutionIntegrationTest.groovy
Deprecating buildSrc usage in settings (#9898)

* Fix sanityCheck

* Handle deprecated use of resources from buildSrc in settings

* Address some feedback from PR review

* Simplify deprecation warning

* ensure only fired once for performance reasons

* tweak test coverage

* add proper test coverage

* use simplified deprecation warning

* ensure works with kotlin-ds;

* Fix caching of deprecated classloader

* use uniqye identifier and avoid same identifier as non deprecated loader

* fix more tests now expecting deprecation warning

* Make DeprecatedClassloader closeable

* Mention deprecation in upgrade guide

    • -0
    • +2
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 23 more files in changeset.
Fix caching of deprecated classloader

- use uniqye identifier and avoid same identifier as non deprecated loader

- fix more tests now expecting deprecation warning

    • -0
    • +2
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 1 more file in changeset.
Remove accidental dependency to from unit tests to internalIntegTesting

    • -2
    • +2
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 5 more files in changeset.
Use ExecFactory in context with a base directory for settings

Before 5.3, settings.gradle's exec/javaexec were shared with FileOperations,

which operated relative to rootDir.

In 5.3, we accidentally switched to a different file resolver, which broke some

people.

    • -0
    • +42
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 1 more file in changeset.
Use ExecFactory in context with a base directory for settings

Before 5.3, settings.gradle's exec/javaexec were shared with FileOperations,

which operated relative to rootDir.

In 5.3, we accidentally switched to a different file resolver, which broke some

people.

    • -0
    • +30
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 1 more file in changeset.
Use ExecFactory in context with a base directory for settings

Before 5.3, settings.gradle's exec/javaexec were shared with FileOperations,

which operated relative to rootDir.

In 5.3, we accidentally switched to a different file resolver, which broke some

people.

    • -0
    • +35
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 1 more file in changeset.
Nag users when enabling inactive feature flags

Related PRs: #6746 and #6948

    • -16
    • +52
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 7 more files in changeset.
Fix core usages of output test fixtures

    • -0
    • +1
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 9 more files in changeset.
Change int tests to use relevant fixture methods to express their expectations about the build log output.

    • -8
    • +2
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 28 more files in changeset.
Revert "Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release"

This reverts commit 506f8ce9d6dc1a81e8ff10575c512778ca2f382a.

    • -2
    • +4
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 199 more files in changeset.
Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release

    • -4
    • +2
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 199 more files in changeset.
Does not leak files anymore

    • -2
    • +0
    ./SettingsScriptExecutionIntegrationTest.groovy
Close buildscript ClassLoader to avoid file leak

    • -0
    • +4
    ./SettingsScriptExecutionIntegrationTest.groovy
Forcefully clean up test temp directories and mark tests for which it fails on Windows with @LeaksFileHandles so that they still pass.

+review REVIEW-5504

    • -0
    • +2
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 97 more files in changeset.
Moved some int tests to live in the core project.

    • -0
    • +78
    ./SettingsScriptExecutionIntegrationTest.groovy
  1. … 7 more files in changeset.