Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'release'

    • -1
    • +2
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 2 more files in changeset.
Make paths/names of included builds immutable (#10998)

Changes the “build path” for included builds to be determined at inclusion time based on the directory name, or a user supplied override. Previously, we tried to use the root project name defined in the included build. This caused a lot of complexity due to it not being known until part way through building the included build.

This change also disallows use of `buildSrc` as a project name, as it collides with the `buildSrc` nested build.

    • -0
    • +8
    ./AbstractCompositeBuildIntegrationTest.groovy
    • -7
    • +12
    ./CompositeBuildBuildSrcBuildOperationsIntegrationTest.groovy
    • -1
    • +1
    ./CompositeBuildBuildSrcIntegrationTest.groovy
    • -26
    • +26
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -1
    • +1
    ./CompositeBuildDeclaredSubstitutionsIntegrationTest.groovy
    • -1
    • +1
    ./CompositeBuildDependencyCapabilitiesResolveIntegrationTest.groovy
    • -1
    • +2
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
    • -22
    • +22
    ./CompositeBuildIdentityIntegrationTest.groovy
    • -7
    • +43
    ./CompositeBuildLookupIntegrationTest.groovy
    • -11
    • +7
    ./CompositeBuildNestingIntegrationTest.groovy
    • -7
    • +7
    ./CompositeBuildOperationsIntegrationTest.groovy
    • -6
    • +4
    ./IncludedBuildValidationIntegrationTest.groovy
  1. … 61 more files in changeset.
Ensure build paths are unique before using them

Also pushes uniqueness validation earlier

    • -3
    • +1
    ./CompositeBuildNestingIntegrationTest.groovy
    • -3
    • +1
    ./IncludedBuildValidationIntegrationTest.groovy
  1. … 6 more files in changeset.
Fix included build path naming and tests

    • -0
    • +8
    ./AbstractCompositeBuildIntegrationTest.groovy
    • -7
    • +12
    ./CompositeBuildBuildSrcBuildOperationsIntegrationTest.groovy
    • -1
    • +1
    ./CompositeBuildBuildSrcIntegrationTest.groovy
    • -26
    • +26
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -1
    • +1
    ./CompositeBuildDeclaredSubstitutionsIntegrationTest.groovy
    • -1
    • +1
    ./CompositeBuildDependencyCapabilitiesResolveIntegrationTest.groovy
    • -1
    • +2
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
    • -22
    • +22
    ./CompositeBuildIdentityIntegrationTest.groovy
    • -7
    • +43
    ./CompositeBuildLookupIntegrationTest.groovy
    • -9
    • +7
    ./CompositeBuildNestingIntegrationTest.groovy
    • -7
    • +7
    ./CompositeBuildOperationsIntegrationTest.groovy
    • -4
    • +4
    ./IncludedBuildValidationIntegrationTest.groovy
  1. … 6 more files in changeset.
Revert "Do not emit deprecation warning for deprecated 'force'"

This reverts commit 1db54192db6ef9af5c2fd6b227004eed9a27c07f.

    • -0
    • +1
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 10 more files in changeset.
Do not emit deprecation warning for deprecated 'force'

Nagging for this deprecation will only start with 6.1 to ease

the migration from 'force' to 'strictly'.

    • -1
    • +0
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 10 more files in changeset.
Do not emit deprecation warning for deprecated 'force'

Nagging for this deprecation will only start with 6.1 to ease

the migration from 'force' to 'strictly'.

    • -1
    • +0
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 10 more files in changeset.
Avoid more deprecated APIs

    • -8
    • +8
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 43 more files in changeset.
Avoid more deprecated APIs

    • -8
    • +8
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 34 more files in changeset.
Avoid more deprecated APIs

    • -8
    • +8
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 34 more files in changeset.
Avoid more deprecated APIs

    • -7
    • +7
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 28 more files in changeset.
Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
  1. … 1 more file in changeset.
Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -9
    • +9
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 3 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -10
    • +10
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 63 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -10
    • +10
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 55 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -10
    • +10
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 59 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -10
    • +10
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 62 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -10
    • +10
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 60 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -10
    • +10
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 60 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -10
    • +10
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 63 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -4
    • +4
    ./CompositeBuildConfigurationAttributesResolveIntegrationTest.groovy
    • -10
    • +10
    ./CompositeBuildDependencyArtifactsIntegrationTest.groovy
  1. … 63 more files in changeset.
Deprecate BuildListener#buildStarted and Gradle#buildStarted

Registering this callback within an init, settings or build script has

no effect as the build is already started. Those callback are also part

of an older API. Removing it from the public API will prevent further

user confusion.

    • -0
    • +1
    ./CompositeBuildEventsIntegrationTest.groovy
  1. … 13 more files in changeset.
Deprecate BuildListener#buildStarted and Gradle#buildStarted

Registering this callback within an init, settings or build script has

no effect as the build is already started. Those callback are also part

of an older API. Removing it from the public API will prevent further

user confusion.

    • -0
    • +1
    ./CompositeBuildEventsIntegrationTest.groovy
  1. … 12 more files in changeset.
Deprecate BuildListener#buildStarted and Gradle#buildStarted

Registering this callback within an init, settings or build script has

no effect as the build is already started. Those callback are also part

of an older API. Removing it from the public API will prevent further

user confusion.

    • -0
    • +1
    ./CompositeBuildEventsIntegrationTest.groovy
  1. … 13 more files in changeset.
Deprecate BuildListener#buildStarted and Gradle#buildStarted

Registering this callback within an init, settings or build script has

no effect as the build is already started. Those callback are also part

of an older API. Removing it from the public API will prevent further

user confusion.

    • -0
    • +1
    ./CompositeBuildEventsIntegrationTest.groovy
  1. … 13 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +1
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 12 more files in changeset.
Deprecated `force` on first-level dependencies

This commit deprecates using `force` in favor of using the

new "strictly" behavior. The "force" flag is still used

internally, in particular in case of virtual platforms, but

its usage should be discouraged as we have a solution which

is better now.

    • -0
    • +1
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 23 more files in changeset.
Deprecated `force` on first-level dependencies

This commit deprecates using `force` in favor of using the

new "strictly" behavior. The "force" flag is still used

internally, in particular in case of virtual platforms, but

its usage should be discouraged as we have a solution which

is better now.

    • -0
    • +1
    ./CompositeBuildDependencyGraphIntegrationTest.groovy
  1. … 23 more files in changeset.