Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Changed how pmd version is determined in the pmd task. Added integration test and rule set default values now is dependent on version

  1. … 4 more files in changeset.
polishing

    • -53
    • +57
    ./quality/FindBugsPluginTest.groovy
default Checkstyle.showViolations to true (REVIEW-549)

    • -0
    • +41
    ./quality/CheckstyleTest.groovy
  1. … 1 more file in changeset.
fixed checkstyle tests

renamed checkstyle.displayViolations to showViolations (similar to testLogging) polished Javadoc

  1. … 5 more files in changeset.
Merge commit '1220063b5310494912fed7ef'

Conflicts:

subprojects/code-quality/src/integTest/groovy/org/gradle/api/plugins/quality/CheckstylePluginIntegrationTest.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/Checkstyle.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CheckstyleExtension.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CheckstylePlugin.groovy

subprojects/code-quality/src/test/groovy/org/gradle/api/plugins/quality/CheckstylePluginTest.groovy

subprojects/docs/src/docs/dsl/org.gradle.api.plugins.quality.Checkstyle.xml

  1. … 5 more files in changeset.
polishing and test cleanup

    • -177
    • +4
    ./quality/FindBugsPluginTest.groovy
relocated some tests from FindBugsPluginTest to FindBugsSpecBuilderTest because they better fit there

    • -190
    • +186
    ./quality/FindBugsPluginTest.groovy
  1. … 1 more file in changeset.
polishing and test cleanup

    • -74
    • +113
    ./quality/FindBugsPluginTest.groovy
  1. … 4 more files in changeset.
fixed some flawed (though not failing) spock specs

- moved interactions out of when-blocks (don't belong there)

- moved exception conditions out of expect-blocks (don't belong there)

- groovyfied some code

  1. … 8 more files in changeset.
Adding additional Findbugs attributes: include, exclude, visitors, omitVisitors, effort, reportLevel

    • -0
    • +182
    ./quality/FindBugsPluginTest.groovy
  1. … 5 more files in changeset.
GRADLE-2167: Fix broken CI build; Introduce FindBugsExecuter for dealing with Findbugs API and delay FindBugs API classloading when task fb worker process is executed.

    • -0
    • +55
    ./quality/internal/findbugs/FindBugsExecuterTest.groovy
  1. … 3 more files in changeset.
GRADLE-2167: Drive Findbugs api directly. - Replace fb invocation via reflection by direct invocation. - Add needed fb related libraries via "provided" configuration to codeQuality project. - Refactor findbugs result to use values directly from findbugs2 instance. - MissingClassesCount does not cause failing fb task; use same defaults here as the prior fb ant task.

    • -0
    • +106
    ./quality/FindBugsTest.groovy
  1. … 4 more files in changeset.
replaced usage of SourceTask#defaultSource in Pmd- and Findbugs-Plugin

  1. … 2 more files in changeset.
replaced usage of SourceTask#defaultSource in Code-quality;CodeNarc and CheckstylePlugin

    • -8
    • +8
    ./quality/CodeQualityPluginTest.groovy
  1. … 2 more files in changeset.
JDepend task is not a VerificationTask.

  1. … 2 more files in changeset.
- Removed Checkstyle.reportFile. It wasn't present in m7, so we don't need to keep it around. - Deprecated Codenarc.reportFormat and reportFile.

  1. … 3 more files in changeset.
Update jdepends plugin to use new reporting infrastructure.

    • -11
    • +27
    ./quality/JDependPluginTest.groovy
  1. … 5 more files in changeset.
Updated the findbugs plugin to use the new reporting infrastructure

    • -11
    • +27
    ./quality/FindBugsPluginTest.groovy
  1. … 5 more files in changeset.
Updated the Pmd plugin to use the new reporting infrastructure.

  1. … 6 more files in changeset.
Fixed unused imports.

Changed the code quality plugins so that they do not apply the corresponding base plugin.

    • -10
    • +9
    ./quality/CheckstylePluginTest.groovy
    • -1
    • +35
    ./quality/CodeQualityPluginTest.groovy
  1. … 7 more files in changeset.
Changed the code quality plugins to all use the same pattern as the codenarc plugin for setting default values for tasks.

    • -0
    • +33
    ./quality/CheckstylePluginTest.groovy
    • -0
    • +32
    ./quality/FindBugsPluginTest.groovy
  1. … 4 more files in changeset.
Extracted a bunch of stuff from code quality plugins into a common super class.

  1. … 6 more files in changeset.
- Changed the CodeNarc plugin so it works more like the other code quality plugins. - Removed CodeQualityExtension.project, and checkTasks.

  1. … 11 more files in changeset.
Changed CodeQualityPlugin so that it does not (indirectly) apply the java-base and groovy-base plugins.

    • -0
    • +9
    ./quality/CodeQualityPluginTest.groovy
  1. … 1 more file in changeset.
Some specific test for the new reporting DSL

    • -0
    • +15
    ./quality/CodeNarcPluginTest.groovy
  1. … 1 more file in changeset.
GRADLE-1656 - added displayViolations attribute to allow suppression of Checkstyle violations on the console

    • -8
    • +22
    ./quality/CheckstylePluginTest.groovy
  1. … 5 more files in changeset.
changed CodeQualityExtension.ignoreFailures from Boolean to boolean (now that convention mapping works for primitive types)

  1. … 1 more file in changeset.
generalized CodeNarc plugin

- only applies reporting-base instead of groovy-base plugin

- also configures tasks not added by the plugin (as good as it can)

Note: If this is to stay, similar changes should be made to all other code quality plugins. Besides, it might be worthwile to make the plugins add a 'codeQuality' lifecycle task.

    • -26
    • +76
    ./quality/CodeNarcPluginTest.groovy
  1. … 6 more files in changeset.