Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Do not resolve classes dirs as a file tree

This causes us to include resources in a way that causes FindBugs to

produce an annoying error message

  1. … 4 more files in changeset.
Use @InputDirectory for configDir in Checkstyle

+review REVIEW-6526

  1. … 1 more file in changeset.
Rename checkstyleConfigDir to configDir to be consistent with the other properties

+review REVIEW-6526

  1. … 6 more files in changeset.
Add test coverage for configDir property

+review REVIEW-6526

    • -3
    • +18
    ./quality/CheckstylePluginTest.groovy
  1. … 1 more file in changeset.
Add overrides of Spock's with() methods for better editor support.

  1. … 3 more files in changeset.
Use separate output directories for all JVM languages

- Introduce an outputDir on SourceDirectorySet

- Default output directory is now `build/classes/<source directory set name>/<source set name>`

- Example: Java compilation goes to build/classes/java/main instead of build/classes/main

- Adapt JDepend, FindBugs, Test and ValidateTaskProperties tasks to handle multiple class directories

- Deprecate setClassesDir/getClassesDir on SourceSetOutput

- Calling setClassesDir restores old behavior (shared output directory)

- Introduce addClassesDir and getClassesDirs on SourceSetOutput

- OSGi plugin needs a single classes directory, so introduce 'osgiClasses' task that syncs all classes to a single directory

Most of the changes to integration tests are find classes in their new location. Helper methods in AbstractIntegrationSpec

can locate class files vs hardcoding a path.

Squashed commit of sg-split-jvm-classes branch for REVIEW-6502

  1. … 119 more files in changeset.
Renders a deprecation warning to the console for ConfigurableReport.setDestination(Object) (#1798)

Use the method ConfigurableReport.setDestination(File) in Gradle's tests to avoid rendering the deprecation message.

  1. … 8 more files in changeset.
Remove our custom provided configuration in favor of compileOnly

- Remove FindBugsExecuterTest since it relies on a FindBugs type and doesn't add much value

- Move static constants from ZincScalaCompilerFactory into ZincScalaCompilerUtil so tests don't rely on Zinc/Scala internals

- Replace uses of 'provided' with 'compileOnly'

- Move FindBugs and Zinc dependencies into gradle/dependencies.gradle

  1. … 9 more files in changeset.
GRADLE-2888 Set default value for Checkstyle maxWarnings to Integer.MAX_VALUE.

  1. … 2 more files in changeset.
GRADLE-2888 Added maxWarnings option to Checkstyle DSL. This option sets the maximum number of warnings that are tolerated before breaking the build or setting the invoked ANT task failure property.

  1. … 7 more files in changeset.
Fixup CheckstylePluginClasspathIntegrationTest for #863

- Fix assertion in Spock Test

- Fix build config

- Fix example code for test

- Miscellaneous cleanup to CheckstylePluginTest

Issue: #855

  1. … 1 more file in changeset.
Fix test to assert new behavior

GRADLE-2888 Renamed new 'maxAllowedViolations' property to 'maxErrors' so as to match the already existing Checkstyle property, and therefore be more intuitive to Checkstyle users.

  1. … 7 more files in changeset.
Added maxAllowedViolations option to Checkstyle DSL. This option sets the maximum number of code violations that are tolerated before breaking the build or setting the invoked ANT task failure property.

  1. … 7 more files in changeset.
Remove deprecated methods on TestUtil (#672)

In order to use project builder correctly without having

leaking files on windows it is necessary to initialize

the test fixture for NativeServices and clean up

the test directory after building.

AbstractProjectBuilderSpec provides a nice base class

for Groovy tests.

I removed the deprecated methods since using them leads

to files lying around. Migrating all the usages to the "new"

way ensures it is used correctly.

    • -11
    • +2
    ./quality/CodeNarcPluginTest.groovy
    • -11
    • +2
    ./quality/FindBugsPluginTest.groovy
  1. … 94 more files in changeset.
Merge pull request #649 from adangel/pmd-auxclasspath

Add sourceSet.output to PMD classpath

Stylistic code improvements

  1. … 1 more file in changeset.
Removed some Java 6 specific behaviour that is no longer required.

  1. … 5 more files in changeset.
Add sourceSet.output to PMD classpath - For the typeresolution feature in PMD it is necessary, that the compiled classes of the project itself are on the "auxclasspath", too.

  1. … 3 more files in changeset.
Changed unit tests to use Project or ProjectInternal instead of the implementation classes.

  1. … 29 more files in changeset.
Fix some tests that were leaking file handles

    • -12
    • +2
    ./quality/CheckstylePluginTest.groovy
  1. … 18 more files in changeset.
Stricter Regex in FindBugsClasspathValidator

- Added contributor to release notes

- Moved test to existing test class

Fixes GRADLE-3457

#642

+review REVIEW-5994

  1. … 1 more file in changeset.
More strict Regex in FindBugsClasspathVaildator (#642)

- The old regex "findbugs-(.*)\\.jar" will match any jars start with findbugs-ANYSTRING.jar

Classpath like this ["findbugs-annotations-3.0.0.jar", "findbugs-3.0.0.jar",

"findbugs-jFormatString-3.0.0.jar"] will match first in the list then throw GradleException

Make the regex more strict to match only findbugs-3.0.0.jar

    • -0
    • +43
    ./quality/internal/findbugs/FindBugsVersionValidatorTest.groovy
  1. … 1 more file in changeset.
Fix many of the code-quality test file leaks.

- There is still one which isn't clearly leaking filehandles for the

same reasons as these four were. That will require further

investigation to fix.

Don't use common parent class for now

    • -2
    • +12
    ./quality/CheckstylePluginTest.groovy
  1. … 12 more files in changeset.
Introduce test fixture of tests using ProjectBuilder

Automatically uses and cleans up temporary project directory.

  1. … 13 more files in changeset.
Convert codeQuality plugins and extensions to Java

Leaving only tasks in Groovy

+review REVIEW-5933

    • -132
    • +6
    ./quality/CodeNarcPluginTest.groovy
  1. … 23 more files in changeset.
Simplified findbugs worker implementation and adjusted int test expectations for improvements to failure reporting.

  1. … 7 more files in changeset.
PMD: Default rule is now java-basic since the default version of PMD is > 5

  1. … 2 more files in changeset.
Add support for generating HTML reports to the Checkstyle plugin

The committed XSL file was taken from [1].

[1] https://svn.apache.org/repos/asf/hive/trunk/checkstyle/checkstyle-noframes-sorted.xsl

  1. … 6 more files in changeset.