Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename some of the factory methods for creating TextResource's

- resources.text -> fileText, resources.archiveText -> archiveEntryText

  1. … 10 more files in changeset.
Introduce Pmd(Extension)#rulesetConfig

- new way to configure custom rule set based on TextResource abstraction

- may add support for multiple rule sets in the future, in order to match capabilities of ruleSetFiles property

  1. … 6 more files in changeset.
Introduce Codenarc(Extension)#config

- based on new TextResource abstraction

- set to replace #configFile

  1. … 5 more files in changeset.
Introduce FindBugs(Extension)#includeFilterConfig and #excludeFilterConfig

- based on new TextResource abstraction

- set to replace #includeFilter and #excludeFilter

    • -6
    • +16
    ./quality/FindBugsPluginTest.groovy
  1. … 5 more files in changeset.
Implement Checkstyle(Extension)#configFile in terms of new Checkstyle(Extension)#config

- cleaner approach

  1. … 3 more files in changeset.
Fix failing tests

Enable checkstyle task/extension to be configured using a TextResource

- allows to source configuration from resources other than a file

  1. … 3 more files in changeset.
Added validation for FindBugs classpath depending on the currently used java version.

    • -0
    • +63
    ./quality/internal/findbugs/FindBugsClasspathValidatorTest.groovy
  1. … 2 more files in changeset.
Test fixes now that properties are not defined on assignment.

  1. … 4 more files in changeset.
Removed deprecated properties from the Checkstyle and CodeNarc task types.

  1. … 3 more files in changeset.
Removed the deprecated 'code-quality' plugin and associated classes.

    • -159
    • +0
    ./quality/CodeQualityPluginTest.groovy
  1. … 12 more files in changeset.
Bust up Matchers to detangle the project dependencies.

Also solves some building in IDEA issues.

    • -10
    • +11
    ./quality/CodeQualityPluginTest.groovy
  1. … 24 more files in changeset.
renamed HelperUtil to TestUtil (REVIEW-1626)

    • -2
    • +2
    ./quality/CodeQualityPluginTest.groovy
  1. … 140 more files in changeset.
Merge branch 'codenarc-max-violations' of git://github.com/dstine/gradle into pull-request-144

    • -0
    • +21
    ./quality/CodeNarcPluginTest.groovy
Changed DefaultTaskContainer, DefaultSourceSetContainer and DefaultConfigurationContainer to nag about the use of deprecated add() methods.

    • -2
    • +2
    ./quality/CodeQualityPluginTest.groovy
  1. … 31 more files in changeset.
deprecated SourceSetContainer/ConfigurationContainer.add methods in favor of create methods

- changed usages of add methods to create methods

- ported DefaultScriptHandlerTest to spock spec

    • -2
    • +2
    ./quality/CodeQualityPluginTest.groovy
  1. … 31 more files in changeset.
expose maxPriorityViolations settings in the CodeNarc plugin (GRADLE-1742)

    • -0
    • +21
    ./quality/CodeNarcPluginTest.groovy
  1. … 3 more files in changeset.
fixed GRADLE-2706: With Gradle 1.5 - PMD applying basic rules even when they are not included in our rule set files

- moved ruleSets default back from Pmd to PmdExtension

- task adapts default if necessary (PMD >= 5.0)

- added some integration tests

  1. … 6 more files in changeset.
REVIEW-1517: some cleanup / test coverage on the pmd targetjdk support.

  1. … 1 more file in changeset.
REVIEW-1499: Introduce TargetJdk Enum representing possible values for pmds targetjdk.

    • -0
    • +108
    ./quality/TargetJdkSpec.groovy
  1. … 4 more files in changeset.
Changed how pmd version is determined in the pmd task. Added integration test and rule set default values now is dependent on version

  1. … 4 more files in changeset.
polishing

    • -53
    • +57
    ./quality/FindBugsPluginTest.groovy
default Checkstyle.showViolations to true (REVIEW-549)

    • -0
    • +41
    ./quality/CheckstyleTest.groovy
  1. … 1 more file in changeset.
fixed checkstyle tests

renamed checkstyle.displayViolations to showViolations (similar to testLogging) polished Javadoc

  1. … 5 more files in changeset.
Merge commit '1220063b5310494912fed7ef'

Conflicts:

subprojects/code-quality/src/integTest/groovy/org/gradle/api/plugins/quality/CheckstylePluginIntegrationTest.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/Checkstyle.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CheckstyleExtension.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CheckstylePlugin.groovy

subprojects/code-quality/src/test/groovy/org/gradle/api/plugins/quality/CheckstylePluginTest.groovy

subprojects/docs/src/docs/dsl/org.gradle.api.plugins.quality.Checkstyle.xml

  1. … 5 more files in changeset.
polishing and test cleanup

    • -177
    • +4
    ./quality/FindBugsPluginTest.groovy
relocated some tests from FindBugsPluginTest to FindBugsSpecBuilderTest because they better fit there

    • -190
    • +186
    ./quality/FindBugsPluginTest.groovy
  1. … 1 more file in changeset.
polishing and test cleanup

    • -74
    • +113
    ./quality/FindBugsPluginTest.groovy
  1. … 4 more files in changeset.
fixed some flawed (though not failing) spock specs

- moved interactions out of when-blocks (don't belong there)

- moved exception conditions out of expect-blocks (don't belong there)

- groovyfied some code

  1. … 8 more files in changeset.