CodeNarcPluginTest.groovy

Remove ConfigurableReport.setDestination(Object)

Resolves #6298.

Remove deprecated methods on TestUtil (#672)

In order to use project builder correctly without having

leaking files on windows it is necessary to initialize

the test fixture for NativeServices and clean up

the test directory after building.

AbstractProjectBuilderSpec provides a nice base class

for Groovy tests.

I removed the deprecated methods since using them leads

to files lying around. Migrating all the usages to the "new"

way ensures it is used correctly.

Changed unit tests to use Project or ProjectInternal instead of the implementation classes.

Fix many of the code-quality test file leaks.

- There is still one which isn't clearly leaking filehandles for the

same reasons as these four were. That will require further

investigation to fix.

Convert codeQuality plugins and extensions to Java

Leaving only tasks in Groovy

+review REVIEW-5933

Deprecate PluginContainer.apply(Class) and PluginContainer.apply(String)

+review REVIEW-5239

Add test coverage for legacy configuration properties of code quality extensions/tasks

Polish code that checks contents of file collections (REVIEW-5217)

Introduce TextResourceFactory

- cleaner API/DSL for creating text resources

- more modular (factory methods no longer declared in ResourceHandler)

Introduce Codenarc(Extension)#config

- based on new TextResource abstraction

- set to replace #configFile

Test fixes now that properties are not defined on assignment.

Removed deprecated properties from the Checkstyle and CodeNarc task types.

Bust up Matchers to detangle the project dependencies.

Also solves some building in IDEA issues.

renamed HelperUtil to TestUtil (REVIEW-1626)

Merge branch 'codenarc-max-violations' of git://github.com/dstine/gradle into pull-request-144

Changed DefaultTaskContainer, DefaultSourceSetContainer and DefaultConfigurationContainer to nag about the use of deprecated add() methods.

expose maxPriorityViolations settings in the CodeNarc plugin (GRADLE-1742)

replaced usage of SourceTask#defaultSource in Code-quality;CodeNarc and CheckstylePlugin

Fixed unused imports.

Extracted a bunch of stuff from code quality plugins into a common super class.

Some specific test for the new reporting DSL

changed CodeQualityExtension.ignoreFailures from Boolean to boolean (now that convention mapping works for primitive types)

generalized CodeNarc plugin

- only applies reporting-base instead of groovy-base plugin

- also configures tasks not added by the plugin (as good as it can)

Note: If this is to stay, similar changes should be made to all other code quality plugins. Besides, it might be worthwile to make the plugins add a 'codeQuality' lifecycle task.

consistent capitalization of "classpath" throughout code quality plugins

reworked codenarc plugin

notably:

- turn into its own plugin

- introduce checkstyle configuration (don't hardcode the codenarc version)

- configure via extension object

- improve tests and move them into code-quality project

- implement in groovy