Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Address review items for Checkstyle configDir

+review REVIEW-6526

  1. … 1 more file in changeset.
Rename checkstyleConfigDir to configDir to be consistent with the other properties

+review REVIEW-6526

  1. … 6 more files in changeset.
Use config_loc instead of our custom checkstyleConfigDir

+review REVIEW-6526

  1. … 5 more files in changeset.
Provide alias to config_loc

This is commonly used by people and is supported in the Eclipse/IntelliJ plugins

+review REVIEW-6526

Provide checkstyleConfigDir for checkstyle.xml configs

+review REVIEW-6526

  1. … 7 more files in changeset.
Use separate output directories for all JVM languages

- Introduce an outputDir on SourceDirectorySet

- Default output directory is now `build/classes/<source directory set name>/<source set name>`

- Example: Java compilation goes to build/classes/java/main instead of build/classes/main

- Adapt JDepend, FindBugs, Test and ValidateTaskProperties tasks to handle multiple class directories

- Deprecate setClassesDir/getClassesDir on SourceSetOutput

- Calling setClassesDir restores old behavior (shared output directory)

- Introduce addClassesDir and getClassesDirs on SourceSetOutput

- OSGi plugin needs a single classes directory, so introduce 'osgiClasses' task that syncs all classes to a single directory

Most of the changes to integration tests are find classes in their new location. Helper methods in AbstractIntegrationSpec

can locate class files vs hardcoding a path.

Squashed commit of sg-split-jvm-classes branch for REVIEW-6502

    • -7
    • +10
    ./findbugs/FindBugsSpecBuilder.java
  1. … 118 more files in changeset.
GRADLE-2888 Added maxWarnings option to Checkstyle DSL. This option sets the maximum number of warnings that are tolerated before breaking the build or setting the invoked ANT task failure property.

  1. … 8 more files in changeset.
GRADLE-2888 Renamed new 'maxAllowedViolations' property to 'maxErrors' so as to match the already existing Checkstyle property, and therefore be more intuitive to Checkstyle users.

  1. … 8 more files in changeset.
Added maxAllowedViolations option to Checkstyle DSL. This option sets the maximum number of code violations that are tolerated before breaking the build or setting the invoked ANT task failure property.

  1. … 8 more files in changeset.
Polishing

+review REVIEW-6132

  1. … 1 more file in changeset.
GRADLE-3490: Delete temporary Checkstyle XML report

Signed-off-by: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>

  1. … 1 more file in changeset.
GRADLE-3490: Checkstyle output when XML report is disabled

Generate the XML report in a temporary location when it is

explictly disabled. We still need to generate it, as it is

used to generate the HTML report.

Enable and update the corresponding test.

Signed-off-by: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>

  1. … 1 more file in changeset.
Revert "GRADLE-3490: Build output when Checkstyle XML report is disabled"

This reverts commit 0aa085bf2e8781bbc38e84b4a9f0800d49a69a1b.

  1. … 1 more file in changeset.
GRADLE-3490: Build output when Checkstyle XML report is disabled

Move the XML report from build/reports to build/tmp when it is

explicitly not requested as build output.

Also update the test and enable it.

Signed-off-by: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>

  1. … 1 more file in changeset.
Fix compatibility with Pmd<5

+review REVIEW-6081

Migrate `Pmd` task to Java

The task still uses an internal class written in Groovy to invoke an isolated Ant builder.

+review REVIEW-6081

    • -0
    • +110
    ./PmdInvoker.groovy
  1. … 3 more files in changeset.
Migrate `JDepend` from Groovy to Java

The task still uses an internal class written in Groovy to invoke an isolated Ant builder.

+review REVIEW-6081

    • -0
    • +49
    ./JDependInvoker.groovy
  1. … 3 more files in changeset.
Migrate `CodeNarc` task to Java

The task still uses an internal class written in Groovy to invoke an isolated Ant builder.

+review REVIEW-6081

    • -0
    • +76
    ./CodeNarcInvoker.groovy
  1. … 3 more files in changeset.
Convert `Checkstyle` task to Java

This commit converts the `Checkstyle` task to Java, but keeps the internal call mechanism, which is using `IsolatedAntBuilder`,

in Groovy, for practical reasons.

+review REVIEW-6081

    • -0
    • +88
    ./CheckstyleInvoker.groovy
  1. … 2 more files in changeset.
Removed some Java 6 specific behaviour that is no longer required.

    • -11
    • +0
    ./findbugs/FindBugsClasspathValidator.java
  1. … 5 more files in changeset.
Merge remote-tracking branch 'origin/release'

* origin/release:

Restored a constructor for an internal type, for backwards compatibility. The constructor is deprecated and will be removed in 3.0.

Restored some methods that previously leaked onto all decorated types. These are now deprecated and will be removed in 3.0.

Restored some behaviour in the `MavenDeployer.repository { ... } DSL that changed in a breaking way when the implementation of this interface was changed from Groovy to Java.

Adds four new build splits for speed.

Add release notes about API changes

Make DSL doc generation happy

Appease checkstyle

Restore binary compatibility with AntGroovydoc

Remove type bounds so we generate the same method signatures again

Add missing methods from Groovy -> Java conversion

Restore old Object only constructors

Remove setProperty from formerly-Groovy tasks

Improve integration with docs.gradle.org wrt CSS styles.

Review items for Manifest API fix

Remove unnecessary FileResolver injection in Ear

Restore lost access levels in codeQuality

Restore lost access levels in Jacoco plugin

Restore lost access level on EclipseClasspath.noExportConfiguration

Mention breaking change to RhinoWorkerHandleFactory

  1. … 25 more files in changeset.
Remove type bounds so we generate the same method signatures again

Add missing annotation to task property

+review REVIEW-5932

Annotate report task inputs and outputs

Added some more annotations. Also made sure to use interfaces instead of

concrete classes when referring to `ReportContainer` properties. This

allows better task property validation, as implementation details are

not mixed in.

+review REVIEW-5932

    • -0
    • +30
    ./FindBugsReportsInternal.java
  1. … 22 more files in changeset.
More strict Regex in FindBugsClasspathVaildator (#642)

- The old regex "findbugs-(.*)\\.jar" will match any jars start with findbugs-ANYSTRING.jar

Classpath like this ["findbugs-annotations-3.0.0.jar", "findbugs-3.0.0.jar",

"findbugs-jFormatString-3.0.0.jar"] will match first in the list then throw GradleException

Make the regex more strict to match only findbugs-3.0.0.jar

    • -1
    • +1
    ./findbugs/FindBugsClasspathValidator.java
  1. … 1 more file in changeset.
Add missing `GroovyObjectSupport`

+review REVIEW-5980

  1. … 9 more files in changeset.
Review items for codeQuality and jacoco Java conversion

+review REVIEW-5933

  1. … 5 more files in changeset.
CompileStatic subprojects/code-quality

Plus some Groovy to Java conversions

+review REVIEW-5933

    • -130
    • +0
    ./AbstractCodeQualityPlugin.groovy
    • -0
    • +198
    ./AbstractCodeQualityPlugin.java
  1. … 10 more files in changeset.
Reduce fixed cost of applying the Jacoco plugin

+review REVIEW-5933

    • -42
    • +0
    ./findbugs/FindBugsWorkerManager.groovy
    • -0
    • +44
    ./findbugs/FindBugsWorkerManager.java
  1. … 7 more files in changeset.
Reduce fixed cost of applying code quality plugins

First step: use @CompileStatic in all involved Groovy classes

+review REVIEW-5933

    • -1
    • +3
    ./findbugs/FindBugsWorkerManager.groovy
  1. … 16 more files in changeset.