Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add an option to FindBugs to disable analysis progress (#2181)

This fixes https://github.com/gradle/gradle/issues/1646,

https://github.com/gradle/gradle/issues/1307,

https://github.com/gradle/gradle/issues/1756

It has been reported that FindBugs plugin will always print analysis

progress to standard output no matter what the configuration is. It is

because '-progress' command line option is always activated when

staring FindBugs in FindBugsSpecBuilder. This commit add an option to

FindBugs plugin named 'showProgress' to control it. If set to false,

'-progress' will not be passed to FindBugs.

  1. … 7 more files in changeset.
Use separate output directories for all JVM languages

- Introduce an outputDir on SourceDirectorySet

- Default output directory is now `build/classes/<source directory set name>/<source set name>`

- Example: Java compilation goes to build/classes/java/main instead of build/classes/main

- Adapt JDepend, FindBugs, Test and ValidateTaskProperties tasks to handle multiple class directories

- Deprecate setClassesDir/getClassesDir on SourceSetOutput

- Calling setClassesDir restores old behavior (shared output directory)

- Introduce addClassesDir and getClassesDirs on SourceSetOutput

- OSGi plugin needs a single classes directory, so introduce 'osgiClasses' task that syncs all classes to a single directory

Most of the changes to integration tests are find classes in their new location. Helper methods in AbstractIntegrationSpec

can locate class files vs hardcoding a path.

Squashed commit of sg-split-jvm-classes branch for REVIEW-6502

  1. … 119 more files in changeset.
Removed some Java 6 specific behaviour that is no longer required.

  1. … 5 more files in changeset.
More strict Regex in FindBugsClasspathVaildator (#642)

- The old regex "findbugs-(.*)\\.jar" will match any jars start with findbugs-ANYSTRING.jar

Classpath like this ["findbugs-annotations-3.0.0.jar", "findbugs-3.0.0.jar",

"findbugs-jFormatString-3.0.0.jar"] will match first in the list then throw GradleException

Make the regex more strict to match only findbugs-3.0.0.jar

  1. … 1 more file in changeset.
Reduce fixed cost of applying the Jacoco plugin

+review REVIEW-5933

    • -0
    • +44
    ./FindBugsWorkerManager.java
  1. … 7 more files in changeset.
Reduce fixed cost of applying code quality plugins

First step: use @CompileStatic in all involved Groovy classes

+review REVIEW-5933

  1. … 17 more files in changeset.
Move the CustomizableHtmlReport over to reporting.

+review REVIEW-5862

  1. … 10 more files in changeset.
Add missing Report related types to the documentation

- Rename CustomizableHTMLReport -> CustomizableHtmlReport to match other class names

- Split all reporting related types into a separate section to keep the core list short

  1. … 15 more files in changeset.
Introduced a multi-request worker, which represents a worker process that handles zero or more requests.

  1. … 24 more files in changeset.
Moved worker process classes into their own package.

  1. … 92 more files in changeset.
Renamed an interface.

  1. … 10 more files in changeset.
Simplified findbugs worker implementation and adjusted int test expectations for improvements to failure reporting.

    • -21
    • +0
    ./FindBugsWorkerClientProtocol.java
  1. … 2 more files in changeset.
Changed the API for creating worker processes, so that the worker action must always be supplied.

Also introduced a couple of interfaces to present the API.

  1. … 31 more files in changeset.
Cleanup the merge of pull requst #568

+review REVIEW-5862

  1. … 1 more file in changeset.
Merge Pull Request #568 for stylesheet support in FindBugs and CheckStyle

+review REVIEW-5862

  1. … 16 more files in changeset.
Removed empty constructors.

  1. … 1 more file in changeset.
Switch the stylesheet to a TextResource.

Reference:

- https://github.com/gradle/gradle/pull/568#discussion_r54162495

  1. … 6 more files in changeset.
Merge CheckstyleHtmlReport and FindBugsHtmlReport into a common CustomizableHTMLReport.

  1. … 10 more files in changeset.
Allows the FindBugs HTML report to be generated with a custom stylesheet.

    • -0
    • +41
    ./FindBugsHtmlReportImpl.java
  1. … 6 more files in changeset.
`coll.toArray(new T[coll.size()])` to `coll.toArray(new T[0])`

Original structural search missed two non conforming cases.

+review REVIEW-5804

  1. … 1 more file in changeset.
clean up find bugs tests for extra args

  1. … 2 more files in changeset.
  1. … 5 more files in changeset.
Add extraArgs setting to FindBugs task and extension

  1. … 5 more files in changeset.
GRADLE-3212: FindBugs plugin should expose property for setting baseline bugs file.

  1. … 6 more files in changeset.
GRADLE-3214 FindBugs crash / build hanging

Ensured that FindBugs client catches all kinds of Throwables. This fixes the problem of stalled build when FindBugs crashes.

  1. … 1 more file in changeset.
Fixed samples integration test after bumping Findbugs version. Minor fix to the exception message.

  1. … 1 more file in changeset.
Tidy up in the integration tests for FindBugs. Tweaked the exception messages.

  1. … 1 more file in changeset.
Added validation for FindBugs classpath depending on the currently used java version.

    • -0
    • +70
    ./FindBugsClasspathValidator.java
  1. … 2 more files in changeset.
Configured FindBugs worker process name.

Changed the contract of ObjectConnection so that connect() must be called finish establishing the connection, and all configuration must complete before connect() is called.

  1. … 27 more files in changeset.