Checkstyle.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Convert `Checkstyle` task to Java

This commit converts the `Checkstyle` task to Java, but keeps the internal call mechanism, which is using `IsolatedAntBuilder`,

in Groovy, for practical reasons.

+review REVIEW-6081

  1. … 2 more files in changeset.
Revert "Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release"

This reverts commit 506f8ce9d6dc1a81e8ff10575c512778ca2f382a.

  1. … 199 more files in changeset.
Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release

  1. … 199 more files in changeset.
Fix property type for `Checkstyle.showViolations`

+review REVIEW-5932

Annotate more task properties

Part of this is fixing missing annotations. Part is applying the new

`@Console` and `@Internal` annotations where appropriate.

+review REVIEW-5932

  1. … 80 more files in changeset.
Revert "Annotate more task properties"

This reverts commit 4b32689375b46bb01ace46d5255118683c7c13ed.

  1. … 68 more files in changeset.
Annotate more task properties

Part of this is fixing missing annotations. Part is applying the new

`@Console` and `@Internal` annotations where appropriate.

+review REVIEW-5932

  1. … 68 more files in changeset.
Annotate report task inputs and outputs

Added some more annotations. Also made sure to use interfaces instead of

concrete classes when referring to `ReportContainer` properties. This

allows better task property validation, as implementation details are

not mixed in.

+review REVIEW-5932

  1. … 23 more files in changeset.
Fix Checkstyle

+review REVIEW-5933

CompileStatic subprojects/code-quality

Plus some Groovy to Java conversions

+review REVIEW-5933

  1. … 11 more files in changeset.
Reduce fixed cost of applying code quality plugins

First step: use @CompileStatic in all involved Groovy classes

+review REVIEW-5933

  1. … 17 more files in changeset.
Moved internal logging classes from 'core' to 'logging' project.

  1. … 418 more files in changeset.
Merge Pull Request #568 for stylesheet support in FindBugs and CheckStyle

+review REVIEW-5862

  1. … 17 more files in changeset.
Switch the stylesheet to a TextResource.

Reference:

- https://github.com/gradle/gradle/pull/568#discussion_r54162495

  1. … 6 more files in changeset.
Allows the custom stylesheet to be in the classpath for the Checkstyle HTML report.

  1. … 1 more file in changeset.
Allows the Checkstyle HTML report to be generated with a custom stylesheet.

  1. … 6 more files in changeset.
Elaborate on CheckstyleReports javadoc and make HTML the preferred user viewed report.

+ release notes.

+review REVIEW-5675

  1. … 2 more files in changeset.
Add support for generating HTML reports to the Checkstyle plugin

The committed XSL file was taken from [1].

[1] https://svn.apache.org/repos/asf/hive/trunk/checkstyle/checkstyle-noframes-sorted.xsl

  1. … 7 more files in changeset.
Using CNFE to use correct ant task

  1. … 3 more files in changeset.
Allowing gradle to use checkstyle 6.8+

Fixes: https://issues.gradle.org/browse/GRADLE-3314

  1. … 3 more files in changeset.
Fixed resources.text() problem

All instances where I've applied the fix call for coverage. Bugs like to cluster so let's get this covered. I needed to fix this otherwise I cannot use master Gradle with my builds. Not sure whether this problem also exists in the release branch.

  1. … 3 more files in changeset.
Fixed resources.text() problem

All instances where I've applied the fix call for coverage. Bugs like to cluster so let's get this covered. I needed to fix this otherwise I cannot use master Gradle with my builds. Not sure whether this problem also exists in the release branch.

  1. … 3 more files in changeset.
Update Groovydoc

  1. … 1 more file in changeset.
Implement Checkstyle(Extension)#configFile in terms of new Checkstyle(Extension)#config

- cleaner approach

  1. … 3 more files in changeset.
Enable checkstyle task/extension to be configured using a TextResource

- allows to source configuration from resources other than a file

  1. … 4 more files in changeset.
Removed deprecated properties from the Checkstyle and CodeNarc task types.

  1. … 4 more files in changeset.
Changed a bunch of task types to inject services via properties rather than constructor, so that internal services are not made (quite so) visible to subtypes and can be added or removed in a backwards compatible way, and to defer construction of services until they are used.

  1. … 39 more files in changeset.
default Checkstyle.showViolations to true (REVIEW-549)

  1. … 1 more file in changeset.
renamed checkstyle.displayViolations to showViolations (similar to testLogging) polished Javadoc

  1. … 5 more files in changeset.
Merge commit '1220063b5310494912fed7ef'

Conflicts:

subprojects/code-quality/src/integTest/groovy/org/gradle/api/plugins/quality/CheckstylePluginIntegrationTest.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/Checkstyle.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CheckstyleExtension.groovy

subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CheckstylePlugin.groovy

subprojects/code-quality/src/test/groovy/org/gradle/api/plugins/quality/CheckstylePluginTest.groovy

subprojects/docs/src/docs/dsl/org.gradle.api.plugins.quality.Checkstyle.xml

  1. … 5 more files in changeset.