CheckstylePluginVersionIntegrationTest.groovy

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Put code quality integration tests into separate packages

    • -437
    • +0
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 45 more files in changeset.
Use mavenCentral() and jcenter() mirrors in tests where possible

    • -3
    • +1
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 51 more files in changeset.
Introduce `@ToBeImplemented` (#2643)

The `@ToBeImplemented` annotation replaces Groovy's `@NotYetImplemented`.

The problem with `NotYetImplemented` is that tests marked with it succeed no matter what causes the test to fail. Marked tests can pass because the expected failure is still present (which is the purpose of the test), or if the expected failure is replaced by some other failure.

It's better to write a test that explicitly tests for the expected failure, so when it fails for some other reason, it becomes noticeable. The purpose of the `@ToBeImplemented` annotation is to keep such tests easy to find in the code.

    • -8
    • +11
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 9 more files in changeset.
Add tests for up-to-date issue of check tasks that report to console

gradle/gradle#2326

    • -0
    • +25
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 3 more files in changeset.
Add integration coverage for new configDir property for Checkstyle

+review REVIEW-6526

    • -0
    • +79
    ./CheckstylePluginVersionIntegrationTest.groovy
Renders a deprecation warning to the console for ConfigurableReport.setDestination(Object) (#1798)

Use the method ConfigurableReport.setDestination(File) in Gradle's tests to avoid rendering the deprecation message.

    • -2
    • +2
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 10 more files in changeset.
Move decision about which versions of Checkstyle to use to CheckstyleCoverage

    • -2
    • +1
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 2 more files in changeset.
Increase the default version of Checkstyle

We should have bumped this in Gradle 3.0 since we were stuck with Checkstyle 5.9

due to JDK6.

Checkstyle 7.0 only supports JDK8, so introduce something similar to how we handled

JDK6 and older Checkstyle versions.

    • -1
    • +1
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 5 more files in changeset.
GRADLE-2888 Added maxWarnings option to Checkstyle DSL. This option sets the maximum number of warnings that are tolerated before breaking the build or setting the invoked ANT task failure property.

    • -1
    • +38
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 8 more files in changeset.
GRADLE-2888 Renamed new 'maxAllowedViolations' property to 'maxErrors' so as to match the already existing Checkstyle property, and therefore be more intuitive to Checkstyle users.

    • -1
    • +1
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 8 more files in changeset.
Added maxAllowedViolations option to Checkstyle DSL. This option sets the maximum number of code violations that are tolerated before breaking the build or setting the invoked ANT task failure property.

    • -0
    • +17
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 8 more files in changeset.
Polishing

+review REVIEW-6132

    • -0
    • +1
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 1 more file in changeset.
GRADLE-3490: Delete temporary Checkstyle XML report

Signed-off-by: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>

    • -1
    • +0
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 1 more file in changeset.
GRADLE-3490: Checkstyle output when XML report is disabled

Generate the XML report in a temporary location when it is

explictly disabled. We still need to generate it, as it is

used to generate the HTML report.

Enable and update the corresponding test.

Signed-off-by: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>

    • -1
    • +1
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 1 more file in changeset.
Revert "GRADLE-3490: Build output when Checkstyle XML report is disabled"

This reverts commit 0aa085bf2e8781bbc38e84b4a9f0800d49a69a1b.

    • -1
    • +1
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 1 more file in changeset.
GRADLE-3490: Build output when Checkstyle XML report is disabled

Move the XML report from build/reports to build/tmp when it is

explicitly not requested as build output.

Also update the test and enable it.

Signed-off-by: Martin Mosegaard Amdisen <martin.amdisen@praqma.com>

    • -1
    • +1
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 1 more file in changeset.
Add test case for GRADLE-3490

    • -0
    • +22
    ./CheckstylePluginVersionIntegrationTest.groovy
Failing test case for GRADLE-3432

    • -1
    • +34
    ./CheckstylePluginVersionIntegrationTest.groovy
fix more windows ci issues

    • -1
    • +2
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 1 more file in changeset.
Merge Pull Request #568 for stylesheet support in FindBugs and CheckStyle

+review REVIEW-5862

    • -0
    • +27
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 17 more files in changeset.
Switch the stylesheet to a TextResource.

Reference:

- https://github.com/gradle/gradle/pull/568#discussion_r54162495

    • -19
    • +5
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 6 more files in changeset.
Allows the custom stylesheet to be in the classpath for the Checkstyle HTML report.

    • -0
    • +18
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 1 more file in changeset.
Allows the Checkstyle HTML report to be generated with a custom stylesheet.

    • -0
    • +23
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 6 more files in changeset.
Add support for generating HTML reports to the Checkstyle plugin

The committed XSL file was taken from [1].

[1] https://svn.apache.org/repos/asf/hive/trunk/checkstyle/checkstyle-noframes-sorted.xsl

    • -1
    • +20
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 7 more files in changeset.
Move bulk of Checkstyle tests to CheckstylePluginVersionIntegrationTest

+review REVIEW-5583

    • -31
    • +129
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 2 more files in changeset.
Only test multiple versions of Checkstyle on JDK7+

    • -0
    • +3
    ./CheckstylePluginVersionIntegrationTest.groovy
Removing unused import

    • -1
    • +0
    ./CheckstylePluginVersionIntegrationTest.groovy
Test a wider range of checkstyle versions

    • -3
    • +2
    ./CheckstylePluginVersionIntegrationTest.groovy
Added more multiversion build, and extracted method

    • -0
    • +78
    ./CheckstylePluginVersionIntegrationTest.groovy
  1. … 1 more file in changeset.