AbstractFindBugsPluginIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Put code quality integration tests into separate packages

    • -735
    • +0
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 45 more files in changeset.
Fix failed FindBugs integration test on Windows

    • -0
    • +2
    ./AbstractFindBugsPluginIntegrationTest.groovy
Support for FindBugs JVM arguments (#781)

Support for FindBugs JVM arguments

    • -0
    • +41
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 9 more files in changeset.
Use mavenCentral() and jcenter() mirrors in tests where possible

    • -3
    • +1
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 51 more files in changeset.
Introduce `@ToBeImplemented` (#2643)

The `@ToBeImplemented` annotation replaces Groovy's `@NotYetImplemented`.

The problem with `NotYetImplemented` is that tests marked with it succeed no matter what causes the test to fail. Marked tests can pass because the expected failure is still present (which is the purpose of the test), or if the expected failure is replaced by some other failure.

It's better to write a test that explicitly tests for the expected failure, so when it fails for some other reason, it becomes noticeable. The purpose of the `@ToBeImplemented` annotation is to keep such tests easy to find in the code.

    • -4
    • +5
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 9 more files in changeset.
Polish FindBugs progress option

    • -11
    • +28
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 4 more files in changeset.
Add an option to FindBugs to disable analysis progress (#2181)

This fixes https://github.com/gradle/gradle/issues/1646,

https://github.com/gradle/gradle/issues/1307,

https://github.com/gradle/gradle/issues/1756

It has been reported that FindBugs plugin will always print analysis

progress to standard output no matter what the configuration is. It is

because '-progress' command line option is always activated when

staring FindBugs in FindBugsSpecBuilder. This commit add an option to

FindBugs plugin named 'showProgress' to control it. If set to false,

'-progress' will not be passed to FindBugs.

    • -0
    • +36
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 7 more files in changeset.
Add tests for up-to-date issue of check tasks that report to console

gradle/gradle#2326

    • -0
    • +28
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 3 more files in changeset.
Do not resolve classes dirs as a file tree

This causes us to include resources in a way that causes FindBugs to

produce an annoying error message

    • -0
    • +21
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 4 more files in changeset.
Use separate output directories for all JVM languages

- Introduce an outputDir on SourceDirectorySet

- Default output directory is now `build/classes/<source directory set name>/<source set name>`

- Example: Java compilation goes to build/classes/java/main instead of build/classes/main

- Adapt JDepend, FindBugs, Test and ValidateTaskProperties tasks to handle multiple class directories

- Deprecate setClassesDir/getClassesDir on SourceSetOutput

- Calling setClassesDir restores old behavior (shared output directory)

- Introduce addClassesDir and getClassesDirs on SourceSetOutput

- OSGi plugin needs a single classes directory, so introduce 'osgiClasses' task that syncs all classes to a single directory

Most of the changes to integration tests are find classes in their new location. Helper methods in AbstractIntegrationSpec

can locate class files vs hardcoding a path.

Squashed commit of sg-split-jvm-classes branch for REVIEW-6502

    • -5
    • +53
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 119 more files in changeset.
Fixing findbugs integ test to work on IBM Java1.6

    • -1
    • +2
    ./AbstractFindBugsPluginIntegrationTest.groovy
Simplified findbugs worker implementation and adjusted int test expectations for improvements to failure reporting.

    • -2
    • +2
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 7 more files in changeset.
fix more windows ci issues

    • -1
    • +2
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 1 more file in changeset.
Merge Pull Request #568 for stylesheet support in FindBugs and CheckStyle

+review REVIEW-5862

    • -0
    • +30
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 17 more files in changeset.
Switch the stylesheet to a TextResource.

Reference:

- https://github.com/gradle/gradle/pull/568#discussion_r54162495

    • -1
    • +5
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 6 more files in changeset.
Allows the FindBugs HTML report to be generated with a custom stylesheet.

    • -0
    • +26
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 8 more files in changeset.
clean up find bugs tests for extra args

    • -16
    • +19
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
    • -1
    • +40
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 5 more files in changeset.
Don't check exact class name in error output. It'll probably make the test more robust in case FindBugs decides to modify dependencies.

+review REVIEW-5345

    • -1
    • +1
    ./AbstractFindBugsPluginIntegrationTest.groovy
Added integration test that provokes java.lang.Error in bug report.

+review REVIEW-5345

    • -0
    • +16
    ./AbstractFindBugsPluginIntegrationTest.groovy
GRADLE-3212: FindBugs plugin should expose property for setting baseline bugs file.

    • -0
    • +65
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 6 more files in changeset.
Don't run more tests in parallel that might be affected by the concurrent task execution status logging issue. Do nothing in skipped task assertion methods when in parallel execution.

+review REVIEW-5292

    • -0
    • +6
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 30 more files in changeset.
Introduce TextResourceFactory

- cleaner API/DSL for creating text resources

- more modular (factory methods no longer declared in ResourceHandler)

    • -1
    • +1
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 16 more files in changeset.
Rename some of the factory methods for creating TextResource's

- resources.text -> fileText, resources.archiveText -> archiveEntryText

    • -1
    • +1
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 12 more files in changeset.
Make some direct use of new way to configure findbugs filters in integration test

    • -1
    • +1
    ./AbstractFindBugsPluginIntegrationTest.groovy
Tidy-up

    • -1
    • +1
    ./AbstractFindBugsPluginIntegrationTest.groovy
Fixed the problem with findbugs integration test. Ensured it works with java6 cleanly.

    • -7
    • +3
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
Bumped the version of findbugs to 3.0.0.

1. Main motivation is that 3.0.0 works with java8.

2. Reworked the integ test coverage so that it works with java 6,7,8. Next step is to add reasonable error message if someone attempts to run findbugs plugin with old version of java (e.g java6 and lower).

    • -0
    • +386
    ./AbstractFindBugsPluginIntegrationTest.groovy
  1. … 4 more files in changeset.