Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Annotate integ tests failing with instant execution in :buildCache

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +3
    ./gradle/caching/BuildCacheLocalCacheIntegrationTest.groovy
Annotate integ tests failing with instant execution in :buildCache

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +3
    ./gradle/caching/BuildCacheLocalCacheIntegrationTest.groovy
Annotate integ tests failing with instant execution in :buildCache

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +3
    ./gradle/caching/BuildCacheLocalCacheIntegrationTest.groovy
Try SHA-256 cache keys

  1. … 4 more files in changeset.
Fail on unpack failure

Previously we used to try a complicated dance to continue even if unpacking a cached result failed. We did this because wanted to avoid a corrupted cache entry breaking a build. However, with real-world usage it looks like hiding these problems causes more grief, and adds quite some complexity to the process. So we are removing this mitigation now.

  1. … 2 more files in changeset.
Address review feedback

  1. … 5 more files in changeset.
Deprecate specifying the type of the local cache

    • -3
    • +3
    ./gradle/caching/internal/FinalizeBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 10 more files in changeset.
Deprecate specifying the type of the local cache

    • -3
    • +3
    ./gradle/caching/internal/FinalizeBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 10 more files in changeset.
Fix tests

    • -7
    • +5
    ./gradle/caching/internal/FinalizeBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 4 more files in changeset.
Move org.gradle.caching.configuration.internal to :core

  1. … 15 more files in changeset.
Move org.gradle.caching.configuration.internal to :core

  1. … 15 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -2
    • +2
    ./gradle/caching/BuildCacheLocalCacheIntegrationTest.groovy
  1. … 50 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -2
    • +2
    ./gradle/caching/BuildCacheLocalCacheIntegrationTest.groovy
  1. … 98 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -2
    • +2
    ./gradle/caching/BuildCacheLocalCacheIntegrationTest.groovy
  1. … 98 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -2
    • +2
    ./gradle/caching/BuildCacheLocalCacheIntegrationTest.groovy
  1. … 50 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -2
    • +2
    ./gradle/caching/BuildCacheLocalCacheIntegrationTest.groovy
  1. … 98 more files in changeset.
Fix test

Follow up for #8783

Address review comments

  1. … 3 more files in changeset.
Fix tests

Deprecate the use of custom local build caches

We are removing this option because custom local caches complicate the architecture unnecessarily. By always expecting a DirectoryBuildCache we can simplify things a lot. We'll remove the option completely in 6.0.

    • -0
    • +1
    ./gradle/caching/internal/FinalizeBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 8 more files in changeset.
Fix overcounting of unpacked directories

The tar unpacker was counting every root directory except the

first one twice, because it was incrementing its counter before

checking whether it has left the current root.

The increment is now done after this check and a test case for this

condition was added.

  1. … 1 more file in changeset.
spelling: localhost

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

    • -1
    • +1
    ./gradle/caching/internal/FinalizeBuildCacheConfigurationBuildOperationIntegrationTest.groovy
Avoid reinitializing DefaultPersistentDirectoryStores

Prior to this commit, adding a `CleanupAction` when building a

`PersistentCache` using `CacheBuilder.withCleanup()` caused the used

implementation class to be changed from

`DefaultPersistentDirectoryStore` to `DefaultPersistentDirectoryCache`.

The latter adds initialization logic and has a very strict check in

place that verifies whether the lock file has been unlocked cleanly. If

not, it will delete all files in the cache in order to reinitialize it.

Since the mere addition of a cleanup action should not change such a

fundamental behavior, this commit moves the cleanup logic to the

`DefaultPersistentDirectoryStore` class and instantiates it when a

cleanup action is configured but no initialization related properties.

  1. … 6 more files in changeset.
Use file access time journal for build cache

Reuse `DefaultFileAccessTimeJournal` in for tracking file access in

`DirectoryBuildCacheServiceFactory` for consistency with other caches

and to reduce the number of file operations.

Resolves gradle/gradle-private#1337.

  1. … 2 more files in changeset.
Fire buildFinished for the root build after finishing all included builds (#4991)

Take 2.

  1. … 3 more files in changeset.
Revert "Fire buildFinished for the root build after finishing all included builds (#4991)"

This reverts commit 324c2ca7ced373e829e03178490ef8f99de82f00.

  1. … 2 more files in changeset.
Fire buildFinished for the root build after finishing all included builds (#4991)

  1. … 2 more files in changeset.
Fix test name and comments

Fix test

Allow build cache to be enabled programatically for non root builds (#4936)

  1. … 9 more files in changeset.