Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Provide enable information on Finalize Build Cache Configuration Build Operation.

Avoiding the creation of a build cache service on the process.

    • -0
    • +48
    ./http/internal/HttpBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 3 more files in changeset.
Provide enable information on Finalize Build Cache Configuration Build Operation.

Avoiding the creation of a build cache service on the process.

    • -0
    • +48
    ./http/internal/HttpBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 3 more files in changeset.
Revert "Add 'enabled' information to the Finalize Build Cache Configuration Build Operation."

This reverts commit f0cc02c320f7f8b424f90f482fc947267f8f4451.

    • -4
    • +0
    ./http/internal/HttpBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 4 more files in changeset.
Move HTTP build cache config build operation test into its project.

    • -0
    • +127
    ./http/internal/HttpBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 2 more files in changeset.
Refactor org.gradle.logging.level property tests (#1964)

* Split out logging tests

* Clean up tests, ignore failing test

* Code review changes

  1. … 10 more files in changeset.
Inline the describer type into BuildCacheServiceFactory.

  1. … 12 more files in changeset.
Wrap the actual finalisation of the build cache config in an operation.

  1. … 13 more files in changeset.
Propagate BuildCacheServiceFactory API changes.

  1. … 4 more files in changeset.
Add even more error patterns when build cache shuts down.

+review REVIEW-6517

    • -2
    • +3
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
Make test more robust

The test has been flaky, since the message was changing depending on

- the error (Broken pipe/Connection reset)

- when the error happened: In the packer or in the HttpBuildCache

    • -2
    • +2
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 1 more file in changeset.
Move test to a more appropriate home.

    • -181
    • +0
    ./http/internal/FinalizeBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 1 more file in changeset.
Unpack cache types so we get the real name, not the decorated class name.

    • -3
    • +3
    ./http/internal/FinalizeBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 5 more files in changeset.
Expose Build Cache Configuration through a Build Operation.

    • -0
    • +181
    ./http/internal/FinalizeBuildCacheConfigurationBuildOperationIntegrationTest.groovy
  1. … 7 more files in changeset.
Clean up cache integration tests

    • -1
    • +1
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
    • -29
    • +29
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 3 more files in changeset.
Extract test fixture for HttpBuildCache

    • -0
    • +62
    ./http/internal/HttpBuildCacheFixture.groovy
    • -25
    • +1
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
    • -25
    • +1
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 19 more files in changeset.
Report cache key for loading failure

    • -1
    • +1
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 2 more files in changeset.
Use recoverable/non-recoverable in error messages

    • -1
    • +1
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 2 more files in changeset.
Do not fail when storing to the cache fails

    • -0
    • +95
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
    • -3
    • +4
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 9 more files in changeset.
Add redirect integration test for http build cache connector

+review REVIEW-6491

Add timeout to integration tests

The tests have been seen hanging on CI.

    • -0
    • +2
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 1 more file in changeset.
Keep isValid() internal for build cache keys for now

There is no need to add this to the public API at this point.

+review REVIEW-6471

  1. … 2 more files in changeset.
Use DefaultHttpBuildCacheServiceFactory to create a build cache in test

+review REVIEW-6478

  1. … 1 more file in changeset.
Enable preemptive authentication for build cache

+review REVIEW-6479

    • -12
    • +64
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 1 more file in changeset.
Add authentication support to HttpServerFixture

This allows to enable authentication on the BuildCache for

integration tests.

+review REVIEW-6479

    • -86
    • +28
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 13 more files in changeset.
Add test for build cache preemptive authentication

+review REVIEW-6479

Use the same HttpClient configuration for the HTTP build cache

+review REVIEW-6478

  1. … 9 more files in changeset.
Rework description use

+review REVIEW-6464

  1. … 9 more files in changeset.
Make sure we get an UnknownHostException

On my computer I got NoRouteToHostException instead, because for some reason `invalid` resolved to 127.0.0.1.

+review REVIEW-6464

    • -2
    • +2
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
Use a guaranteed invalid hostname

+review REVIEW-6461

    • -2
    • +2
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
Fail the HttpBuildCache on UnknownHostException

We considered this recoverable and it is not.

+review REVIEW-6461

    • -0
    • +17
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 1 more file in changeset.