Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -12
    • +12
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 98 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -12
    • +12
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 98 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -3
    • +3
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 50 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -12
    • +12
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 98 more files in changeset.
Fix failing after HTTP deprecation refactor

Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

  1. … 7 more files in changeset.
Fix tests

  1. … 11 more files in changeset.
Fix tests

  1. … 2 more files in changeset.
Fix tests

    • -2
    • +2
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
Relax test assertion for build build cache test

The message is slightly different when running on Java 10 on Windows.

    • -1
    • +2
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
Relax test assertion for build build cache test

The message is slightly different when running on Java 10 on Windows.

    • -1
    • +2
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
Set timeout for AbstractIntegrationSpec (#5806)

We have been bitten by CI build exection timeout for a long time.

This PR introduces timeout for AbstractIntegrationSpec in order to

monitor execution timeout. Upon timeout, a spock interceptor can

print all threads' stack traces in all JVMs so that we can diagnose

the potential issues in other JVMs (daemons, test workers, etc.).

    • -2
    • +2
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 29 more files in changeset.
Fix CompositeBuildEventsIntegrationTest usage of output test fixtures

    • -2
    • +2
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 6 more files in changeset.
Don't retry failed build cache HTTP uploads (#4770)

The BuildCacheService SPI does not support implementations pulling on the provided input stream more than once.

    • -5
    • +3
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 2 more files in changeset.
Change int tests to use relevant fixture methods to express their expectations about the build log output.

    • -2
    • +1
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 30 more files in changeset.
Allow enabling build cache in all integration tests

Signed-off-by: Lóránt Pintér <lorant@gradle.com>

    • -2
    • +2
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
    • -23
    • +23
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 25 more files in changeset.
Improve failure message for build cache redirect (#3636)

  1. … 1 more file in changeset.
Build cache should not follow HTTP redirects (#3517)

  1. … 9 more files in changeset.
Revert "Revert "Introduce HTTP timeout (#3041)""

This reverts commit 14711361a0cb6beb3a57766804c109ba6f3f87c0.

    • -0
    • +16
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 12 more files in changeset.
Revert "Introduce HTTP timeout (#3041)"

This reverts commit 59153d58c906341cfe3b5bebbedf289e3def1e09.

    • -16
    • +0
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 12 more files in changeset.
Introduce HTTP timeout (#3041)

Introduce HTTP connection and socket timeout

Fix https://github.com/gradle/gradle/issues/868

    • -0
    • +16
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 12 more files in changeset.
Introduce HTTP connection and socket timeout

    • -0
    • +16
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 17 more files in changeset.
Revert Http socket/connection timeouts for the release (#2879)

    • -16
    • +0
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 18 more files in changeset.
Add flag to allow untrusted ssl connections to build cache (#2790)

    • -0
    • +36
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 9 more files in changeset.
Add test for http build cache timeout (#2782)

Fixing #868 via #2757 also introduces timeouts for connecting to an

HTTP build cache. We just add a test to verify this.

While writing the test I realized that we do not print the real cause

for failing with the HTTP backend when not printing the stack trace,

so I fixed that, too.

    • -2
    • +18
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 3 more files in changeset.
Add task path to task output build cache key (#2668)

    • -1
    • +2
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
  1. … 17 more files in changeset.
Set content length when uploading HTTP build cache entry

    • -17
    • +29
    ./http/internal/HttpBuildCacheServiceTest.groovy
  1. … 5 more files in changeset.
Improve error feedback for build cache errors (#2473)

We shouldn't fail the build when we can't package a task's outputs. We should also not fail the build when unpacking some already downloaded outputs.

If there was a failure during unpacking, we can expect the task's output files to be in a messed up state. If this happens, we explicitly clean all of the task's outputs, update the pre-execution output file snapshots, and force the task to execute in non-incremental mode.

This commit also removes the retry logic we had previously when "recoverable" errors were encountered while downloading or uploading cached results. Instead, all errors (except for the aforementioned failed unpacking cleanup errors) are recoverable, and we simply switch off the cache for the build after the first such error.

    • -2
    • +3
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 26 more files in changeset.
Store artifacts from the remote cache in the local cache

When the default local directory build cache is used, we use an optimized

way to store the downloaded artifact in the cache. Using a custom local

cache, or with the local cache disabled, a temporary file will be used

to store the downloaded artifact.

Packing is also separated from uploading to the remote cache. Again,

when the default directory cache is used to store the cached artifact in

the local cache before uploading it to the remote cache. With a custom

local cache, or when a local cache is not enabled, task outputs will be

stored in a temporary file before uploading.

Build operations are emitted separately for packing, unpacking,

uploading and downloading the cache artifact.

    • -4
    • +4
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
    • -1
    • +1
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 55 more files in changeset.
Rename test HTTP build cache server to HttpBuildCacheServer

+review REVIEW-6548

    • -10
    • +10
    ./http/internal/HttpBuildCacheConfigurationBuildOperationIntegrationTest.groovy
    • -3
    • +3
    ./http/internal/HttpBuildCacheServiceErrorHandlingIntegrationTest.groovy
    • -15
    • +15
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 4 more files in changeset.
Use preemptive auth with credentials in URL (#2272)

    • -0
    • +52
    ./http/internal/DefaultHttpBuildCacheServiceFactoryTest.groovy
    • -1
    • +1
    ./http/internal/HttpBuildCacheConfigurationBuildOperationIntegrationTest.groovy
    • -5
    • +5
    ./http/internal/HttpBuildCacheServiceIntegrationTest.groovy
  1. … 1 more file in changeset.