Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Allow handle package definition in antlr4

- add some more test coverage for antlr4

- rework invocation of different antlr implementations

  1. … 5 more files in changeset.
Tweak some wording and docs as to what PropertyDetails.getGetters() (and setters) actually represents.

Tweak a few test names.

+review REVIEW-5561

  1. … 1 more file in changeset.
Documents class inspection and PropertyDetails

+review REVIEW-5557

  1. … 1 more file in changeset.
[GRADLE-3317] Cleans up class inspection post code review * Moves test closer to the real issue * Adds more coverage to class inspector test * Prevents redundantly walking the super class hierarchy

+review REVIEW-5557

  1. … 3 more files in changeset.
[GRADLE-3317] Changes class inspection to inspect superclasses before interfaces

+review

  1. … 2 more files in changeset.
Add the inheritance “structure” to ClassDetails.

+review REVIEW-5536

  1. … 1 more file in changeset.
Bust out class inspector internal types so they can be used elsewhere.

+review REVIEW-5536

    • -0
    • +40
    ./MethodSignature.java
    • -0
    • +77
    ./MutableClassDetails.java
    • -0
    • +53
    ./MutablePropertyDetails.java
Reorganised managed model creation to have the schema provide the creation strategy.

This allows custom schema extraction strategies to have a say in how objects are to be created.

+review REVIEW-5536

  1. … 49 more files in changeset.
Moves check for default toString to Reflection util class

+review REVIEW-5501

  1. … 2 more files in changeset.
Make DirectInstantiator a singleton.

  1. … 89 more files in changeset.
Adding generic types to readableField methods

+review REVIEW-5337

Adding support for locating static methods to JavaReflectionUtil

+review REVIEW-5337

  1. … 3 more files in changeset.
Making PropertyAccessor generic

+review REVIEW-5337

  1. … 4 more files in changeset.
Converting play javascript compiler to use JavaReflectionUtil

+review REVIEW-5337

  1. … 1 more file in changeset.
Changed ClassInspector to traverse the graph of interfaces for a class. Use this in ManagedProxyClassGenerator

  1. … 2 more files in changeset.
Extracted ClassInspector from AbstractClassGenerator so that the logic can be reused elsewhere.

    • -0
    • +206
    ./ClassInspector.java
    • -0
    • +28
    ./PropertyDetails.java
  1. … 2 more files in changeset.
Added missing 'char' to 'Character' to JavaReflectionUtil's mapping from primitive to boxed types.

Simplify MethodDescription, move to base reflection services and reuse.

    • -0
    • +104
    ./MethodDescription.java
  1. … 6 more files in changeset.
Attach generated implementation classes (weakly) to schema objects, instead of using a global cache.

This is done to avoid having to go through another cache and acquire a lock every time we need to instantiate a managed type.

This does make unit testing slightly more inconvenient in that a singleton schema store has to be used for all tests, but I deemed this an acceptable trade off.

+review REVIEW-5329

    • -0
    • +48
    ./MethodSignatureEquivalence.java
  1. … 19 more files in changeset.
Added a RuleAction implementation that’s backed by a RuleSource class with a single @Mutate method

  1. … 2 more files in changeset.
Unpack more of the base component rule definition handler to not require abstract methods.

Motivation here is less boilerplate for subclasses, stronger typing, and more clearly defined semantics.

+review REVIEW-5081

  1. … 8 more files in changeset.
Fixed source file name

    • -0
    • +26
    ./NoSuchMethodException.java
Some clean up of JavaReflectionUtil

- Tightened up definition of what method() does when no matching method can be found

- Removed readField() as it is only used by a test

    • -0
    • +26
    ./NoSuchMEthodException.java
  1. … 3 more files in changeset.
When reflectively invoking a method, wrap thrown checked exceptions in UncheckedException instead of GradleException.

This was particularly problematic when invoking task actions, as the real exception was being masked in the output to the user.

  1. … 1 more file in changeset.
When reflectively invoking a method, wrap thrown checked exceptions in UncheckedException instead of GradleException.

This was particularly problematic when invoking task actions, as the real exception was being masked in the output to the user.

  1. … 1 more file in changeset.
More cleanup on Help for Tasks based on reviews

- REVIEW-3460 add support for enums

- REVIEW-3459 move knowledge from CommandLineTaskConfigurer to CommandLineOptionDescriptor

- knowledge bout option parameters

- how to apply option on tasks

- REVIEW-3459 - dont support '--flag true' just use '--flag' instead

  1. … 10 more files in changeset.
Moved some classes out of org.gradle.util.

  1. … 62 more files in changeset.
Some minor tidy-ups.

  1. … 1 more file in changeset.
Reworked the property handling of JavaReflectionUtil

- Replaced readProperty() and writeProperty() with methods to look up properties.

- Tightened up what is considered a getter or setter method (eg don't consider static methods).

    • -0
    • +26
    ./NoSuchPropertyException.java
    • -0
    • +25
    ./PropertyAccessor.java
    • -0
    • +25
    ./PropertyMutator.java
  1. … 5 more files in changeset.
GRADLE-2863 - don't get involved in private method calls in the dynamic object stuff.

I originally thought we needed to get the desired behaviour, but it turns out that's only necessary for static inner classes. Therefore, we are simplifying our stuff by dropping support for decorating static inner classes. This lack of support is enforced in any way yet though.

  1. … 6 more files in changeset.