lang

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Polish

Cache accessors globally

See #340

    • -14
    • +9
    ./kotlin/accessors/AccessorsClassPath.kt
Add missing license header

Move from ScriptPluginFactoryProvider SPI to ScriptingLanguage SPI

See #37

    • -38
    • +0
    ./kotlin/provider/KotlinScriptPluginFactoryProvider.kt
    • -0
    • +10
    ./kotlin/provider/KotlinScriptingLanguage.kt
  1. … 2 more files in changeset.
@Inject KotlinScriptPluginFactory

Explicit return types

On members for which such explicitness is required by dokka

Tighten exported API

This commit adds `internal` or `private` to internal members

The only exported API that includes Gradle internals is now in .provider

See #209

    • -0
    • +1
    ./kotlin/provider/CachingKotlinCompiler.kt
    • -0
    • +1
    ./kotlin/provider/ClassLoaderHierarchy.kt
    • -0
    • +2
    ./kotlin/provider/JarGenerationProgressMonitorProvider.kt
    • -1
    • +1
    ./kotlin/provider/KotlinScriptPluginFactoryProvider.kt
    • -1
    • +3
    ./kotlin/resolver/KotlinBuildScriptDependenciesResolver.kt
  1. … 9 more files in changeset.
Reuse implicit imports provided by Gradle and add Kotlin specifics

    • -1
    • +2
    ./kotlin/provider/CachingKotlinCompiler.kt
    • -3
    • +2
    ./kotlin/resolver/KotlinBuildScriptDependenciesResolver.kt
    • -2
    • +10
    ./kotlin/resolver/KotlinBuildScriptModelBuilder.kt
    • -0
    • +27
    ./kotlin/support/GlobalServices.kt
    • -7
    • +16
    ./kotlin/support/ImplicitImports.kt
Add source dir of generated project accessors to script source path

Enables navigation to the sources and quick documentation access.

See #281

    • -12
    • +15
    ./kotlin/accessors/AccessorsClassPath.kt
    • -10
    • +20
    ./kotlin/resolver/KotlinBuildScriptModelBuilder.kt
    • -2
    • +7
    ./kotlin/resolver/SourcePathProvider.kt
  1. … 4 more files in changeset.
Unclutter resolver log output

- Print each property on its own line

- Use a more compact representation for path and namespace lists

- Make log file name order predictable

    • -0
    • +75
    ./kotlin/resolver/CompactTree.kt
    • -107
    • +1
    ./kotlin/resolver/KotlinBuildScriptDependenciesResolver.kt
    • -0
    • +62
    ./kotlin/resolver/ResolverEvent.kt
    • -0
    • +166
    ./kotlin/resolver/ResolverEventLogger.kt
  1. … 1 more file in changeset.
Polish

    • -2
    • +1
    ./kotlin/resolver/KotlinBuildScriptDependenciesResolver.kt
Integration test samples

See #345

  1. … 32 more files in changeset.
Move source path computation to the server side

See #281

    • -5
    • +1
    ./kotlin/resolver/KotlinBuildScriptDependenciesResolver.kt
    • -3
    • +12
    ./kotlin/resolver/KotlinBuildScriptModelBuilder.kt
    • -8
    • +8
    ./kotlin/resolver/SourcePathProvider.kt
  1. … 1 more file in changeset.
Dedupe script classpath computation

    • -24
    • +24
    ./kotlin/provider/KotlinScriptClassPathProvider.kt
    • -10
    • +10
    ./kotlin/resolver/KotlinBuildScriptModelBuilder.kt
  1. … 1 more file in changeset.
Unify handling of JIT and AOT project accessors

This is the first step toward fixing #340.

Resolves #338

Resolves #339

    • -0
    • +186
    ./kotlin/accessors/AccessorsClassPath.kt
    • -0
    • +94
    ./kotlin/accessors/CodeGenerator.kt
    • -43
    • +0
    ./kotlin/accessors/DisplayAccessors.kt
    • -144
    • +0
    ./kotlin/accessors/ProcessProjectSchema.kt
    • -63
    • +0
    ./kotlin/accessors/ProjectExtensionsBuildSrcConfigurationAction.kt
    • -85
    • +13
    ./kotlin/accessors/ProjectSchema.kt
    • -0
    • +30
    ./kotlin/accessors/SingletonProperties.kt
    • -0
    • +42
    ./kotlin/accessors/tasks/DisplayAccessors.kt
    • -0
    • +56
    ./kotlin/accessors/tasks/GenerateProjectSchema.kt
    • -0
    • +36
    ./kotlin/cache/BuildServices.kt
    • -0
    • +63
    ./kotlin/cache/ScriptCache.kt
    • -0
    • +59
    ./kotlin/provider/BuildServices.kt
    • -49
    • +17
    ./kotlin/provider/CachingKotlinCompiler.kt
  1. … 13 more files in changeset.
Polish `KotlinScriptRootPlugin`

Extract cache properties to field

- Makes it easier to find it

- Avoids recreating the map on every query to the cache

    • -1
    • +4
    ./kotlin/provider/CachingKotlinCompiler.kt
Bump cache version due to the latest API changes

    • -1
    • +1
    ./kotlin/provider/CachingKotlinCompiler.kt
Rename `NamedDomainObjectContainer{Configuration => Scope}`

    • -3
    • +3
    ./kotlin/NamedDomainObjectContainerExtensions.kt
Rename `ClientModule{Configuration => Scope}`

    • -6
    • +6
    ./kotlin/DependencyHandlerExtensions.kt
Polish

- Normalise placement of `private`, `protected`, `internal` and

`inline` modifiers

    • -5
    • +8
    ./kotlin/DependencyHandlerExtensions.kt
    • -2
    • +4
    ./kotlin/DomainObjectCollectionExtensions.kt
    • -2
    • +4
    ./kotlin/ExtensionContainerExtensions.kt
    • -1
    • +2
    ./kotlin/NamedDomainObjectContainerExtensions.kt
    • -1
    • +2
    ./kotlin/ObjectConfigurationActionExtensions.kt
    • -2
    • +4
    ./kotlin/PolymorphicDomainObjectContainerExtensions.kt
    • -1
    • +2
    ./kotlin/accessors/ProjectExtensionsBuildSrcConfigurationAction.kt
    • -6
    • +12
    ./kotlin/codegen/ApiExtensionsJar.kt
    • -10
    • +20
    ./kotlin/provider/CachingKotlinCompiler.kt
    • -1
    • +2
    ./kotlin/provider/ClassLoaderHierarchy.kt
    • -1
    • +2
    ./kotlin/provider/JarGenerationProgressMonitorProvider.kt
  1. … 28 more files in changeset.
Execute Kotlin build scripts when computing the classpath

But ignore errors because any classpath is better than no classpath.

See #339

Return previous dependencies when TAPI model request fails

See #249

    • -1
    • +1
    ./kotlin/resolver/KotlinBuildScriptDependenciesResolver.kt
Log timestamp of `log` invocation

    • -6
    • +7
    ./kotlin/resolver/KotlinBuildScriptDependenciesResolver.kt
Fix GenerateProjectSchema UP-TO-DATE behavior

By declaring its inputs

Configuration accessors for convention and configuration return Unit

Make it explicit so Dokka doesn’t have to infer it

Generated configuration accessor for conventions returns Unit

For consistency with generated accessors for extensions

Favor Any? over * in CopySpec extensions

Favor `<expr>.run { ... }` over `with (<expr>) { ... }`

    • -1
    • +1
    ./kotlin/accessors/ProjectExtensionsBuildSrcConfigurationAction.kt
    • -1
    • +1
    ./kotlin/accessors/ProjectExtensionsTaskRegistrationAction.kt
    • -1
    • +1
    ./kotlin/resolver/KotlinBuildScriptDependenciesResolver.kt
  1. … 1 more file in changeset.
Remove ProjectExtensionsTaskRegistrationAction, apply a plugin instead

That way, no need to check for .kts files presence.

Builds not using gsk won’t suffer the performance penalty anymore.

Builds using gsk will benefit a small performance gain.

See #320

    • -50
    • +0
    ./kotlin/accessors/ProjectExtensionsTaskRegistrationAction.kt
    • -0
    • +40
    ./kotlin/provider/KotlinScriptBasePlugin.kt
    • -0
    • +3
    ./kotlin/provider/KotlinScriptPlugin.kt
  1. … 2 more files in changeset.