Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Stricter binary compatibility check of deprecated members

Let binary compatibility check not ignore changes on @Deprecated members

the way it does it for @Incubating members.

This commit makes modifying/adding/removing deprecated members an error

and the change to be explicitly accepted.

A since annotation is also required when introducing a new deprecated

member.

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 1 more file in changeset.
Stricter binary compatibility check of deprecated members

Let binary compatibility check not ignore changes on @Deprecated members

the way it does it for @Incubating members.

This change makes that adding deprecated members is an error and that the

change must be explicitely accepted.

A since annotation is also required when introducing a new member,

deprecated or not.

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 1 more file in changeset.
Stricter binary compatibility check of deprecated members

Let binary compatibility check not ignore changes on @Deprecated members

the way it does it for @Incubating members.

This commit makes modifying/adding/removing deprecated members an error

and the change to be explicitly accepted.

A since annotation is also required when introducing a new deprecated

member.

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 1 more file in changeset.
Detect removed methods only in public superclass

There were some slight problems in the

`MethodsRemovedInInternalSuperClassRule` causing to report methods

removed from a super class in the public API in all its subclasses.

For example, when removing two deprecated methods from `DefaultTask`,

the removal was needed to be accepted in all task implementations.

Moreover, we only checked the signature of a removed method not the

name of the method.

  1. … 3 more files in changeset.
Revert "Merge pull request #9759 from gradle/eskatos/kotlin/1.3.40"

This reverts commit 2c6fb9495acea6a150ad313ed3474ebc3689b920, reversing

changes made to 8959fc43370bc5141db6f775b333f36d30cc42a1.

  1. … 26 more files in changeset.
Fix Kotlin compilation warnings

- Suppress `unchecked_cast` warnings

- Rename parameters to match base definition

- Remove unnecessary casts

- Remove unnecessary/duplicate interface implementation

- Help the compiler understand the expressions are indeed used

  1. … 4 more files in changeset.
Fix Kotlin compilation warnings

- Suppress `unchecked_cast` warnings

- Rename parameters to match base definition

- Remove unnecessary casts

- Remove unnecessary/duplicate interface implementation

- Help the compiler understand the expressions are indeed used

  1. … 4 more files in changeset.
Fix Kotlin compilation warnings

- Suppress `unchecked_cast` warnings

- Rename parameters to match base definition

- Remove unnecessary casts

- Remove unnecessary/duplicate interface implementation

- Help the compiler understand the expressions are indeed used

  1. … 4 more files in changeset.
Fix Kotlin compilation warnings

- Suppress `unchecked_cast` warnings

- Rename parameters to match base definition

- Remove unnecessary casts

- Remove unnecessary/duplicate interface implementation

- Help the compiler understand the expressions are indeed used

  1. … 4 more files in changeset.
Exclude @Inject in @since compatibility check (#9916)

Previously we only exclude `@Inject` getters in `@Incubating` compatibility check but not for `@Since` check. This PR fixes it then removes the unnecessary entries in `accepted-api-changes.json`.

  1. … 1 more file in changeset.
Exclude @Inject in @since compatibility check

  1. … 1 more file in changeset.
Exclude @Inject in @since compatibility check

  1. … 1 more file in changeset.
Make `HasKotlinFlagsMetadataQuery` compatible with Kotlin 1.3.41

By replacing the generic return types with multiple constraints

by subtypes of all constrained types.

Add missing @Override to all modules

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 1003 more files in changeset.
Add missing @Override to all modules

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 997 more files in changeset.
Let binary compatibility check kotlin source resolution work on windows

by normalizing source file paths

Signed-off-by: Paul Merlin <paul@gradle.com>

Let binary compatibility check kotlin source resolution work on windows

by normalizing source file paths

Signed-off-by: Paul Merlin <paul@gradle.com>

try

Signed-off-by: Paul Merlin <paul@gradle.com>

try

Signed-off-by: Paul Merlin <paul@gradle.com>

try

Signed-off-by: Paul Merlin <paul@gradle.com>

Compatibility rule for Kotlin `operator` and `infix` modifiers change

Generalizing the existing isKotlinInternal metadata query so it can be

used for more Kotlin flags in the future.

It is now used for the 3 flags queries.

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 1 more file in changeset.
Polish BinaryCompatibilityRepository

Rename factory method arguments for clarity

Signed-off-by: Paul Merlin <paul@gradle.com>

Extract boolean expression for clarity

Signed-off-by: Paul Merlin <paul@gradle.com>

Polish `BinaryCompatibilityRepositoryPostProcessRule`

- Suppress warning

- Dedupe `context.userData[...]` expression for clarity

Polish `JApiClass.sourceFilePath`

Polish `SinceAnnotationMissingRule`

- Rename method for improved prose

- Extract complex expression to its own method

Polish `NullabilityBreakingChangesRule`

- Rename method for clarity

- Expand complex expression

Refine isKotlinInternal metadata query

by clarifying the visitation flow, checking members flags only when

their jvm signature matches

Signed-off-by: Paul Merlin <paul@gradle.com>

Refine binary compatibility check types

by removing spurious printlns

and cleaning up imports

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 2 more files in changeset.
Polish IsKotlinInternalMetadataQuery

Signed-off-by: Paul Merlin <paul@gradle.com>